Leverage on out keyword in reduction and where functions of dpctl.tensor#1808
Merged
antonwolfy merged 11 commits intomasterfrom May 6, 2024
Merged
Leverage on out keyword in reduction and where functions of dpctl.tensor#1808antonwolfy merged 11 commits intomasterfrom
out keyword in reduction and where functions of dpctl.tensor#1808antonwolfy merged 11 commits intomasterfrom
Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html |
antonwolfy
force-pushed
the
dpctl-where-reductions-out-kw
branch
from
7d47e37 to
e8cf5e5
Compare
vtavana
reviewed
May 3, 2024
vtavana
reviewed
May 5, 2024
github-actions bot
added a commit
to antonwolfy/dpnp
that referenced
this pull request
May 6, 2024
…l.tensor` (IntelPython#1808) * Pass out keyword to dpctl in reduction functions * Pass out and order keywords to dpctl.tensor.where * Add wrapping methods to reduce code duplication * Update docstring comments * Resolve issue from spelling check * Separate wrapping function to reduction utils * Fix pre-commit issues * Fixed a typo * Applied review comments 4dc16b4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR implements of
outkeywords of reduction functions fromdpctl.tensorinterface andoutandorderkeywords ofdpctl.tensor.wherefunction (see gh-1643 for more details how it was implemented in dpctl).Additionally the PR adds some improvements to docstrings of dpnp functions which were identified during the implementation.