Implements out keyword for where and reductions and order keyword for where#1643
Merged
ndgrigorian merged 11 commits intomasterfrom Apr 18, 2024
Merged
Implements out keyword for where and reductions and order keyword for where#1643ndgrigorian merged 11 commits intomasterfrom
out keyword for where and reductions and order keyword for where#1643ndgrigorian merged 11 commits intomasterfrom
Conversation
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_243 ran successfully. |
Collaborator
Contributor
|
Overall, good change, thanks @ndgrigorian ! Love the increase in coverage |
… paths for zero-size arrays This prevents possible edge cases where an array with a non-zero number of elements could be allocated prior to an error being thrown for a reduction being performed over a size-zero axis
Avoids a call to permute_dims in reductions when `axis=None` Make reduction tests more efficient by reusing an array of zeros rather than reconstructing
ndgrigorian
force-pushed
the
where-reductions-out-kw
branch
from
faa0e69 to
16b631f
Compare
|
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_308 ran successfully. |
oleksandr-pavlyk
approved these changes
Apr 18, 2024
Contributor
oleksandr-pavlyk
left a comment
oleksandr-pavlyk
left a comment
There was a problem hiding this comment.
LGTM, thank you @ndgrigorian !
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request proposes building on the set of functions supporting the
outkeyword in dpctl. Specifically, this pull request implements this keyword in all reductions (e.g.,sum,max,argmax) andwhere. This paves the way for statistical functions to support the keyword, and may make some function calls more efficient.This pull request also implements the
orderkeyword inwhere, now defaulting toorder="K"behavior rather thanorder="A".