Fix configuration and Travis errors#175
Conversation
|
Still waiting here |
|
Oops, completely missed that one. Still relevant for #150 though (right?) |
|
The Travis build still fails on Django 2.2+, though I can't reproduce the error locally. |
Not Sure, selected_idps Will be Always false in that position, so the if Is useless I think. |
auth_group schema does not work there. |
|
I've now updated the Travis dist to get rid of the schema errors and simultanesly dropped support for Python 3.4 (EOL 2019-03-18): I've kept Python 3.5 which has its EOL 2020-09-13: https://devguide.python.org/devcycle/#end-of-life-branches Travis build: https://travis-ci.org/knaperek/djangosaml2/builds/638821120 @knaperek This PR now contains a mixed bag of fixes, are you okay with merging it as-is or should I split it up into multiple PRs first? |
|
Nice, if my point of view Means something here:
Old versions of Django could be dropped as well |
|
this also should be refactored: https://github.com/knaperek/djangosaml2/pull/167/files |
|
Regarding the change of selected_idp, if I remove the if-statement I get the following error from the tests: |
Ok @OskarPersson That's important, my excuses here. |
|
@knaperek Anything missing for merge? |
|
All good, tack så mycket! |
Fixes regressions from #150 and #151