selected_idps variable now get the only available idp instead of None#150
Merged
knaperek merged 1 commit intoIdentityPython:masterfrom Dec 16, 2019
peppelinux:selected_idps
Merged
selected_idps variable now get the only available idp instead of None#150knaperek merged 1 commit intoIdentityPython:masterfrom peppelinux:selected_idps
knaperek merged 1 commit intoIdentityPython:masterfrom
peppelinux:selected_idps
Conversation
Contributor
|
Ok. So if there's only one IdP in the remote metadata, just go ahead and assume that is the IdP to send the request for authentication to that one? That seems reasonable if it's a documented feature, though OTOH, the Zen of Python echos in my mind, saying "In the face of ambiguity refuse the temptation to guess". |
Member
Author
|
I didn't understand but it sounds good 👍 |
Member
Author
|
Without this PR if an user put a wrong metadata (that have any idsspo descriptor) this message let him understand what's the problem |
Collaborator
|
OK, please rebase and I'll merge this. Thanks. |
otherwise next logger message will print None Better exception handling on missing IDP configuration. Better LOG message if only one idp is available new file: djangosaml2/exceptions.py modified: djangosaml2/views.py
Member
Author
|
rebased, thank you as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usefull to avoid an error message in the log if the SP is federated to one IDP instead of more then one.