Skip to content

Figure.text: Fix the checking of parameters 'font' and 'angle' #4577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seisman merged 4 commits into from
Apr 11, 2026
Merged

Figure.text: Fix the checking of parameters 'font' and 'angle' #4577

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6f565e0
Figure.text: Fix the checking of 'font'/'angle'
seisman Apr 11, 2026
e76741e
Fix the logic
seisman Apr 11, 2026
8bf8735
Merge branch 'main' into text/fix-check
seisman Apr 11, 2026
7bf2f7f
False is considered as int
seisman Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions pygmt/src/text.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
it="use_word",
w="wrap",
)
def text_( # noqa: PLR0912, PLR0913
def text_( # noqa: PLR0912, PLR0913, PLR0915
self,
textfiles: PathLike | TableLike | None = None,
x=None,
Expand Down Expand Up @@ -118,12 +118,12 @@ def text_( # noqa: PLR0912, PLR0913
of the map.
text
The text string, or an array of strings to plot on the figure.
angle: float, str, bool or list
angle
Set the angle measured in degrees counter-clockwise from
horizontal (e.g. 30 sets the text at 30 degrees). If no angle is
explicitly given (i.e. ``angle=True``) then the input to ``textfiles``
must have this as a column.
font : str, bool or list of str
font
Set the font specification with format *size*\ ,\ *font*\ ,\ *color*
where *size* is text size in points, *font* is the font to use, and
*color* sets the font color. For example,
Expand Down Expand Up @@ -228,13 +228,15 @@ def text_( # noqa: PLR0912, PLR0913

# Build the -F option.
if kwargs.get("F") is None and any(
v is not None for v in (position, angle, font, justify)
v is not None or v is not False for v in (position, angle, font, justify)
):
kwargs.update({"F": ""})

for arg, flag, _ in array_args:
if arg is True:
kwargs["F"] += flag
elif arg is False:
pass
elif isinstance(arg, int | float | str):
kwargs["F"] += f"{flag}{arg}"

Expand Down
Loading