Skip to content

Figure.text: Fix the checking of parameters 'font' and 'angle'#4577

Merged
seisman merged 4 commits intomainfrom
text/fix-check
Apr 11, 2026
Merged

Figure.text: Fix the checking of parameters 'font' and 'angle'#4577
seisman merged 4 commits intomainfrom
text/fix-check

Conversation

@seisman
Copy link
Copy Markdown
Member

@seisman seisman commented Apr 11, 2026

Address #4489 (comment)

Related to #4355.

@seisman seisman changed the title Figure.text: Fix the checking of 'font'/'angle' Figure.text: Fix the checking of parameters 'font'/'angle' Apr 11, 2026
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Apr 11, 2026
@seisman seisman added this to the 0.19.0 milestone Apr 11, 2026
@seisman seisman changed the title Figure.text: Fix the checking of parameters 'font'/'angle' Figure.text: Fix the checking of parameters 'font' and 'angle' Apr 11, 2026
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Apr 11, 2026
@yvonnefroehlich
Copy link
Copy Markdown
Member

Hmmm. Looking at the documentation for this PR this warning is still there:
https://pygmt-dev--4577.org.readthedocs.build/en/4577/gallery/embellishments/text_formatting.html

@seisman
Copy link
Copy Markdown
Member Author

seisman commented Apr 11, 2026

Hmmm. Looking at the documentation for this PR this warning is still there: pygmt-dev--4577.org.readthedocs.build/en/4577/gallery/embellishments/text_formatting.html

Should be fixed by 7bf2f7f. The reason is that insinstance(False, int) returns True.

@seisman seisman merged commit c75dc72 into main Apr 11, 2026
18 of 22 checks passed
@seisman seisman deleted the text/fix-check branch April 11, 2026 13:27
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Apr 11, 2026
@yvonnefroehlich
Copy link
Copy Markdown
Member

yvonnefroehlich commented Apr 11, 2026

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants