Support DraftRetriever datastore read/write for large vocab sizes (i.e. llama3+) and REST inference for llama3#24
Merged
zhenyuhe00 merged 4 commits intoFasterDecoding:llama3from Nov 22, 2024
Conversation
Author
|
@zhenyuhe00 Here's a new PR with a separate branch and added changes to |
Collaborator
|
Hi, I appreciate your effort! Since the repository only has the "main" branch, I added a new branch called "llama3" just now. It could be merged into the "llama3" branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here we make the necessary changes to read and write suffixes to memory and file for large tokenizers; the original implementation only supported token IDs up to Rust
u16::MAX(65,535). Crucially, using Rusti32for reading and writing individual token IDs (instead ofu16originally) allows the tool to support token IDs of up to Rusti32::MAX(2,147,483,647), and still allows negative placeholder IDs for padding in the implementation like -2.We also make the necessary adjustments to
rest/modeling_llama_kv.pyto support llama3 inference with REST, adapted from the transformers implementation. Importantly, we need torepeat_kvfor new keys and values before concatenating them to cached keys and values, in order to avoid shape mismatches (by only adding a single query group to all cached keys and values).Including the old PR here for reference. Thanks! 🦙