Support DraftRetriever datastore read/write for large tokenizers and vocabulary sizes (i.e. llama3+)#23
Closed
scandukuri wants to merge 2 commits intoFasterDecoding:mainfrom
Closed
Support DraftRetriever datastore read/write for large tokenizers and vocabulary sizes (i.e. llama3+)#23scandukuri wants to merge 2 commits intoFasterDecoding:mainfrom
scandukuri wants to merge 2 commits intoFasterDecoding:mainfrom
Conversation
Collaborator
|
Hi, |
Author
|
Yes! Can make a ‘llama3’ branch. I can make the existing changes (DraftRetriever) + the necessary changes to modeling_llama_kv.py.
|
Collaborator
|
That sounds great! Appreciate your effort. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here we make the necessary changes to read and write suffixes to memory and file for large tokenizers; the original implementation only supported token IDs up to Rust u16::MAX (65,535).
Crucially, using Rust i32 for reading and writing individual token IDs (instead of u16 originally) allows the tool to support token IDs of up to Rust i32::MAX (2,147,483,647), and still allows negative placeholder IDs for padding in the implementation like -2.