fix(packaging): publish Fallout.VisualStudio.SolutionPersistence; bump to 10.3 - #107
Merged
Merged
Conversation
…p to 10.3 Fallout.SolutionModel 10.2.24 through 10.2.34 are unrestorable: the wrapper csproj for the vendored SolutionPersistence fork was marked IsPackable=false, so dotnet pack fell back to emitting a dependency on the assembly name (Microsoft.VisualStudio.SolutionPersistence) at the Fallout version (10.2.x). That ID exists on nuget.org (real Microsoft package, max 1.0.52) but the 10.2.x versions don't, so restore fails for any consumer of Fallout.SolutionModel, Fallout.Common, Fallout.Build, Fallout.ProjectModel, or Fallout.Components. Fix: - Make src/Fallout.VisualStudio.SolutionPersistence/ packable as Fallout.VisualStudio.SolutionPersistence (PackageId set explicitly; AssemblyName stays Microsoft.VisualStudio.SolutionPersistence for drop-in type identity). Initial ID reservation (0.0.1-reserve) was uploaded manually to nuget.org to claim the ID under the Fallout.* prefix — see [[project_nuget_prefix_gotcha]]. CI's PushPackageFiles filter only excludes Nuke.*, so the wrapper now flows through. - Bump version.json from 10.2 → 10.3 so the fixed line is clearly delineated from the broken 10.2.24–34 range (which will be unlisted on nuget.org as a follow-up). - Update docs/dependencies.md vendored-source row to note the package now ships to nuget.org alongside the rest of Fallout.*. Fallout.SourceGenerators is unaffected: its ProjectReference to the wrapper uses PrivateAssets="all" and it bundles the DLL into the analyzer payload, so no public Microsoft.* dep ever leaked. Verification: dotnet pack on the wrapper produces a clean nupkg; Fallout.SolutionModel.nuspec now declares `<dependency id="Fallout.VisualStudio.SolutionPersistence" ... />` instead of the bogus Microsoft.* reference. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
ChrisonSimtian
added a commit
that referenced
this pull request
May 22, 2026
Without --skip-duplicate, a single failed push aborts the whole publish
target, and a rerun then fails with HTTP 409 ("already exists") on
every package that did succeed the first time. That makes release.yml
non-recoverable from any partial-failure state, which we hit twice
today (#107 → SolutionPersistence prefix-reservation, then again
mid-key-permission-debug).
With --skip-duplicate, the push step returns success when a version
is already on nuget.org. Reruns are now safe and only the genuinely
missing packages get uploaded.
Wired via IPublish.PushSettings override (Configure<DotNetNuGetPushSettings>),
which composes on top of the existing PushSettingsBase in
Fallout.Components.
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fallout.SolutionModel10.2.24–10.2.34 are unrestorable: the vendored SolutionPersistence wrapper wasIsPackable=false, sodotnet packemitted a dep on the assembly name (Microsoft.VisualStudio.SolutionPersistence) at the Fallout version. That ID exists on nuget.org (real Microsoft package, max 1.0.52) but at 10.2.x it doesn't — restore fails for downstream consumers.Fallout.VisualStudio.SolutionPersistence(PackageId set explicitly;AssemblyNamestaysMicrosoft.VisualStudio.SolutionPersistencefor drop-in type identity). Initial ID was reserved on nuget.org manually (0.0.1-reserve) per the prefix gotcha.version.jsonfrom 10.2 → 10.3 so the fix lands on a fresh minor line, clearly delineating it from the broken 10.2.24–34 range.Affected published versions (to unlist after merge)
Fallout.SolutionModelFallout.CommonFallout.BuildFallout.ProjectModelFallout.ComponentsFallout.SourceGeneratorsis unaffected (ProjectReference usesPrivateAssets="all"; DLL is bundled into the analyzer payload).Test plan
dotnet pack src/Fallout.VisualStudio.SolutionPersistenceproduces a clean nupkg with correct ID and polyfill deps on netstandard2.0dotnet pack src/Fallout.SolutionModelnow declares<dependency id="Fallout.VisualStudio.SolutionPersistence" .../>🤖 Generated with Claude Code