Skip to content

[No QA] Docs updates for E/A#95483 date-bound distance rate editable settings#96049

Merged
zanyrenney merged 2 commits into
mainfrom
claude-docsDateBoundMileageRate
Jul 17, 2026
Merged

[No QA] Docs updates for E/A#95483 date-bound distance rate editable settings#96049
zanyrenney merged 2 commits into
mainfrom
claude-docsDateBoundMileageRate

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

#95483 removes the dateBoundMileageRate beta gate, releasing date-bound (Start date / End date) distance rates to everyone. The help site article Set Distance Rates already documented adding a rate with a Start date and End date and how rates are selected by expense date, but the How to edit Distance rate settings section did not list Start date and End date as editable settings — even though those rows are now shown and editable on the rate details page for all users.

Changes

  • Added Start date and End date to the list of editable settings under How to edit Distance rate settings.
  • Fixed a typo (a dDistance expensea Distance expense) in the rate-selection section.

UI labels verified against src/languages/en.ts (Start date, End date).

Related


@rlinoz, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Co-authored-by: Rodrigo Lino da Costa <rlinoz@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jul 14, 2026
@MelvinBot MelvinBot mentioned this pull request Jul 14, 2026
52 tasks
@rlinoz
rlinoz marked this pull request as ready for review July 14, 2026 12:23
@rlinoz
rlinoz requested a review from stephanieelliott as a code owner July 14, 2026 12:23
Comment thread docs/articles/new-expensify/workspaces/Set-distance-rates.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment
This PR makes two small, well-scoped edits to docs/articles/new-expensify/workspaces/Set-distance-rates.md in support of releasing date-bound distance rates (removal of the dateBoundMileageRate beta gate). It adds Start date and End date to the list of editable settings under How to edit Distance rate settings, and corrects a typo (a dDistance expense becomes a Distance expense) in the rate-selection section. The changes accurately reflect current product behavior and keep the article consistent with the rest of the page.

Scores Summary

  • Readability: 10/10 - The added list items are consistent with the existing settings list, and the typo fix improves clarity. No flow or scannability concerns.
  • AI Readiness: 10/10 - Changes reuse UI-exact labels (Start date, End date), reinforce existing task-based headings, and do not disturb metadata or heading hierarchy.
  • Style Compliance: 10/10 - Field labels match the UI (verified against src/languages/en.ts), bold formatting is applied to UI labels, and terminology (Distance, Workspace, member) follows the naming conventions.

Key Findings

  • The typo fix (dDistance becomes Distance) corrects a genuine defect in the previously published content and improves retrieval and readability.
  • Adding Start date and End date to the editable-settings list closes a documentation gap: these rows are now shown and editable for all users, so the list now matches actual behavior.
  • Both additions are consistent with the article existing terminology, bolding, and list style; no new style deviations introduced.
  • Scope is tightly controlled (3 additions, 1 deletion), staying within the single documented workflow.

Recommendations

  • No blocking changes required. The diff is compliant with all three governance documents.
  • Minor optional consideration (not introduced by this PR, so out of scope): the article intermittently uses Distance Rates vs Distance rates casing; a future pass could align casing across the page against the exact UI label.

Files Reviewed

  • docs/articles/new-expensify/workspaces/Set-distance-rates.md - Approved. Two accurate, in-scope edits that align documentation with current behavior.

Note: This PR is small and self-contained; the findings above cover the full diff.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@stephanieelliott
stephanieelliott requested a review from a team July 16, 2026 04:25
@melvin-bot

melvin-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @zanyrenney

@melvin-bot
melvin-bot Bot requested review from zanyrenney and removed request for a team July 16, 2026 04:25
@melvin-bot

melvin-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

@zanyrenney Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions github-actions Bot changed the title Docs updates for E/A#95483 date-bound distance rate editable settings [No QA] Docs updates for E/A#95483 date-bound distance rate editable settings Jul 16, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://2d511772.helpdot.pages.dev ⚡️

Updated articles:

@zanyrenney
zanyrenney merged commit 3a0d4e9 into main Jul 17, 2026
16 checks passed
@zanyrenney
zanyrenney deleted the claude-docsDateBoundMileageRate branch July 17, 2026 13:08
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/zanyrenney in version: 9.4.41-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.4.41-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants