[No QA] Docs updates for E/A#95729 Lowercase workspace role labels#95847
[No QA] Docs updates for E/A#95729 Lowercase workspace role labels#95847MelvinBot wants to merge 3 commits into
Conversation
Co-authored-by: James Dean <jamesdeanexpensify@users.noreply.github.com>
MelvinBot
added
the
HelpDot
|
@MelvinBot please resolve conflicts |
|
I looked into resolving the conflicts on this PR, but I can only make code changes (including merging This PR's author/assignees are To have me resolve the conflicts, either:
|
|
@jamesdeanexpensify please request it |
|
@MelvinBot please resolve conflicts |
…itles-95729 Co-authored-by: James Dean <jamesdeanexpensify@users.noreply.github.com> # Conflicts: # docs/articles/new-expensify/workspaces/Managing-Workspace-Members.md
|
✅ Resolved the merge conflicts and pushed the merge of The only conflict was in Please double-check the merged file and re-run any checks before marking it |
github-actions
Bot
changed the title
This comment has been minimized.
This comment has been minimized.
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@kadiealexander Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| - **Payments Admin** – Can manage workspace payment settings in the **Payments** section of **Workflows**, including business bank accounts, the authorized expense payer, and payment methods. Payment permissions are otherwise unchanged, so paying a report still depends on the relevant bank account being shared with the payer. Has read-only access to the workspace overview and Members, and all other workspace editor pages are hidden. (Control workspaces only) | ||
| - **Workspace admin** – Can manage members, roles, workflows, and settings. | ||
| - **Card admin** – Can manage the Expensify Card and Company cards, including issuing cards, setting limits, and assigning company cards. Has read-only access to Overview and Members, and all other workspace settings pages are hidden. (Control workspaces only) | ||
| - **People admin** – Can manage workspace membership and configure approval workflows. People admins can add and remove Members and Auditors only, and cannot add or remove Admins or other scoped admin roles. They have read-only access to the workspace overview and edit access to Members and the Approvals section of Workflows. All other workspace editor pages are hidden. (Control workspaces only) |
There was a problem hiding this comment.
Inconsistent capitalization: This line now lowercases the role label to "People admins", but standalone "Admins" ("cannot add or remove Admins or other scoped admin roles") remains title-cased. Per the Core UI Referencing Rules and the Deterministic Writing Rule ("Be consistent"), the same role term must use one consistent casing. Lowercase "admins" to match the updated role labels.
| **Tip:** You can also invite members under **Settings > Profile** by clicking **Share** to send the workspace’s URL or QR code. | ||
|
|
||
| **Note:** Workspace Admins and People Admins can invite members. People Admins can only invite users as **Members** or **Auditors** — they cannot invite Admins or other scoped admin roles. | ||
| **Note:** Workspace admins and People admins can invite members. People admins can only invite users as **Members** or **Auditors** — they cannot invite Admins or other scoped admin roles. |
There was a problem hiding this comment.
Inconsistent capitalization: You lowercased "Workspace admins" and "People admins" here, but "Admins" ("they cannot invite Admins or other scoped admin roles") is still title-cased on the same line. Per the Deterministic Writing Rule ("Be consistent") and exact-UI matching, use consistent casing — lowercase "admins".
| - **Workspace Admins** – Shows only members with the Admin role (not available on Submit workspaces). | ||
| - **Card Admins** – Shows only members with the Card Admin role (Control workspaces only). | ||
| - **Payments Admins** – Shows only members with the Payments Admin role (Control workspaces only). | ||
| - **Workspace admins** – Shows only members with the Admin role (not available on Submit workspaces). |
There was a problem hiding this comment.
Inconsistent capitalization: The filter label was lowercased to "Workspace admins", but the description still references "the Admin role" in title case. Per Core UI Referencing (match capitalization exactly) and the Deterministic Writing Rule, use the same casing for the role — lowercase "admin role".
| If someone no longer needs access to your workspace, you can remove them individually or in bulk to keep your member list up to date. | ||
|
|
||
| **Note:** Workspace Admins and People Admins can remove members. People Admins can only remove **Members** and **Auditors** — they cannot remove Admins or other scoped admin roles. | ||
| **Note:** Workspace admins and People admins can remove members. People admins can only remove **Members** and **Auditors** — they cannot remove Admins or other scoped admin roles. |
There was a problem hiding this comment.
Inconsistent capitalization: "Workspace admins" and "People admins" are lowercased here, but "Admins" ("they cannot remove Admins or other scoped admin roles") remains title-cased on the same line. Apply consistent lowercase casing per the Deterministic Writing Rule.
| 4. Select the new role and confirm. | ||
|
|
||
| **Note:** People Admins can change a member’s role between **Member** and **Auditor** only. Granting or removing the Admin role or any scoped admin role (such as Card Admin, People Admin, or Payments Admin) requires a Workspace Admin. | ||
| **Note:** People admins can change a member’s role between **Member** and **Auditor** only. Granting or removing the Admin role or any scoped admin role (such as Card admin, People admin, or Payments admin) requires a Workspace admin. |
There was a problem hiding this comment.
Inconsistent capitalization: This line lowercases "Card admin, People admin, or Payments admin" and "Workspace admin", but leaves "the Admin role" title-cased. Per Core UI Referencing (match capitalization exactly) and the Deterministic Writing Rule ("Be consistent"), lowercase "admin role" to match the updated labels.
HelpDot Documentation ReviewOverall AssessmentThis is a small, focused PR (13 additions / 13 deletions) that normalizes workspace role labels in Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This is a top-level summary review based solely on the proposed diff. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 383189fa6a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - **Workspace admins** – Shows only members with the Admin role (not available on Submit workspaces). | ||
| - **Card admins** – Shows only members with the Card admin role (Control workspaces only). | ||
| - **Payments admins** – Shows only members with the Payments admin role (Control workspaces only). |
There was a problem hiding this comment.
In the workspace members role filter I checked src/components/Tables/WorkspaceMembersTable/index.tsx, which renders these options from workspace.people.admins, cardAdmins, and paymentsAdmins; those translations still resolve in src/languages/en.ts to Workspace Admins, Card Admins, and Payments Admins. Lowercasing the filter labels here makes the help article no longer match the actual dropdown text for that flow, which conflicts with the stated goal of documenting exact UI labels.
Useful? React with 👍 / 👎.
NicolasBonet
left a comment
NicolasBonet
left a comment
There was a problem hiding this comment.
Many more changes are needed @jamesdeanexpensify, please ask Melvin to take care of them
|
@MelvinBot please implement the changes |
Co-authored-by: James Dean <jamesdeanexpensify@users.noreply.github.com>
|
✅ Implemented the review's follow-up — normalized the residual Title-Case role references in What changed (7 occurrences):
What I intentionally left capitalized: the exact single-word UI labels — Please give the preview a quick look and re-run checks before marking Note: I couldn't run |
|
A preview of your ExpensifyHelp changes have been deployed to https://ac0d72d6.helpdot.pages.dev ⚡️ Updated articles: |
5 participants
Explanation of Change
PR #95729 changed the workspace role labels shown in the app to sentence case in
en.ts:Workspace Admin→Workspace adminCard Admin→Card adminPeople Admin→People adminPayments Admin→Payments adminThis updates the canonical roles article
Managing-Workspace-Members.md, where these appear as the exact UI role labels (the role-definition list, the role filter options, and the change-role notes), so the help site matches the current UI capitalization perdocs/HELPSITE_NAMING_CONVENTIONS.md("Use the exact text shown in the product UI. Match capitalization exactly.").Scope note:
Workspace Adminis used ~1,553 times across ~669 help-site files as a general persona/role reference in prose (e.g. "ask a Workspace Admin to…"). Those were intentionally left unchanged — they are editorial prose rather than direct UI-label references, and a site-wide sweep is a much larger, riskier change. If a broader normalization is desired, that should be scoped separately. Single-word labels (Owner,Auditor,Editor,Member) are unchanged since only the first word is capitalized in sentence case.Fixed Issues
$ #95729
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
QA
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
@jamesdeanexpensify, please review the files changed and confirm they reflect the current behavior. Then mark this PR
Ready for review.