[NO QA] Change role titles to lowercase in en.ts#95729
Conversation
melvin-bot
Bot
requested review from
NicolasBonet and
trjExpensify
and removed request for
a team
|
@NicolasBonet Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 884ab825d3a..5f081ea74eb 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -4528,7 +4528,7 @@ ${amount} für ${merchant} – ${date}`,
case CONST.POLICY.ROLE.CARD_ADMIN:
return 'Kartenverwaltung';
case CONST.POLICY.ROLE.PEOPLE_ADMIN:
- return 'Personen-Admin';
+ return 'Personalverwaltung';
case CONST.POLICY.ROLE.PAYMENTS_ADMIN:
return 'Zahlungsadministrator';
case CONST.POLICY.ROLE.USER:
diff --git a/src/languages/es.ts b/src/languages/es.ts
index bd852e71be4..077c2e97f33 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -4402,7 +4402,7 @@ ${amount} para ${merchant} - ${date}`,
case CONST.POLICY.ROLE.EDITOR:
return 'Editor';
case CONST.POLICY.ROLE.CARD_ADMIN:
- return 'Admin. de tarjeta';
+ return 'Administrador de tarjeta';
case CONST.POLICY.ROLE.PEOPLE_ADMIN:
return 'Administrador de personas';
case CONST.POLICY.ROLE.PAYMENTS_ADMIN:
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index f95fba59b69..4dd0f666e73 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -4530,7 +4530,7 @@ ${amount} pour ${merchant} - ${date}`,
case CONST.POLICY.ROLE.OWNER:
return 'Responsable';
case CONST.POLICY.ROLE.ADMIN:
- return 'Administrateur d’espace de travail';
+ return 'Administrateur de l’espace de travail';
case CONST.POLICY.ROLE.AUDITOR:
return 'Auditeur';
case CONST.POLICY.ROLE.EDITOR:
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 90d72768c86..a2d3cdbdc01 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -4511,7 +4511,7 @@ ${amount} per ${merchant} - ${date}`,
case CONST.POLICY.ROLE.EDITOR:
return 'Editor';
case CONST.POLICY.ROLE.CARD_ADMIN:
- return 'Amministrazione carta';
+ return 'Amministrazione carte';
case CONST.POLICY.ROLE.PEOPLE_ADMIN:
return 'Amministrazione persone';
case CONST.POLICY.ROLE.PAYMENTS_ADMIN:
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 6cfc60a5505..bbdf0cb22db 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -4500,15 +4500,15 @@ ${amount} voor ${merchant} - ${date}`,
case CONST.POLICY.ROLE.OWNER:
return 'Eigenaar';
case CONST.POLICY.ROLE.ADMIN:
- return 'Werkruimtebeheerder';
+ return 'Beheerder van werkruimte';
case CONST.POLICY.ROLE.AUDITOR:
return 'Auditor';
case CONST.POLICY.ROLE.EDITOR:
return 'Editor';
case CONST.POLICY.ROLE.CARD_ADMIN:
- return 'Kaartbeheerder';
+ return 'Kaartbeheer';
case CONST.POLICY.ROLE.PEOPLE_ADMIN:
- return 'Personenbeheer';
+ return 'Beheer personen';
case CONST.POLICY.ROLE.PAYMENTS_ADMIN:
return 'Beheerder betalingen';
case CONST.POLICY.ROLE.USER:
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 1f792004cfc..bbedb41f46c 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -4496,9 +4496,9 @@ ${amount} para ${merchant} - ${date}`,
case CONST.POLICY.ROLE.EDITOR:
return 'Editor';
case CONST.POLICY.ROLE.CARD_ADMIN:
- return 'Administrador do cartão';
+ return 'Admin do cartão';
case CONST.POLICY.ROLE.PEOPLE_ADMIN:
- return 'Admin de pessoas';
+ return 'Administração de pessoas';
case CONST.POLICY.ROLE.PAYMENTS_ADMIN:
return 'Admin de pagamentos';
case CONST.POLICY.ROLE.USER:
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index b84fa29da09..cd2aa684b93 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -4381,11 +4381,11 @@ ${amount}，商户：${merchant} - 日期：${date}`,
case CONST.POLICY.ROLE.AUDITOR:
return '审计员';
case CONST.POLICY.ROLE.EDITOR:
- return '编辑';
+ return '编辑者';
case CONST.POLICY.ROLE.CARD_ADMIN:
return '卡片管理员';
case CONST.POLICY.ROLE.PEOPLE_ADMIN:
- return '人员管理';
+ return '人员管理员';
case CONST.POLICY.ROLE.PAYMENTS_ADMIN:
return '付款管理员';
case CONST.POLICY.ROLE.USER:
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
NicolasBonet
left a comment
NicolasBonet
left a comment
There was a problem hiding this comment.
@jamesdeanexpensify please add the linked issue and address the two errors in CI
|
@MelvinBot please implement the Polyglot Parrot translations @NicolasBonet sorry, I'm not an engineer, so I'm not sure how to address the two errors in CI. There isn't an associated issue, this is just a small copy update that I noticed from a product screenshot. Does that help? Thank you! |
Co-authored-by: James Dean <jamesdeanexpensify@users.noreply.github.com>
|
🤖 Done — I applied the Polyglot Parrot translations and pushed them to this branch in About the two CI errors — neither is caused by your copy change (this PR only touches
How to clear them: update this branch with the latest You can ignore the |
|
They passed now, so merging @jamesdeanexpensify |
|
@NicolasBonet looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Reviewer Checklist
|
|
I forgot the PR checklist in comments: https://github.com/Expensify/App/actions/runs/29039203197/job/86191850247 Adding it now |
|
🚀 Deployed to staging by https://github.com/NicolasBonet in version: 9.4.33-0 🚀
|
|
🤖 Help site review complete — a docs update is warranted. This PR changes the workspace role labels shown in the app to sentence case ( The canonical roles article, Draft PR: #95847 Scope note: @jamesdeanexpensify, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
4 participants
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari