fix: Home - Action button disappears the second time an expense is opened from "Recently Added" by mhawryluk · Pull Request #94466 · Expensify/App

mhawryluk · 2026-06-24T13:58:56Z

Explanation of Change

Opening the same expense from Home "Recently added" could show different header actions on consecutive taps: the first open sometimes showed the report view (MoneyReportHeader with Submit/Pay/Approve), and the second showed the transaction thread view (MoneyRequestHeader with just "More"). The cause was that getReportIDToOpenForExpense decided between the two based on whether the transaction thread was already known (childReportID present in the Search snapshot). On a freshly created expense that's initially absent, so the first open fell back to the parent report, but opening it creates the thread, and the re-fired search then surfaced the childReportID, so the second open routed to the thread instead. The transaction thread is the intended view here: it's the single expense detail and it hosts the prev/next carousel for swiping between recently added expenses. The report view only ever appeared via the fallback. Now every navigation from "Recently added" lands on the transaction thread (showing the "More" menu plus the prev/next carousel when there are siblings).

Fixed Issues

$ #94311
PROPOSAL: N/A

Tests

Open any workspace chat.
Create a new report and a manual expense inside it.
Navigate to "Home" > "Recently Added" (rather quickly).
Click on the just created expense.
Verify that when RHP is opened, the transaction view does not show Submit/Pay/Approve action buttons, just More and arrows if there are more Recently added expenses.
Close RHP and click on the expense again.
Verify it looks the same this time around.

Add an expense to a workspace in OldDot or on another device (also to a report with no other expenses).
In NewDot, clear cache, open "Home" > "Recently Added" and wait for the expense row to appear. Do not open the expense's report from anywhere else first.
Click on the expense row.
Verify the RHP opens the transaction thread view: only "More" (plus prev/next arrows if there are more than one recently added expenses). No Submit/Pay/Approve buttons.
Close the RHP and click on the expense again.
Verify it looks the same.

Offline tests

N/A

QA Steps

Same as tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Nagranie.z.ekranu.2026-06-24.o.17.48.10.mov

MacOS: Chrome / Safari

Nagranie.z.ekranu.2026-06-24.o.15.28.13.mov

Nagranie.z.ekranu.2026-06-25.o.16.05.44.mov

…ened from "Recently Added"

adamgrzybowski · 2026-06-24T15:57:00Z

LGTM

codecov · 2026-06-24T16:08:10Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/TransactionThreadNavigationUtils.ts	`100.00% <100.00%> (+11.11%)`	⬆️
src/libs/actions/Report/index.ts	`70.59% <100.00%> (+0.36%)`	⬆️
src/libs/actions/TransactionThreadNavigation.ts	`70.96% <100.00%> (+4.30%)`	⬆️
src/pages/home/RecentlyAddedSection/index.tsx	`97.77% <ø> (ø)`
.../home/RecentlyAddedSection/useRecentlyAddedData.ts	`86.66% <100.00%> (+47.95%)`	⬆️
... and 504 files with indirect coverage changes

melvin-bot · 2026-06-24T16:10:15Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-06-24T16:10:19Z

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

App/src/libs/TransactionThreadNavigationUtils.ts

Lines 56 to 57 in d4bcf47

    
           if (!iouAction) { 
        
               return reportID;

Preserve snapshot actions when creating threads

When the Recently Added row is backed only by the Search snapshot, the parent IOU action can be absent from the main reportActions_ collection even though it was present in searchResults.data (for example after clearing Onyx or for an expense added on another device). In that case getIOUActionForReportID() returns nothing here and we still navigate to the parent report; opening that parent can then create the transaction thread, so the next tap routes to the thread and the first/second-open header inconsistency remains. The descriptor needs to carry the snapshot ReportAction/parent report so this path can create the thread without depending on hydrated main Onyx actions.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

ZhenjaHorbach · 2026-06-25T07:52:06Z

💡 Codex Review

App/src/libs/TransactionThreadNavigationUtils.ts

Lines 56 to 57 in d4bcf47

if (!iouAction) {

return reportID;

Preserve snapshot actions when creating threads
When the Recently Added row is backed only by the Search snapshot, the parent IOU action can be absent from the main reportActions_ collection even though it was present in searchResults.data (for example after clearing Onyx or for an expense added on another device). In that case getIOUActionForReportID() returns nothing here and we still navigate to the parent report; opening that parent can then create the transaction thread, so the next tap routes to the thread and the first/second-open header inconsistency remains. The descriptor needs to carry the snapshot ReportAction/parent report so this path can create the thread without depending on hydrated main Onyx actions.

ℹ️ About Codex in GitHub

@mhawryluk
Sounds logical

mhawryluk · 2026-06-25T07:58:19Z

@mhawryluk Sounds logical

yeah, I will look into this

…Onyx

mhawryluk · 2026-06-25T14:16:46Z

yeah, I will look into this

@ZhenjaHorbach should be fixed now, I also updated steps in Tests that I thought would cover it, but actually I'm not able to reproduce the supposed issue (it requires the transaction's IOU action to not be in Onyx and it never happens to me)

trjExpensify

Bug fix for new feature 👍

github-actions · 2026-06-26T10:54:53Z

🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here.

grgia

NAB. Heads up @mhawryluk this might overlap with #94308 and #94180 on useRecentlyAddedData.ts and TransactionThreadNavigationUtils.ts. Maybe worth confirming merge order with @adamgrzybowski ?

ZhenjaHorbach · 2026-06-26T11:02:30Z

For some reason in this branch we don't show loader for expenses after clearing cache or relogin

2026-06-26.13.01.42.mov

adamgrzybowski · 2026-06-26T12:29:46Z

@grgia There shouldn't be any overlap, but just in case, let's merge PRs you mentioned first and this one last

mhawryluk · 2026-06-26T13:48:46Z

For some reason in this branch we don't show loader for expenses after clearing cache or relogin

I'm looking into this, but so far I'm not able to reproduce it. if I understand correctly the issue is the view disappearing briefly, right? does it always happen or only on some platforms/accounts?

ZhenjaHorbach · 2026-06-26T13:59:20Z

I think the main problem
That instead skeleton we show content that does not fully load

mhawryluk · 2026-06-26T14:18:03Z

okay, that makes sense. it definitely could be related to these changes. the skeleton only shows up when the thread's reportID is undefined and not when it is in other ways incomplete and createTransactionThreadReport creates the report optimistically, so it's valid, but not full until OpenReport command finishes. no solution jumps out to me at first, but I will come back to this

mhawryluk · 2026-06-26T14:29:00Z

but since I'm not able to reproduce, could you confirm that it does not happen on main? @ZhenjaHorbach

ZhenjaHorbach · 2026-06-29T13:39:27Z

Unfortunately, on main everything is good

…rges the report to the main onyx collections

mhawryluk · 2026-07-01T11:20:24Z

@ZhenjaHorbach I pushed some code that I hope will fix it. I managed to kinda reproduce it, but by majorly changing the code to force getReportIDToOpenForExpense to call createTransactionThreadReport which I suspect is the path you're hitting. could you please retest?

ZhenjaHorbach · 2026-07-01T14:31:31Z

Nice
Checking!

ZhenjaHorbach · 2026-07-01T14:40:19Z

@mhawryluk
And we have prettier issue

ZhenjaHorbach · 2026-07-01T15:07:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2026-07-01.17.18.57.mov

Android: mWeb Chrome

2026-07-01.17.16.22.mov

iOS: HybridApp

2026-07-01.17.18.57.mov

iOS: mWeb Safari

2026-07-01.17.16.22.mov

MacOS: Chrome / Safari

2026-07-01.17.15.15.mov

ZhenjaHorbach · 2026-07-01T15:21:41Z

LGTM

Only this comment was left

@mhawryluk And we have prettier issue

grgia

nothing blocking

OSBotify · 2026-07-02T13:14:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-02T13:16:41Z

🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-02T13:22:53Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94466.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-48c72147819-78d7f86-90a8c9c08ba171682f417fae67db5761f0827732/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-48c7214-78d7f86-4993c0a032ed91df330562d1246b27d3fa52208b/index.html

Web 🕸️
https://94466.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-03T16:43:18Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.4.27-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-03T16:45:24Z

🤖 Help site review — no docs changes required.

I reviewed the changes in this PR against Expensify's help-site articles under App/docs/articles and did not find any that need updating.

Why no changes are required

This PR is an internal routing/navigation bug fix. It changes which view opens when tapping an expense in Home → Recently Added so that it consistently lands on the transaction thread view (the single-expense detail with the More menu and prev/next carousel) instead of occasionally showing the report view with Submit/Pay/Approve buttons on a second tap. All edits are in code (TransactionThreadNavigationUtils.ts, actions/Report, RecentlyAddedSection, tests) — there is:

No user-facing copy, label, button, tab, or setting change
No new or altered feature, workflow, or configuration
No behavior that any existing help article documents

I searched the help site for the relevant concepts:

"Recently Added" — the only matches are Sage Intacct / NetSuite export-error articles referring to recently added GL accounts, unrelated to the Home section.
Carousel / transaction thread / action buttons — the one match, Getting Started with the Spend Page.md, describes report previews in workspace chat (a separate feature), not the Home Recently Added section or the transaction-thread header this PR fixes.

Since this is a bug fix restoring intended behavior with no documented UI surface affected, no help-site update is needed, so I did not create a draft docs PR.

If you believe a help article should describe this behavior, let me know which one and I'll draft the update.

OSBotify · 2026-07-06T15:30:14Z

🚀 Deployed to production by https://github.com/grgia in version: 9.4.27-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

fix: Home - Action button disappears the second time an expense is op…

780e9a3

…ened from "Recently Added"

melvin-bot Bot assigned mhawryluk Jun 24, 2026

Merge branch 'main' into fix/recently-added-action-buttons

d4bcf47

mhawryluk marked this pull request as ready for review June 24, 2026 16:10

mhawryluk requested review from a team as code owners June 24, 2026 16:10

melvin-bot Bot requested review from a team, ZhenjaHorbach and trjExpensify and removed request for a team June 24, 2026 16:10

melvin-bot Bot requested a review from grgia June 24, 2026 16:10

melvin-bot Bot removed the request for review from a team June 24, 2026 16:10

chatgpt-codex-connector Bot reviewed Jun 24, 2026

View reviewed changes

mhawryluk added 2 commits June 25, 2026 15:04

Cover the case of missing report and reportAction for transaction in …

b80ce73

…Onyx

Add unit tests and update existing

a772d1a

trjExpensify previously approved these changes Jun 25, 2026

View reviewed changes

grgia previously approved these changes Jun 26, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

Merge branch 'main' into fix/recently-added-action-buttons

02210cd

mhawryluk dismissed stale reviews from grgia and trjExpensify via 02210cd June 30, 2026 10:07

Update createTransactionThreadReport to merge reportAction when it me…

bc25990

…rges the report to the main onyx collections

ZhenjaHorbach approved these changes Jul 1, 2026

View reviewed changes

melvin-bot Bot requested a review from grgia July 1, 2026 15:21

Fix prettier

5df93d4

grgia approved these changes Jul 2, 2026

View reviewed changes

grgia merged commit 48c7214 into Expensify:main Jul 2, 2026
34 checks passed

OSBotify mentioned this pull request Jul 3, 2026

Deploy Checklist: New Expensify 2026-07-03 #95291

Closed

98 tasks

melvin-bot Bot mentioned this pull request Jul 6, 2026

[Due for payment 2026-07-13] Home - Action button disappears the second time an expense is opened from "Recently Added" #94311

Closed

7 tasks

Uh oh!

Conversation

mhawryluk commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

adamgrzybowski commented Jun 24, 2026

Uh oh!

codecov Bot commented Jun 24, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jun 24, 2026

Uh oh!

melvin-bot Bot commented Jun 24, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

ZhenjaHorbach commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💡 Codex Review

Uh oh!

mhawryluk commented Jun 25, 2026

Uh oh!

mhawryluk commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Jun 26, 2026

Uh oh!

This comment has been minimized.

adamgrzybowski commented Jun 26, 2026

Uh oh!

mhawryluk commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Jun 26, 2026

Uh oh!

mhawryluk commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mhawryluk commented Jun 26, 2026

Uh oh!

ZhenjaHorbach commented Jun 29, 2026

Uh oh!

mhawryluk commented Jul 1, 2026

Uh oh!

ZhenjaHorbach commented Jul 1, 2026

Uh oh!

ZhenjaHorbach commented Jul 1, 2026

Uh oh!

ZhenjaHorbach commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jul 2, 2026

Uh oh!

mhawryluk commented Jun 24, 2026 •

edited

Loading

codecov Bot commented Jun 24, 2026 •

edited by github-actions Bot

Loading

ZhenjaHorbach commented Jun 25, 2026 •

edited

Loading

mhawryluk commented Jun 25, 2026 •

edited

Loading

mhawryluk commented Jun 26, 2026 •

edited

Loading

mhawryluk commented Jun 26, 2026 •

edited

Loading

ZhenjaHorbach commented Jul 1, 2026 •

edited

Loading

ZhenjaHorbach commented Jul 1, 2026 •

edited

Loading