[Home Page] Fix recently added bugs by adamgrzybowski · Pull Request #94308 · Expensify/App

adamgrzybowski · 2026-06-23T13:06:06Z

Explanation of Change

The Home "Recently added" section was leaking placeholder merchant values: empty merchants rendered as "(none)" for scan expenses and "Expense" for p2p expenses instead of showing nothing. This is now normalized (via the shared merchant-display helper) so an empty merchant renders blank.
The same section displayed amounts as absolute values, so negative amounts (credits/refunds) on expense-report transactions lost their negative sign. The amount now respects the parent report type and shows the correct sign, matching how transactions render elsewhere in the app.
The same section's date column never showed the year for past-year dates (e.g. it showed "Jun 7" instead of "Jun 7, 2025"). Past-year dates now include the year, and the shared date column widens to fit so the value isn't truncated, matching the Spend table.
The section was shown to guests (anonymous users viewing a public room while logged out), where it rendered its empty state. It is now hidden entirely for anonymous users.

Fixed Issues

$ #94249
$ #94250
$ #94251
$ #94272
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

Verify that no errors appear in the JS console

QA Steps

Create a scan expense with an invalid receipt that fails scanning (empty merchant), then go to Home and verify the merchant row in the "Recently added" section is blank (not "(none)" or "Expense").
Create a p2p expense with an empty merchant, go to Home, and verify its merchant row is also blank.
Create an expense with a negative amount, go to Home, and verify the amount cell in the "Recently added" section shows the negative sign.
Create (or have) an expense dated in a previous year, go to Home, and verify the date in the "Recently added" section shows the year (e.g. "Jun 7, 2025") and is not truncated.
Log out, open a public room URL (e.g. https://staging.new.expensify.com/r/<reportID>) as a guest, go to Home, and verify the "Recently added" section is not shown.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-06-23.at.15.03.42.mov

The Recently added section called getAmount without the expense-report flag, so amounts were always returned as absolute values. Expense-report transactions store an inverted sign, so credits/refunds lost their negative sign. Resolve the parent report type from the snapshot and pass the expense-report flag, mirroring the Search transaction list.

The Home "Recently added" rows rendered the raw merchant, leaking the PARTIAL_TRANSACTION_MERCHANT "(none)" and DEFAULT_MERCHANT "Expense" placeholder sentinels. Extract the existing merchant-display logic from TransactionItemRow into a shared TransactionUtils.getMerchantName helper that normalizes both sentinels to an empty string, and reuse it in the Recently added data hook so empty merchants render blank.

melvin-bot · 2026-06-23T13:06:14Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2026-06-23T13:09:05Z

@adamgrzybowski
Should we also cover a bug with dates?
Looks easy 😁

Match the Spend table by appending the year to past-year dates and widening the shared date column when any visible expense needs it.

adamgrzybowski · 2026-06-23T13:28:48Z

@dannymcclain, could you please confirm that this way of displaying the year in the recently added section looks good? I copied it from the spend page

dannymcclain · 2026-06-23T13:36:53Z

Yup I think that makes sense to copy it from Spend!

ZhenjaHorbach · 2026-06-23T14:08:00Z

Looks like the fix with the amount doesn't work for selfDM

2026-06-23.16.07.33.mov

ZhenjaHorbach · 2026-06-23T14:09:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2026-06-23.16.19.25.mov

Android: mWeb Chrome

2026-06-23.16.16.59.mov

iOS: HybridApp

2026-06-23.16.19.25.mov

iOS: mWeb Safari

2026-06-23.16.16.59.mov

MacOS: Chrome / Safari

2026-06-23.16.03.55.mov

2026-06-23.16.06.42.mov

2026-06-23.16.13.40.mov

Self-DM and unreported (tracked) expenses support signed amounts like expense reports, but getAmount was called without the tracked-expense flag for them, so their amounts were collapsed to absolute values and credits/refunds lost their negative sign. Detect self-DM (via chatType) and unreported transactions and pass the tracked-expense flag so the sign is preserved. Add unit coverage for the amount sign across self-DM, unreported, expense-report, and IOU transactions.

adamgrzybowski · 2026-06-23T14:37:44Z

@ZhenjaHorbach nagative amount on personal expenses should be fixed now

ZhenjaHorbach · 2026-06-23T14:53:22Z

Okay
Now is good!

ZhenjaHorbach · 2026-06-25T15:38:28Z

@grgia
Let's merge this!

adamgrzybowski · 2026-06-29T09:58:54Z

@grgia Let's merge this today to prevent merge conflicts

github-actions · 2026-06-29T10:03:58Z

🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-06-29T10:04:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-29T10:10:29Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94308.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-35d22a65f8d-8805d82-72c03ceb51bc4edd9d8fa4ae6560ab833d526816/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-35d22a6-8805d82-c345b363cdb944d31f1b231168bcaa4bdb19bd45/index.html

Web 🕸️
https://94308.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-29T12:47:30Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.4.22-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2026-06-29T19:37:12Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.4.24-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2026-06-30T11:50:05Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.4.24-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

Bundle Size Analysis (Sentry):

Android

OSBotify · 2026-06-30T12:33:03Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.4.24-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

adamgrzybowski added 2 commits June 23, 2026 14:17

adamgrzybowski requested review from a team as code owners June 23, 2026 13:06

melvin-bot Bot assigned adamgrzybowski Jun 23, 2026

melvin-bot Bot requested review from ZhenjaHorbach and heyjennahay and removed request for a team June 23, 2026 13:06

Show year on past-year dates in Recently added section

50d16ca

Match the Spend table by appending the year to past-year dates and widening the shared date column when any visible expense needs it.

Hide Recently added section for anonymous guests

7ff35db

ZhenjaHorbach approved these changes Jun 23, 2026

View reviewed changes

melvin-bot Bot requested a review from grgia June 23, 2026 14:53

grgia approved these changes Jun 25, 2026

View reviewed changes

grgia mentioned this pull request Jun 26, 2026

fix: Home - Action button disappears the second time an expense is opened from "Recently Added" #94466

Merged

41 tasks

Merge branch 'main' into @adamgrzybowski/fix-recently-added-bugs

f78b07b

grgia merged commit 35d22a6 into Expensify:main Jun 29, 2026
32 checks passed

OSBotify mentioned this pull request Jun 29, 2026

Deploy Checklist: New Expensify 2026-06-29 #94832

Closed

36 tasks

melvin-bot Bot mentioned this pull request Jun 30, 2026

[Due for payment 2026-07-07] Home - Merchant row shows (none)/Expense when merchant is empty #94249

Closed

7 tasks

Uh oh!

Conversation

adamgrzybowski commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 23, 2026

Uh oh!

ZhenjaHorbach commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adamgrzybowski commented Jun 23, 2026

Uh oh!

dannymcclain commented Jun 23, 2026

Uh oh!

ZhenjaHorbach commented Jun 23, 2026

Uh oh!

ZhenjaHorbach commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

adamgrzybowski commented Jun 23, 2026

Uh oh!

ZhenjaHorbach commented Jun 23, 2026

Uh oh!

ZhenjaHorbach commented Jun 25, 2026

Uh oh!

adamgrzybowski commented Jun 29, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

OSBotify commented Jun 29, 2026

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

OSBotify commented Jun 29, 2026

Uh oh!

OSBotify commented Jun 29, 2026

Uh oh!

OSBotify commented Jun 30, 2026

Uh oh!

OSBotify commented Jun 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

adamgrzybowski commented Jun 23, 2026 •

edited

Loading

ZhenjaHorbach commented Jun 23, 2026 •

edited

Loading

ZhenjaHorbach commented Jun 23, 2026 •

edited

Loading