Fix mileage rate auto-updated tooltip regressions from #93103#93553
Conversation
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f60fc8a899
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Sorry for the ping again @DylanDylann 🥲, @thelullabyy will review this. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari3.mov2.mov1.mov |
|
@heyjennahay Could you please assign me this issue for easier tracking in K2? Thanks |
|
I faced a really weird behavior, the date selector looks outdated in track distance flow. And the tooltip never shows @Krishna2323 Screen.Recording.2026-06-15.at.07.05.32.mov |
|
Monosnap.screencast.2026-06-15.20-46-05.mp4 |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@thelullabyy please check again, I have fixed the inline date picker also. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0319b3dfde
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…ot policy hydration Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
Bug: In inline date picker UI, rate auto-updated works but no tooltip showing Screen.Recording.2026-06-15.at.15.52.50.mov |
Have you cleared the cache from the Troubleshoot page? |
|
Alright, it works well after I reset the cache @Krishna2323 Maybe you should add this to test steps |
|
🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.4.9-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Help site review: no docs changes required. I reviewed the changes in this PR and confirmed that no updates to the help site files under Why: This PR fixes three regressions in the internal display logic of the "mileage rate auto-updated" educational tooltip (from #93103). It does not introduce or change any documented, user-facing behavior:
The underlying distance-rate feature is documented in Set Distance Rates and Distance Expenses, but neither article documents the educational tooltip or date-based rate auto-selection — and this PR doesn't change that. The fixes are scoped to tooltip visibility timing, which is transient UI guidance, not behavior that belongs in the help site. No draft PR was created since there is nothing to update. |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.9-0 🚀
|
Explanation of Change
Fixed Issues
$ #93513
$ #93514
$ #93515
PROPOSAL:
Tests
Test #93513
Test #93514
Test #93515
Offline tests
QA Steps
Same as tests
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Monosnap.screencast.2026-06-15.06-21-07.mp4