feat: update confirmation and rate selection UX for date-aware mileage rates#93103
Conversation
…e rates Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@cristipaval sorry for the bump. @thelullabyy is the reviewer. |
a946b73 to
97a9581
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a946b7338a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…lection-ux Signed-off-by: krishna2323 <belivethatkg@gmail.com>
rlinoz
left a comment
There was a problem hiding this comment.
When we try to submit a tracked expense to a workspace we are not displaying the tooltip
Screen.Recording.2026-06-12.at.09.59.45.mov
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@rlinoz I'm not able to reproduce this. Could you please check again? Monosnap.screencast.2026-06-12.19-41-57.mp4 |
|
Hmmm not happening anymore 🤷 |
|
@Krishna2323 typecheck is failing though |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.4.7-0 🚀
Bundle Size Analysis (Sentry): |
|
Deploy Blocker #93513 was identified to be related to this PR. |
|
Deploy Blocker #93512 was identified to be related to this PR. |
|
Deploy Blocker #93514 was identified to be related to this PR. |
|
Deploy Blocker #93515 was identified to be related to this PR. |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.7-4 🚀
|
…leage-rate-tooltip Fix mileage rate auto-updated tooltip regressions from #93103
Explanation of Change
Continuation of #92878 (accidentally closed by force push). See #92878 for full review history.
Fixed Issues
$ #89835
PROPOSAL:
Tests
Prerequisites: Create a workspace with multiple distance rates that have date bounds. For example:
Test 1: Rate picker shows date labels
$0.70/mi • Valid Jan 1, 2026 - Dec 31, 2026)Test 2: Date-aware auto-fill on confirmation page
Test 3: Tooltip shows when rate auto-updates due to date change
Test 4: Tooltip does NOT show when rate stays the same
Test 5: Tooltip hides on navigation
Test 6: P2P distance request is unaffected
Test 7: Track expense (Self DM)
Offline tests
QA Steps
Same as tests
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android_hybrid.mp4
Android: mWeb Chrome
android_mWeb.mp4
iOS: Native
ios_hybrid.mp4
iOS: mWeb Safari
ios_mWeb.mp4
MacOS: Chrome / Safari
Monosnap.screencast.2026-06-08.01-36-45.mp4