Skip to content

feat: update confirmation and rate selection UX for date-aware mileage rates#93103

Merged
rlinoz merged 24 commits into
Expensify:mainfrom
Krishna2323:krishna/89835-confirmation-rate-selection-ux
Jun 12, 2026
Merged

feat: update confirmation and rate selection UX for date-aware mileage rates#93103
rlinoz merged 24 commits into
Expensify:mainfrom
Krishna2323:krishna/89835-confirmation-rate-selection-ux

Conversation

@Krishna2323

@Krishna2323 Krishna2323 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Continuation of #92878 (accidentally closed by force push). See #92878 for full review history.

Fixed Issues

$ #89835
PROPOSAL:

Tests

Prerequisites: Create a workspace with multiple distance rates that have date bounds. For example:

  • Rate A: $0.67/mi, valid Jan 1 2025 - Dec 31 2025
  • Rate B: $0.70/mi, valid Jan 1 2026 - Dec 31 2026
  • Rate C: $0.55/mi, no date bounds (default)

Test 1: Rate picker shows date labels

  1. Start a new distance request on the workspace
  2. On the confirmation page, tap the Rate field
  3. Verify: Each rate in the picker shows its date range below the rate value (e.g., $0.70/mi • Valid Jan 1, 2026 - Dec 31, 2026)
  4. Verify: Rates with only a start date show "Valid from ..."
  5. Verify: Rates with only an end date show "Valid until ..."
  6. Verify: Rates with no dates show no date label

Test 2: Date-aware auto-fill on confirmation page

  1. Set your last selected rate to Rate A (2025 rate) by creating and submitting a distance expense with it
  2. Start a new distance request with today's date (2026)
  3. Verify: Rate B (2026 rate) is auto-selected, NOT Rate A, because Rate A is ineligible for 2026

Test 3: Tooltip shows when rate auto-updates due to date change

  1. Start a new distance request on the workspace (today's date auto-selects Rate B for 2026)
  2. On the confirmation page, note the selected rate
  3. Go to the Date field and change the date to a 2025 date (e.g., June 15, 2025)
  4. Return to the confirmation page
  5. Verify: The rate field now shows Rate A (2025 rate)
  6. Verify: An educational tooltip appears on the rate field saying "We updated the rate based on your travel date."

Test 4: Tooltip does NOT show when rate stays the same

  1. Start a new distance request on the workspace
  2. Change the date to another date that is still within the same rate's date range
  3. Return to the confirmation page
  4. Verify: No tooltip appears (rate didn't change)

Test 5: Tooltip hides on navigation

  1. Trigger the tooltip (Test 3 steps)
  2. Tap the Rate field to navigate to the rate picker
  3. Verify: The tooltip hides when you navigate

Test 6: P2P distance request is unaffected

  1. Start a P2P distance request (send money to a friend)
  2. Change the date
  3. Verify: No tooltip appears, no rate auto-update occurs (P2P uses a fixed rate)

Test 7: Track expense (Self DM)

  1. Start a Track Expense distance request (participant is Self DM with a default workspace)
  2. Verify the rate is auto-selected based on the date
  3. Change the date to cross a rate boundary
  4. Verify: The rate updates and the tooltip shows
  • Verify that no errors appear in the JS console

Offline tests

  • Same as tests

QA Steps

  • Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android_hybrid.mp4
Android: mWeb Chrome
android_mWeb.mp4
iOS: Native
ios_hybrid.mp4
iOS: mWeb Safari
ios_mWeb.mp4
MacOS: Chrome / Safari
Monosnap.screencast.2026-06-08.01-36-45.mp4
Monosnap Spend 2026-06-08 13-44-02 Monosnap Spend 2026-06-08 13-43-39

…e rates

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323 Krishna2323 requested review from a team as code owners June 9, 2026 18:21
@melvin-bot

melvin-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@melvin-bot melvin-bot Bot requested review from JmillsExpensify and cristipaval and removed request for a team June 9, 2026 18:21
@melvin-bot

melvin-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@Krishna2323

Copy link
Copy Markdown
Contributor Author

@cristipaval sorry for the bump. @thelullabyy is the reviewer.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a946b7338a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/components/MoneyRequestConfirmationList.tsx Outdated
…lection-ux

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

@rlinoz rlinoz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we try to submit a tracked expense to a workspace we are not displaying the tooltip

Screen.Recording.2026-06-12.at.09.59.45.mov

Comment thread src/components/ProductTrainingContext/TOOLTIPS.ts
Comment thread src/pages/iou/request/step/IOURequestStepDistanceRate.tsx Outdated
@neil-marcellini neil-marcellini removed their request for review June 12, 2026 13:17
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323

Krishna2323 commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

When we try to submit a tracked expense to a workspace we are not displaying the tooltip

@rlinoz I'm not able to reproduce this. Could you please check again?

Monosnap.screencast.2026-06-12.19-41-57.mp4

@rlinoz

rlinoz commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Hmmm not happening anymore 🤷

@rlinoz

rlinoz commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@Krishna2323 typecheck is failing though

@rlinoz rlinoz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rlinoz rlinoz merged commit 91b6a3f into Expensify:main Jun 12, 2026
33 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.4.7-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #93513 was identified to be related to this PR.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #93512 was identified to be related to this PR.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #93514 was identified to be related to this PR.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #93515 was identified to be related to this PR.

Krishna2323 added a commit to Krishna2323/App that referenced this pull request Jun 15, 2026
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.7-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

rlinoz added a commit that referenced this pull request Jun 16, 2026
…leage-rate-tooltip

Fix mileage rate auto-updated tooltip regressions from #93103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants