Skip to content

fix: Restrict sticky group headers to explicit groupBy queries only #93507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuwenmemon merged 1 commit into from
Jun 13, 2026
Merged

fix: Restrict sticky group headers to explicit groupBy queries only #93507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/components/Search/SearchList/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,6 @@ function SearchList({
const hasItemsBeingRemoved = prevDataLength && prevDataLength > data.length;
const {isEditingCell, wasRecentlyEditingCell} = useEditingCellState();

const isGroupByActive = !!groupBy || type === CONST.SEARCH.DATA_TYPES.EXPENSE_REPORT;
const [expandedGroups, setExpandedGroups] = useState<Set<string>>(() => new Set());

const onToggleGroup = useCallback((key: string) => {
Expand All @@ -313,7 +312,7 @@ function SearchList({
});
}, []);

const shouldSplitGroups = isGroupByActive && isLargeScreenWidth;
const shouldSplitGroups = !!groupBy && isLargeScreenWidth;
Comment thread
Krishna2323 marked this conversation as resolved.

const {splitData: listData, stickyHeaderIndices} = useMemo(() => {
if (!shouldSplitGroups) {
Expand Down
Loading