Skip to content

[Home Page] Add Recently added slot to Home#93451

Merged
grgia merged 37 commits into
Expensify:mainfrom
software-mansion-labs:@adamgrzybowski/add-recently-added-slot
Jun 19, 2026
Merged

[Home Page] Add Recently added slot to Home#93451
grgia merged 37 commits into
Expensify:mainfrom
software-mansion-labs:@adamgrzybowski/add-recently-added-slot

Conversation

@adamgrzybowski

@adamgrzybowski adamgrzybowski commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

  • Adds a new "Recently added" slot to Home that surfaces the signed-in user's most recently added expenses, sorted by the inserted timestamp (when the expense was added to the system), most recent first and independent of the expense date, and capped at five rows. Each row shows the receipt thumbnail, expense date, merchant, and amount.
  • The slot always appears: when the user has no expenses it shows an empty state.
  • Each row opens that specific expense in the RHP on Home: on narrow layouts it opens the report, and on wide layouts it opens the expense in the Wide RHP, opening optimistically so it expands to wide immediately instead of flickering from narrow to wide.
  • Relocates the "Discover" slot from the left column to the right column to keep the two-column layout balanced now that "Recently added" anchors the lower-left.

Fixed Issues

$ #92658
PROPOSAL:

Tests

Offline tests

QA Steps

  1. Open Home with an account that has expenses and verify the "Recently added" slot lists up to five expenses sorted by when they were added (an expense added today but dated months ago appears at the top), each showing receipt thumbnail, date, merchant, and amount.
  2. On a wide screen, tap an expense row and verify it opens directly in the Wide RHP without flickering from a narrow panel; on a narrow screen, verify the row opens the expense report.
  3. With an account that has no expenses, verify the empty state is shown, and use the overflow menu to verify "View all expenses" navigates to the expenses list.
  4. On a wide screen, verify the "Discover" slot now appears in the right column.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-06-16.at.14.23.20.mov

@melvin-bot

melvin-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here.

@JmillsExpensify

Copy link
Copy Markdown
Contributor

Triggered an adhoc, will test when it's ready.

@github-actions

This comment has been minimized.

@shawnborton

Copy link
Copy Markdown
Contributor

Hmm this is what I am seeing:
CleanShot 2026-06-12 at 21 15 56@2x

I have plenty of expenses in my account.

But regardless, the empty state does not look correct. From Figma:
image

@JmillsExpensify

Copy link
Copy Markdown
Contributor

It works for me, though the most recent expenses don't seem to be right.

@JmillsExpensify

Copy link
Copy Markdown
Contributor

It's showing my most recent expense as april 12, though on the Spend page my most recent expense is June 12

@JmillsExpensify

Copy link
Copy Markdown
Contributor

I'll share my details in Slack. Also for the empty state, we ended up changing the wording. The sub-text should be "Create one or drag a receipt here."

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

These receipts look square and I believe the should have the same aspect ratio as it has on the spend page:
CleanShot 2026-06-15 at 11 32 42@2x

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

The row is also 64px high and I believe it should be 56px, but I'm assuming we want padding set and maybe not a fixed height?
CleanShot 2026-06-15 at 11 34 12@2x

The > icon on the right should be 20x20 as well and not 16x16.

I'll let Shawn comment on the rest since he's the OG designer on it 👍

@shawnborton

Copy link
Copy Markdown
Contributor

Totally agree with those points Jon. Ideally we would share styles between the two if possible so we don't need to manage the same exact thing in multiple places.

@OSBotify

This comment has been minimized.

TDD red phase: cover the recent-expenses data hook selection (sort by
inserted, current-user scope, 5-row cap, status agnostic), the section's
empty state, rows, RHP navigation and overflow menu, and the updated Home
slot ordering with Discover relocation. Implementation follows.
@adamgrzybowski
adamgrzybowski force-pushed the @adamgrzybowski/add-recently-added-slot branch from a1f0f5a to 815f807 Compare June 15, 2026 12:42
@grgia

grgia commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@adamgrzybowski ping when youre ready for a build!

@grgia
grgia self-requested a review June 15, 2026 15:29
@adamgrzybowski

Copy link
Copy Markdown
Contributor Author

@grgia I am fixing one more thing, will let you know soon

@adamgrzybowski

Copy link
Copy Markdown
Contributor Author

@grgia @JmillsExpensify Should work now. You can retest it.

I will clean the code from any leftovers tomorrow, so I would skip the code review for now

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/grgia in version: 9.4.17-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 I reviewed this PR for help site impact. Yes, a docs update is needed.

This PR adds a new Recently added slot to Home, but the Expensify Home Overview article — which documents every Home section — didn't mention it.

Draft help site PR: #94230

It updates Expensify-Home-Overview.md to:

  • List Recently added under What Home shows
  • Add a How the Recently added section works on Home section (five-row limit, sort by when the expense was added rather than expense date, row contents, opening an expense, the three dots (⋮)View all expenses action, and the empty state)
  • Add two FAQ entries and refresh the metadata

The Discover relocation to the right column is a layout change with no documented column positions in the article, so no doc change was required for it.

@adamgrzybowski, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #94237 was identified to be related to this PR.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #94240 was identified to be related to this PR.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #94247 was identified to be related to this PR.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #94249 was identified to be related to this PR.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #94250 was identified to be related to this PR.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #94251 was identified to be related to this PR.

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #94272 was identified to be related to this PR.

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #94311 was identified to be related to this PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

1 similar comment
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.