Add Certinia company selector by ShridharGoel · Pull Request #93407 · Expensify/App

ShridharGoel · 2026-06-12T09:30:48Z

Explanation of Change

Adds PSA-aware Certinia labeling and the SRP company selector entry point.

When a Certinia connection has PSA enabled, the connected card now shows Certinia (PSA). For SRP connections, where PSA is enabled and hasPSAOnly === false, the Accounting page now shows a top-level Company row. Tapping it opens a company selector populated from synced Certinia companies and updates the selected company with the existing offline feedback pattern.

Fixed Issues

$ #89442
PROPOSAL:

Tests

Connect a workspace to Certinia with hasPSA enabled.
Verify the connected accounting card shows Certinia (PSA).
Use an SRP connection where hasPSAOnly === false.
Verify the Company row appears above Import, Export, and Advanced.
Tap the Company row and verify the synced companies list appears.
Select a different company and verify the row updates with pending feedback.

Verify that no errors appear in the JS console

Offline tests

Open the Certinia Company selector while offline.
Select a different company.
Verify the update is queued with pending feedback and syncs when the app is back online.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2026-06-16.at.2.58.23.AM.mov

melvin-bot · 2026-06-12T09:30:53Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2026-06-12T09:34:47Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...ages/workspace/accounting/PolicyAccountingPage.tsx	`0.00% <ø> (ø)`
...ccounting/certinia/CertiniaCompanySelectorPage.tsx	`0.00% <0.00%> (ø)`
src/pages/workspace/accounting/certinia/utils.ts	`0.00% <0.00%> (ø)`
... and 43 files with indirect coverage changes

melvin-bot · 2026-06-15T21:29:10Z

@ChavdaSachin @thelullabyy One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c7992594db

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

This reverts commit 2f5d049.

thelullabyy · 2026-06-17T00:29:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-06-16.at.19.38.46.mov

Screen.Recording.2026-06-17.at.18.47.07.mov

thelullabyy · 2026-06-17T00:53:59Z

        certinia: {
            title: 'Certinia',
            titleFFA: 'Certinia (FFA)',
+            titlePSA: 'Certinia (PSA)',


The card title for SRP connections (hasPSA && !hasPSAOnly) changes from Certinia (FFA) to Certinia (PSA) with this PR. Since SRP has both modules active, can you confirm (PSA) is the intended label per the design doc? @ShridharGoel

Yes, from the design doc:

Expensify treats it as a PSA connection with one extra export setting (Company ID).

thelullabyy · 2026-06-17T00:54:54Z

Looks like we missed several copies according to the design doc @ShridharGoel

thelullabyy · 2026-06-17T00:56:02Z

Also update the subscribed*Settings arrays in accounting/utils.tsx to include PSA-specific keys based on ffaConfig?.hasPSA (e.g., PARENT_TAG_MAPPING, SYNC_MILESTONES, REPORT_EXPORT_STATUS, TAX_NON_BILLABLE, EXPORT_FOREIGN_CURRENCY) so the connection card shows the right pending/error indicators for PSA workspaces.

Looks like we missed this point as well @ShridharGoel

ShridharGoel · 2026-06-17T19:21:00Z

@thelullabyy This PR is for the company selector, hence those strings are not added here. They will be present in the PRs that use them.

thelullabyy · 2026-06-17T23:45:21Z

@ShridharGoel Conflicts

thelullabyy

LGTM

# Conflicts: # src/languages/de.ts # src/languages/en.ts # src/languages/es.ts # src/languages/fr.ts # src/languages/it.ts # src/languages/ja.ts # src/languages/nl.ts # src/languages/pl.ts # src/languages/pt-BR.ts # src/languages/zh-hans.ts # src/pages/workspace/accounting/certinia/CertiniaCompanySelectorPage.tsx # src/pages/workspace/accounting/certinia/export/CertiniaExportPage.tsx # src/pages/workspace/accounting/certinia/export/CertiniaReportExportStatusPage.tsx # src/pages/workspace/accounting/certinia/utils.ts # src/pages/workspace/accounting/utils.tsx

github-actions · 2026-06-23T00:36:06Z

🚧 @yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-23T00:41:45Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #93407.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-c7e720ed428-274b4f3-0265d5aeaccd6e59e021b752f3528ebf20637198/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-c7e720e-274b4f3-c01ddbb59099447dca2665cd20f794af1d739276/index.html

Web 🕸️
https://93407.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

kavimuru · 2026-06-23T22:15:47Z

@ShridharGoel @yuwenmemon
Can you please help with the following?

Connect a workspace to Certinia with hasPSA enabled.
Verify the connected accounting card shows Certinia (PSA).
Use an SRP connection where hasPSAOnly === false.

OSBotify · 2026-06-23T22:19:29Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.4.18-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

jponikarchuk · 2026-06-24T04:50:43Z

The Deploy Blocker issue #94401 is repro on all PRs. Could you please double check if it's not introduced by #93451

mitarachim · 2026-06-24T06:03:08Z

The Deploy Blocker issue #94410 is repro on all PRs. Could you please double check if it's not introduced by #93451

jponikarchuk · 2026-06-24T14:25:40Z

The Deploy Blocker issue #94468 is repro on all PRs. Could you please double check if it's not introduced by #93185

jponikarchuk · 2026-06-24T14:38:16Z

The Deploy Blocker issue #94473 is repro on all PRs. Could you please double check if it's not introduced by #93185

OSBotify · 2026-06-24T19:15:41Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.18-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot Bot assigned ShridharGoel Jun 12, 2026

ShridharGoel marked this pull request as ready for review June 15, 2026 21:29

ShridharGoel requested review from a team as code owners June 15, 2026 21:29

melvin-bot Bot requested review from ChavdaSachin, JmillsExpensify and thelullabyy June 15, 2026 21:29

melvin-bot Bot removed request for a team and JmillsExpensify June 15, 2026 21:29

ShridharGoel changed the title ~~Add Certinia PSA company selector~~ Add Certinia company selector Jun 15, 2026

chatgpt-codex-connector Bot reviewed Jun 15, 2026

View reviewed changes

Comment thread src/pages/workspace/accounting/certinia/CertiniaCompanySelectorPage.tsx

ShridharGoel added 2 commits June 16, 2026 03:15

Revert "Add Certinia PSA export settings"

ed873a7

This reverts commit 2f5d049.

Block Certinia company selector for non-SRP

5a7ca25

thelullabyy reviewed Jun 17, 2026

View reviewed changes

Comment thread src/pages/workspace/accounting/certinia/CertiniaCompanySelectorPage.tsx Outdated

thelullabyy reviewed Jun 17, 2026

View reviewed changes

trjExpensify removed the request for review from ChavdaSachin June 17, 2026 11:58

ShridharGoel added 2 commits June 18, 2026 00:52

Reuse Certinia SRP connection helper

dc63b85

Inline Certinia SRP selector check

352d2dc

thelullabyy approved these changes Jun 17, 2026

View reviewed changes

melvin-bot Bot requested a review from yuwenmemon June 17, 2026 23:48

Merge branch 'main' into cert2

83aaaaf

ShridharGoel added 3 commits June 18, 2026 18:08

Merge remote-tracking branch 'origin/cert2' into cert2

02f42cf

Fix Certinia utility import paths

c78fbca

thelullabyy approved these changes Jun 18, 2026

View reviewed changes

yuwenmemon approved these changes Jun 23, 2026

View reviewed changes

yuwenmemon merged commit c7e720e into Expensify:main Jun 23, 2026
33 of 35 checks passed

github-actions Bot mentioned this pull request Jun 23, 2026

Investigate workflow job failing on main: test / test (job 2) #94242

Closed

OSBotify mentioned this pull request Jun 23, 2026

Deploy Checklist: New Expensify 2026-06-23 #94371

Closed

48 tasks

melvin-bot Bot mentioned this pull request Jun 24, 2026

[Certinia] R2 PSA: SRP CertiniaCompanySelectorPage and PSA translations #89442

Closed

This was referenced Jul 14, 2026

[$2000] Payment for Certinia Integration project - @ShridharGoel #96019

Closed

[$2000] Payment for Certinia Integration project - @thelullabyy #96020

Open

Uh oh!

Conversation

ShridharGoel commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 12, 2026

Uh oh!

codecov Bot commented Jun 12, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jun 15, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

thelullabyy commented Jun 17, 2026 • edited by yuwenmemon Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

thelullabyy Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

ShridharGoel Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

thelullabyy commented Jun 17, 2026

Uh oh!

thelullabyy commented Jun 17, 2026

Uh oh!

ShridharGoel commented Jun 17, 2026

Uh oh!

thelullabyy commented Jun 17, 2026

Uh oh!

thelullabyy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 23, 2026

Uh oh!

github-actions Bot commented Jun 23, 2026

Uh oh!

kavimuru commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Jun 23, 2026

Uh oh!

jponikarchuk commented Jun 24, 2026

Uh oh!

mitarachim commented Jun 24, 2026

Uh oh!

jponikarchuk commented Jun 24, 2026

Uh oh!

jponikarchuk commented Jun 24, 2026

Uh oh!

OSBotify commented Jun 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ShridharGoel commented Jun 12, 2026 •

edited

Loading

codecov Bot commented Jun 12, 2026 •

edited by github-actions Bot

Loading

thelullabyy commented Jun 17, 2026 •

edited by yuwenmemon

Loading

kavimuru commented Jun 23, 2026 •

edited

Loading