Skip to content

[Payment due @ShridharGoel] Fix unsafe type assertions flagged by the seatbelt bump [No QA]#93105

Merged
yuwenmemon merged 5 commits into
mainfrom
yuwen-fix-eslint-seatbelt-violations
Jun 10, 2026
Merged

[Payment due @ShridharGoel] Fix unsafe type assertions flagged by the seatbelt bump [No QA]#93105
yuwenmemon merged 5 commits into
mainfrom
yuwen-fix-eslint-seatbelt-violations

Conversation

@yuwenmemon

@yuwenmemon yuwenmemon commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

A recent seatbelt bump grandfathered new @typescript-eslint/no-unsafe-type-assertion violations on main instead of fixing them. This is the follow-up that actually fixes the cleanly-fixable ones and tightens the seatbelt baseline back down so the count can't silently creep up again.

What got tightened:

  • src/components/MoneyRequestConfirmationList/sections/selectors.ts: 7 → 3. The footer slice selectors declared a full OnyxEntry<Transaction> return type but only build a narrow slice, so they cast with as Transaction. Four now return their real slice type (no cast) — getTagForDisplay/getTag and getTagVisibility were narrowed to the tag field they actually read, and isScanRequest/getCurrency/isManagedCardTransaction now accept just the fields they read. The remaining 3 (distanceMap, perDiem, receipt) feed into a web of shared receipt/waypoint/per-diem utils, so type-safely narrowing them is a larger refactor left out of scope here.
  • src/libs/Navigation/Navigation.ts: 11 → 10. originalTabRoute.state is already typed as the navigation-state union, so the as NavigationState narrowing was unnecessary and is removed.
  • src/libs/SearchUIUtils.ts: 71 → 69. getPolicyCategoriesForPolicyID used two casts to discriminate the PolicyCategoriesLookup union; a small type guard does it without assertions.
  • tests/unit/Search/SearchUIUtilsTest.ts: 135 → 133. The two new getSortedSections(...) as TransactionListItemType[] casts are replaced with an in check when reading transactionID.

No runtime behavior changes — this is type-level and lint cleanup.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/625136

Tests

  1. Run npm run typecheck and verify it passes.
  2. Run npm run lint and verify there are no new ESLint errors (the seatbelt counts for the four files above are lower, not higher).
  3. Run npx jest tests/unit/Search/SearchUIUtilsTest.ts and verify the SearchUIUtils tests pass, including "should sort expense data by category GL code using policy categories".
  • Verify that no errors appear in the JS console

Offline tests

N/A — type-level and lint-only change with no runtime behavior change.

QA Steps

// [No QA]

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A — type-level and lint-only change.

Android: mWeb Chrome

N/A — type-level and lint-only change.

iOS: Native

N/A — type-level and lint-only change.

iOS: mWeb Safari

N/A — type-level and lint-only change.

MacOS: Chrome / Safari

N/A — type-level and lint-only change.

@yuwenmemon
yuwenmemon requested review from a team as code owners June 9, 2026 18:42
@melvin-bot

melvin-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed request for a team June 9, 2026 18:42
@codecov

codecov Bot commented Jun 9, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...stConfirmationList/sections/InvoiceSenderField.tsx 92.00% <ø> (ø)
src/libs/TagsOptionsListUtils.ts 56.45% <ø> (ø)
src/libs/TransactionUtils/index.ts 87.71% <100.00%> (ø)
...MoneyRequestConfirmationList/sections/selectors.ts 82.65% <85.71%> (ø)
src/libs/Navigation/Navigation.ts 43.85% <0.00%> (ø)
src/libs/SearchUIUtils.ts 64.38% <83.33%> (+0.05%) ⬆️
... and 11 files with indirect coverage changes

@ShridharGoel

ShridharGoel commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

ShridharGoel
ShridharGoel reviewed Jun 9, 2026
View reviewed changes
Comment thread config/eslint/eslint.seatbelt.tsv
"../../src/libs/SearchAutocompleteUtils.ts" "@typescript-eslint/no-unsafe-type-assertion" 4
"../../src/libs/SearchQueryUtils.ts" "@typescript-eslint/no-unsafe-type-assertion" 73
"../../src/libs/SearchUIUtils.ts" "@typescript-eslint/no-unsafe-type-assertion" 71
"../../src/libs/SearchUIUtils.ts" "@typescript-eslint/no-deprecated/getSearchReportName" 1

@ShridharGoel ShridharGoel Jun 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this new entry?

@yuwenmemon yuwenmemon Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes — this entry came in via the merge commit that brought our branch up to date with main. A recently merged PR (f1c9bc6c12a) introduced a call to the (deprecated) getSearchReportName function in SearchUIUtils.ts, so the seatbelt needs to track it. This PR isn't the right place to fix a no-deprecated violation — but removing the entry would cause the lint check to fail since the actual call is still there.

@yuwenmemon yuwenmemon mentioned this pull request Jun 9, 2026
Merged
7 tasks
@yuwenmemon

yuwenmemon commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

@ShridharGoel we had to merge main to resolve conflicts. Can you give a quick second pass?

@ShridharGoel

ShridharGoel commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Yes, my initial review was after merging main. So we should be good here but I'll have a quick look again.

@melvin-bot
melvin-bot Bot requested a review from lakchote June 9, 2026 22:04
@melvin-bot

melvin-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

@lakchote Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot changed the title Fix unsafe type assertions flagged by the seatbelt bump [No QA] [Payment due @ShridharGoel] Fix unsafe type assertions flagged by the seatbelt bump [No QA] Jun 9, 2026
@melvin-bot

melvin-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

🎯 @ShridharGoel, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/625136.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

@yuwenmemon
yuwenmemon merged commit f4d6777 into main Jun 10, 2026
40 of 41 checks passed
@yuwenmemon
yuwenmemon deleted the yuwen-fix-eslint-seatbelt-violations branch June 10, 2026 02:51
@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

🚧 @yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #93105.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-f4d6777d7d8-a45e4eb-bd1f7fe209deeb27b697df83101909c5971321b5/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-f4d6777-a45e4eb-2dda0bca290d73a8b9870b578dce1b5216fc7f48/index.html
Android iOS
Web 🕸️
https://93105.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify OSBotify mentioned this pull request Jun 10, 2026
Closed
72 tasks
@OSBotify

OSBotify commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.4.5-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

MelvinBot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Help site review: no changes required

I reviewed the changes in this PR against Expensify's help site files under App/docs/articles, and no documentation updates are required.

Why: This PR is a type-level and lint-only cleanup with no runtime or user-facing behavior changes. Specifically, it:

  • Narrows TypeScript parameter/return types and removes unnecessary as type assertions in selectors.ts, InvoiceSenderField.tsx, Navigation.ts, TagsOptionsListUtils.ts, and TransactionUtils/index.ts.
  • Replaces two casts with a small type guard (isPolicyCategoriesCollection) in SearchUIUtils.ts.
  • Swaps casts for an in check in SearchUIUtilsTest.ts.
  • Tightens the ESLint seatbelt baseline (eslint.seatbelt.tsv) so violation counts can't silently creep back up.

None of these touch UI copy, feature names, tab/setting labels, buttons, or any documented behavior. The PR description itself confirms: "No runtime behavior changes — this is type-level and lint cleanup."

Since no help site changes are needed, I did not create a draft docs PR.

@yuwenmemon, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

(Note: no help site PR was created because this PR introduces no user-facing or documented behavior changes.)

@melvin-bot melvin-bot Bot mentioned this pull request Jun 11, 2026
Closed
@melvin-bot

melvin-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown

🤖 Payment issue created: #93345

@OSBotify

OSBotify commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.5-6 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasperhuangg jasperhuangg jasperhuangg approved these changes
@flaviadefaria flaviadefaria Awaiting requested review from flaviadefaria
@lakchote lakchote Awaiting requested review from lakchote
+1 more reviewer
@ShridharGoel ShridharGoel ShridharGoel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@yuwenmemon yuwenmemon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yuwenmemon @ShridharGoel @OSBotify @MelvinBot @jasperhuangg