[Payment due @Krishna2323] Remove TriNet beta gate

[yuwenmemon]

@Krishna2323 please review

Explanation of Change

Removes the zenefitsNewDot beta gate from the TriNet HR integration. The TriNet provider card in the Workspace HR page and the Approval Mode / Final Approver sub-pages are now visible to all Control workspace users without needing the beta.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/625136
PROPOSAL:

Tests

1. Open a Control workspace → More Features → enable HR
2. Navigate to Workspace HR page and verify TriNet (Zenefits) card is visible without any beta flag
3. Connect TriNet, configure approval mode and final approver
4. Verify approval mode and final approver pages open and save correctly

• Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

1. Open a Control workspace → More Features → enable HR
2. Verify the TriNet card appears on the Workspace HR page
3. Tap the TriNet card and verify connection/configuration flow works

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
• I correctly labeled the issue with a bug or enhancement label
• I added the Testing Done label once I have tested my changes
• I verified my changes do not break existing tests
• I verified my changes pass the lint and type checks

[melvin-bot]

@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 496538af80

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Update HR card tests after un-gating TriNet

With beta now unset, getHRCards() always includes the Zenefits/TriNet card even when isBetaEnabled returns false. The existing tests/unit/HrUtilsTest.ts expectations still assert that no betas returns only Gusto and several test helpers still reference the removed CONST.BETAS.ZENEFITS, so the HR unit/typecheck coverage will fail until those tests are updated to the new un-gated behavior.

Useful? React with 👍 / 👎.

[yuwenmemon]

(Yuwen's Agent) Already addressed in the follow-up commit — removed the dead provider.beta guard from the loop, merged the two beta-gated test cases into one, and updated the routes/icons tests to use noBetasEnabled instead of CONST.BETAS.ZENEFITS.

[thelullabyy]

@yuwenmemon I should ignore the assignment on this issue right?

[Krishna2323]

Why do we have changed in this file? Other than this, everything looks good to me!

[yuwenmemon]

It was either this or actually fix the es-lint errors. I can make sure we fix them in the follow up.

[yuwenmemon]

Follow up: #93105

[Krishna2323]

LGTM!

[melvin-bot]

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

🎯 @Krishna2323, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/625136.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

[jasperhuangg]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

[github-actions]

🚧 @yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #93011.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-d3030a54fe1-0d7c1d1-2d2c09d9eb7a48f6980a3e0985c8cfb3466886be/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-d3030a5-0d7c1d1-39597aa61f24c213ed59da69a01b3bcbb36b81a9/index.html

Web 🕸️
https://93011.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.4.2-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android
• iOS

[MelvinBot]

🤖 Help site review: no changes required

This PR only removes the zenefitsNewDot beta gate from the TriNet (Zenefits) HR integration, making the existing TriNet provider card and its Approval mode / Final approver sub-pages visible to all Control workspace admins. It changes no UI labels, tab names, button labels, or user flows — only feature availability (beta → GA).

The help site already documents TriNet as a generally-available feature with no beta references, so all current articles already reflect the post-PR behavior:

• new-expensify/connections/TriNet.md — full connect/configure/sync/disconnect flow, scoped to "Workspace Admin on a workspace with the Control plan" with no beta gate mentioned.
• new-expensify/workspaces/Add-Approvals.md — already references TriNet alongside Gusto as an HR integration.
• new-expensify/billing-and-subscriptions/Plan-types-and-pricing.md — already lists TriNet under Control-plan "HR & payroll sync".

Because the documentation already matches the new behavior, no draft docs PR was created.

@yuwenmemon, please confirm this assessment is correct — that removing the beta gate introduces no user-facing UI/flow changes beyond making the already-documented TriNet integration visible to all Control workspaces. If you believe a docs update is still warranted (e.g., the article should be unlisted/re-listed, or availability wording should change), reply with the specifics and I'll create the draft PR.

[OSBotify]

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.4.4-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

Bundle Size Analysis (Sentry):

• Android
• iOS

[MelvinBot]

Help site review — no changes required

I reviewed the changes in this PR against the help site files under App/docs/articles and no documentation updates are required.

Why: This PR only removes the zenefitsNewDot beta gate so the TriNet (Zenefits) HR provider card and its Approval Mode / Final Approver sub-pages are visible to all Control workspace users. It does not add, rename, or change any user-facing feature, tab, label, button, or flow.

The existing article — docs/articles/new-expensify/connections/TriNet.md (live page) — already documents the integration as generally available and never referenced the beta:

• "Who can connect" already lists the real requirements: Workspace Admin, Control plan, and HR enabled under More features → Integrate.
• The connect / disconnect, Approval mode, Final approver, and Sync now flows are all documented and unchanged by this PR.

Since the doc was already written for the GA experience, removing the beta gate brings the product in line with the existing documentation rather than diverging from it — so there is nothing to update and no draft PR was opened.

---

@yuwenmemon, no help site PR was created because no changes are required. If you believe the article is missing something this PR exposes (e.g., a flow that was previously hidden), let me know and I'll draft the updates.

[OSBotify]

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.4-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅