Skip to content

Remove exportedOn from awaiting export query #93052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rlinoz merged 6 commits into from
Jun 9, 2026
Merged

Remove exportedOn from awaiting export query #93052

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f519999
remove exportedOn from awaiting export query
rlinoz Jun 9, 2026
0d69570
Merge remote-tracking branch 'origin/main' into rodrigo-fix-awaitinge…
rlinoz Jun 9, 2026
8c02b42
fix type check
rlinoz Jun 9, 2026
dcfe8dd
prettier/typecheck/submodule
rlinoz Jun 9, 2026
75a80a9
prettier/typecheck
rlinoz Jun 9, 2026
4189b7a
Merge remote-tracking branch 'origin/main' into rodrigo-fix-awaitinge…
rlinoz Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/libs/SearchUIUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -827,7 +827,6 @@ function getSuggestedSearches(
type: CONST.SEARCH.DATA_TYPES.EXPENSE_REPORT,
action: CONST.SEARCH.ACTION_FILTERS.EXPORT,
exporter: [`${accountID}`],

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve Export to-do hash matching

When the For You section has multiple export todos, it still navigates with exportedOn: never (src/pages/home/ForYouSection/index.tsx:103-106). SearchQueryProvider identifies the active suggested search by comparing similarSearchHash against getSuggestedSearches, so after this removal the sidebar Export query no longer includes the exported filter but the For You route still does. That leaves currentSearchKey undefined for the For You Export search, so it won't use live to-do data and export actions won't receive EXPORT for the optimistic removal path. Please update the For You export query at the same time or keep the suggested search filter consistent.

Useful? React with 👍 / 👎.

@rlinoz rlinoz Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That place doesn't filter by action, so I think it is a difference case.

exportedOn: CONST.SEARCH.DATE_PRESETS.NEVER,
}),
get searchQueryJSON() {
return buildSearchQueryJSON(this.searchQuery);
Expand Down
Loading