Remove exportedOn from awaiting export query by rlinoz · Pull Request #93052 · Expensify/App

rlinoz · 2026-06-09T11:46:55Z

Explanation of Change

Removes exportedOn from the Awaiting export query, as the action filter already takes care of all the necessary logic, and makes the result match the backend behavior.

Fixed Issues

$
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Connect workspace to Sage Intacct.
Disable auto-sync on Accounting > Advanced.

Create an expense.
Open the report.
Click Submit, Approve and Mark as paid.
Go to Spend > Awaiting export and verify the report shows up
Mark the report as exported
Verify the Spend > Awaiting export doesn't show up the report anymore

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Screen.Recording.2026-06-09.at.08.46.20.mov

…xport-query

melvin-bot · 2026-06-09T15:49:18Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

JS00001 · 2026-06-09T15:49:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4189b7a134

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-09T15:57:01Z

@@ -827,7 +827,6 @@ function getSuggestedSearches(
                type: CONST.SEARCH.DATA_TYPES.EXPENSE_REPORT,
                action: CONST.SEARCH.ACTION_FILTERS.EXPORT,
                exporter: [`${accountID}`],


Preserve Export to-do hash matching

When the For You section has multiple export todos, it still navigates with exportedOn: never (src/pages/home/ForYouSection/index.tsx:103-106). SearchQueryProvider identifies the active suggested search by comparing similarSearchHash against getSuggestedSearches, so after this removal the sidebar Export query no longer includes the exported filter but the For You route still does. That leaves currentSearchKey undefined for the For You Export search, so it won't use live to-do data and export actions won't receive EXPORT for the optimistic removal path. Please update the For You export query at the same time or keep the suggested search filter consistent.

Useful? React with 👍 / 👎.

That place doesn't filter by action, so I think it is a difference case.

OSBotify · 2026-06-09T16:09:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-09T16:12:48Z

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-09T16:20:53Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #93052.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b85b5347b9c-79c0e20-6eee618cad6da24774a8c7a4d862d658bfc3f054/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-b85b534-79c0e20-ffffd16bc5e6fe53301983f6b02d39b14d5b19b9/index.html

Web 🕸️
https://93052.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-10T01:02:42Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.4.2-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-10T01:04:20Z

🤖 Help site review: no documentation changes required.

This PR removes the exportedOn: CONST.SEARCH.DATE_PRESETS.NEVER filter from the Awaiting export suggested search in src/libs/SearchUIUtils.ts. As the PR explains, the action: EXPORT filter already restricts results to reports that have not yet been exported, so dropping exportedOn only aligns the frontend query with backend behavior — the user-visible set of reports in Awaiting export is unchanged.

Why no docs update is needed

The only help article that documents this feature is Accounting-Search-Shortcuts.md, which describes the shortcut as:

Awaiting export: Reports that are approved and ready to be exported to your accounting system.

This description remains accurate. The change is an internal query refinement with no impact on feature names, tab names, settings labels, buttons, or the documented behavior of the Awaiting export shortcut.

Since no documentation changes are required, no draft help site PR was created. @rlinoz, please confirm you agree this change does not affect the documented behavior of the Awaiting export shortcut.

OSBotify · 2026-06-10T19:56:05Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.4.4-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-10T19:58:06Z

🤖 No help site changes required.

This PR removes a redundant exportedOn: CONST.SEARCH.DATE_PRESETS.NEVER filter from the Awaiting export suggested search in src/libs/SearchUIUtils.ts. Since the action: EXPORT filter already scopes the query correctly, this is an internal correctness fix that makes the frontend match backend behavior — it does not add, remove, or rename any user-facing feature, tab, setting, or button.

I reviewed the only help article that documents this shortcut, Accounting Search Shortcuts, which describes Awaiting export as:

Reports that are approved and ready to be exported to your accounting system.

That description remains accurate after this change, so no edits to App/docs/articles are needed and no draft docs PR was created.

OSBotify · 2026-06-10T23:20:10Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.4-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

remove exportedOn from awaiting export query

f519999

rlinoz self-assigned this Jun 9, 2026

Merge remote-tracking branch 'origin/main' into rodrigo-fix-awaitinge…

0d69570

…xport-query

JS00001 previously approved these changes Jun 9, 2026

View reviewed changes

fix type check

8c02b42

rlinoz dismissed JS00001’s stale review via 8c02b42 June 9, 2026 11:53

rlinoz added 2 commits June 9, 2026 09:04

prettier/typecheck/submodule

dcfe8dd

prettier/typecheck

75a80a9

rlinoz changed the title ~~remove exportedOn from awaiting export query~~ Remove exportedOn from awaiting export query Jun 9, 2026

JS00001 approved these changes Jun 9, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into rodrigo-fix-awaitinge…

4189b7a

…xport-query

rlinoz marked this pull request as ready for review June 9, 2026 15:48

rlinoz requested review from a team as code owners June 9, 2026 15:48

melvin-bot Bot requested review from flaviadefaria and mollfpr and removed request for a team June 9, 2026 15:48

chatgpt-codex-connector Bot reviewed Jun 9, 2026

View reviewed changes

rlinoz merged commit b85b534 into main Jun 9, 2026
38 checks passed

rlinoz deleted the rodrigo-fix-awaitingexport-query branch June 9, 2026 16:03

OSBotify mentioned this pull request Jun 10, 2026

Deploy Checklist: New Expensify 2026-06-10 #93122

Closed

70 tasks

Uh oh!

Conversation

rlinoz commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 9, 2026

Uh oh!

JS00001 commented Jun 9, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

rlinoz Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jun 9, 2026

Uh oh!

github-actions Bot commented Jun 9, 2026

Uh oh!

github-actions Bot commented Jun 9, 2026

Uh oh!

OSBotify commented Jun 10, 2026

Uh oh!

MelvinBot commented Jun 10, 2026

Uh oh!

OSBotify commented Jun 10, 2026

Uh oh!

MelvinBot commented Jun 10, 2026

Uh oh!

OSBotify commented Jun 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rlinoz commented Jun 9, 2026 •

edited

Loading