Add description copy below Connections header on HR page#91641
Merged
Conversation
Display the approved descriptive copy beneath the Connections section header on the Workspace HR page, matching the pattern used on the Accounting page for consistency. Co-authored-by: Yuwen Memon <yuwenmemon@users.noreply.github.com>
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 1d40a596528..ad76dbd7a91 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -7197,7 +7197,7 @@ Fügen Sie weitere Ausgabelimits hinzu, um den Cashflow Ihres Unternehmens zu sc
title: 'Personalwesen',
connections: 'Verbindungen',
connectionsSubtitle:
- "Connect to your HR system to sync employee data, auto-match reimbursements to the right people, and keep your team's expenses accurate without the manual work.",
+ 'Verbinden Sie sich mit Ihrem HR-System, um Mitarbeiterdaten zu synchronisieren, Erstattungen automatisch den richtigen Personen zuzuordnen und die Ausgaben Ihres Teams ohne manuellen Aufwand korrekt zu halten.',
subtitle: 'HR-Tools verbinden und Mitarbeitergenehmigungen synchron halten.',
connect: 'Verbinden',
syncNow: 'Jetzt synchronisieren',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index f522fa15619..55acfb145f2 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -6302,7 +6302,7 @@ ${amount} para ${merchant} - ${date}`,
title: 'HR',
connections: 'Conexiones',
connectionsSubtitle:
- "Connect to your HR system to sync employee data, auto-match reimbursements to the right people, and keep your team's expenses accurate without the manual work.",
+ 'Conéctate a tu sistema de RR. HH. para sincronizar los datos de empleados, emparejar automáticamente los reembolsos con las personas correctas y mantener los gastos de tu equipo precisos sin trabajo manual.',
subtitle: 'Conecta herramientas de HR y mantén sincronizadas las aprobaciones de empleados.',
connect: 'Conectar',
syncNow: 'Sincronizar ahora',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 208a917ac7e..7231b0e100a 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -7222,7 +7222,7 @@ Ajoutez davantage de règles de dépenses pour protéger la trésorerie de l’e
title: 'RH',
connections: 'Connexions',
connectionsSubtitle:
- "Connect to your HR system to sync employee data, auto-match reimbursements to the right people, and keep your team's expenses accurate without the manual work.",
+ 'Connectez votre système RH pour synchroniser les données des employé·es, faire correspondre automatiquement les remboursements aux bonnes personnes et garder les dépenses de votre équipe exactes, sans travail manuel.',
subtitle: 'Connectez vos outils RH et gardez les approbations des employés synchronisées.',
connect: 'Connecter',
syncNow: 'Synchroniser maintenant',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 8a6c1ee129c..62d32f966a0 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -7184,7 +7184,7 @@ Aggiungi altre regole di spesa per proteggere il flusso di cassa aziendale.`,
title: 'Risorse umane',
connections: 'Connessioni',
connectionsSubtitle:
- "Connect to your HR system to sync employee data, auto-match reimbursements to the right people, and keep your team's expenses accurate without the manual work.",
+ 'Collega il tuo sistema HR per sincronizzare i dati dei dipendenti, abbinare automaticamente i rimborsi alle persone giuste e mantenere le spese del tuo team accurate senza lavoro manuale.',
subtitle: 'Collega gli strumenti HR e mantieni sincronizzate le approvazioni dei dipendenti.',
connect: 'Connetti',
syncNow: 'Sincronizza ora',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 07969701db7..ba398ebcb74 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -7102,8 +7102,7 @@ ${reportName}
hr: {
title: '人事',
connections: '接続',
- connectionsSubtitle:
- "Connect to your HR system to sync employee data, auto-match reimbursements to the right people, and keep your team's expenses accurate without the manual work.",
+ connectionsSubtitle: '人事システムと連携して従業員データを同期し、精算を自動で正しい担当者に紐づけることで、手作業なしでチームの経費を正確に管理できます。',
subtitle: '人事ツールを連携して、従業員の承認を常に同期させます。',
connect: '接続',
syncNow: '今すぐ同期',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 985e367958a..110023654bb 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -7159,7 +7159,7 @@ er bestedingsregels toe om de kasstroom van het bedrijf te beschermen.`,
title: 'HR',
connections: 'Verbindingen',
connectionsSubtitle:
- "Connect to your HR system to sync employee data, auto-match reimbursements to the right people, and keep your team's expenses accurate without the manual work.",
+ 'Verbind met je HR-systeem om werknemersgegevens te synchroniseren, terugbetalingen automatisch aan de juiste personen te koppelen en de uitgaven van je team nauwkeurig te houden zonder handmatig werk.',
subtitle: 'Koppel HR-tools en houd goedkeuringen van medewerkers gesynchroniseerd.',
connect: 'Verbinden',
syncNow: 'Nu synchroniseren',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 5b5a4ff9561..9cbf7309a61 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -7154,7 +7154,7 @@ Dodaj więcej zasad wydatków, żeby chronić płynność finansową firmy.`,
title: 'HR',
connections: 'Połączenia',
connectionsSubtitle:
- "Connect to your HR system to sync employee data, auto-match reimbursements to the right people, and keep your team's expenses accurate without the manual work.",
+ 'Połącz się ze swoim systemem HR, aby synchronizować dane pracowników, automatycznie dopasowywać zwroty do właściwych osób i utrzymywać wydatki zespołu w porządku bez ręcznej pracy.',
subtitle: 'Połącz narzędzia HR i utrzymuj zgody pracowników w synchronizacji.',
connect: 'Połącz',
syncNow: 'Synchronizuj teraz',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 338a301a0db..cab6b19eef5 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -7159,7 +7159,7 @@ Adicione mais regras de gasto para proteger o fluxo de caixa da empresa.`,
title: 'RH',
connections: 'Conexões',
connectionsSubtitle:
- "Connect to your HR system to sync employee data, auto-match reimbursements to the right people, and keep your team's expenses accurate without the manual work.",
+ 'Conecte-se ao seu sistema de RH para sincronizar os dados de funcionários, associar automaticamente os reembolsos às pessoas corretas e manter as despesas da sua equipe precisas, sem trabalho manual.',
subtitle: 'Conecte ferramentas de RH e mantenha as aprovações de funcionários em sincronia.',
connect: 'Conectar',
syncNow: 'Sincronizar agora',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 19e48f5cdc7..897ddfc1679 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -6973,8 +6973,7 @@ ${reportName}
hr: {
title: '人力资源',
connections: '连接',
- connectionsSubtitle:
- "Connect to your HR system to sync employee data, auto-match reimbursements to the right people, and keep your team's expenses accurate without the manual work.",
+ connectionsSubtitle: '连接您的 HR 系统以同步员工数据，自动将报销匹配到正确的员工，并在无需手动操作的情况下保持团队报销的准确性。',
subtitle: '连接人力资源工具，保持员工审批同步。',
connect: '连接',
syncNow: '立即同步',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
melvin-bot
Bot
requested review from
heyjennahay and
shawnborton
and removed request for
a team
|
@shawnborton Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b5b897c9a5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+6304
to
+6305
| connectionsSubtitle: | ||
| "Connect to your HR system to sync employee data, auto-match reimbursements to the right people, and keep your team's expenses accurate without the manual work.", |
There was a problem hiding this comment.
workspace.hr.connectionsSubtitle is set to the English sentence in non-English locale files (for example Spanish here, and similarly in de, fr, it, ja, nl, pl, pt-BR, and zh-hans). For users whose app language is not English, the new copy under the Connections header will display in English, creating a mixed-language UI on the HR page and regressing localization accuracy for a prominently visible string.
Useful? React with 👍 / 👎.
Contributor
|
Can Melvin get us screenshots with playwright? |
Contributor
|
@MelvinBot Are you able to get us screenshots of this change? |
Contributor
|
@ShridharGoel, if you don't mind posting screenshots for @shawnborton to review when you test it, it would be appreciated if Melvin is unable to! |
Contributor
Author
|
Here are screenshots of the HR page with the new descriptive copy below the "Connections" header: Desktop (1280×800): Mobile (390×844): The subtitle text renders correctly on both viewports, with proper muted styling and text wrapping. |
Contributor
|
Looks good 👍 |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridApp
iOS: mWeb SafariMacOS: Chrome / Safari
|
Contributor
|
@MelvinBot Apply the patch present here: #91641 (comment) |
Contributor
Author
|
I see the translation patch from Polyglot Parrot and can apply it, but I can only make code changes when directed by the PR author, an assignee, or an existing co-author. To have me implement this, the PR assignee ( |
Contributor
|
@MelvinBot Apply the patch present here: #91641 (comment) |
Co-authored-by: Yuwen Memon <yuwenmemon@users.noreply.github.com>
|
@shawnborton Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
|
Applied the Polyglot Parrot translation patch — all 9 non-English language files now have proper translations for |
ShridharGoel
approved these changes
May 26, 2026
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #91032 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
amyevans
approved these changes
May 26, 2026
Contributor
|
🚧 @amyevans has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
54 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/amyevans in version: 9.3.83-0 🚀
Bundle Size Analysis (Sentry): |
Contributor
Author
|
I reviewed the changes in this PR and checked all help site articles under No help site changes are required. This PR adds descriptive subtitle copy below the "Connections" header on the Workspace HR page — a UI-only cosmetic change. No functionality, workflows, or navigation paths changed. The existing help articles (including @yuwenmemon, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
7 tasks
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.83-3 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Adds the approved descriptive copy below the "Connections" header on the Workspace HR page, matching the existing pattern on the Accounting page.
The HR page's
Sectioncomponent now usestitleandsubtitleprops (withsubtitleMutedstyling) instead of a customrenderTitle, consistent with howPolicyAccountingPagerenders its Connections section.The approved copy (from
NickTooker): "Connect to your HR system to sync employee data, auto-match reimbursements to the right people, and keep your team's expenses accurate without the manual work."Fixed Issues
$ #91032
Tests/QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.