Export and duplicated deleted expenses by jnowakow · Pull Request #88192 · Expensify/App

jnowakow · 2026-04-17T10:23:01Z

@rojiphil @luacmartins

Explanation of Change

Update useSearchBulkActions to allow duplicate and export deleted expenses.

Fixed Issues

$ #88088
PROPOSAL: N/A

Tests

Go to workspace chat.
Create an expense, then delete it.
Create another expense.
Go to Reports > Expenses.
Click Filters > Status.
Select all status > Apply > View results.
Select the deleted expense via checkbox, then click dropdown button.
→ Undelete, Export, Duplicate options are shown.
Select both deleted and existing expense via checkbox, then click dropdown button.
→ Export, Duplicate options are shown..

Verify that no errors appear in the JS console

Offline tests

Go to workspace chat.
Create an expense, then delete it.
Create another expense.
Go to Reports > Expenses.
Click Filters > Status.
Select all status > Apply > View results.
Select the deleted expense via checkbox, then click dropdown button.
→ Undelete, Export, Duplicate options are shown.
Select both deleted and existing expense via checkbox, then click dropdown button.
→ Export, Duplicate options are shown..

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Go to workspace chat.
Create an expense, then delete it.
Create another expense.
Go to Reports > Expenses.
Click Filters > Status.
Select all status > Apply > View results.
Select the deleted expense via checkbox, then click dropdown button.
→ Undelete, Export, Duplicate options are shown.
Select both deleted and existing expense via checkbox, then click dropdown button.
→ Export, Duplicate options are shown..

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

bulk-actions.mov

melvin-bot · 2026-04-17T10:23:08Z

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c2559e7316

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

codecov · 2026-04-17T10:33:11Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/hooks/useSearchBulkActions.ts	`42.62% <55.55%> (+1.38%)`	⬆️
... and 139 files with indirect coverage changes

jnowakow · 2026-04-17T12:22:50Z

@codex

chatgpt-codex-connector · 2026-04-17T12:32:27Z

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

luacmartins · 2026-04-17T17:03:05Z

@jnowakow spell check is failing

joekaufmanexpensify

Good for product

jnowakow · 2026-04-20T08:20:22Z

@codex

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f3f5899c84

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-20T08:35:29Z

+        if (allSelectedAreDeleted) {
+            const deletedTransactionOptions: Array<DropdownOption<SearchHeaderOptionValue>> = [


Restore undelete for all-matching deleted selections

This new deleted-only branch is placed after the areAllMatchingItemsSelected early return, so it is never reached when users choose “Select all matching items.” In that flow, deleted-expense selections now only get the export menu and lose the undelete/duplicate actions, which regresses bulk recovery for deleted expenses compared to the previous logic that still surfaced undelete for deleted selections.

Useful? React with 👍 / 👎.

Considering this discussion, it is expected behaviour

jnowakow · 2026-04-20T08:39:05Z

@luacmartins cspell is fixed

rojiphil · 2026-04-20T14:08:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

88192-android-hybrid-001.mp4

Android: mWeb Chrome

88192-mweb-chrome-001.mp4

iOS: HybridApp

88192-ios-hybrid-001.mp4

iOS: mWeb Safari

88192-mweb-safari-001.mp4

MacOS: Chrome / Safari

88192-web-chrome-001.mp4

rojiphil

Thanks @jnowakow for the updated PR.

@luacmartins LGTM too.
Over to you. Thanks.

luacmartins

LGTM

OSBotify · 2026-04-20T17:30:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-04-20T18:41:09Z

🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-20T18:46:44Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #88192.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-9c51880-41d2bf8-dc55e45ae01d62a8912f9749944951b544162463/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-9c51880-41d2bf8-333e880300b7d5ddda2f98c78bfd91ca2709bb3a/index.html

Web 🕸️
https://88192.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-21T11:42:55Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.61-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-21T11:46:00Z

I reviewed the changes in this PR and checked the help site articles under App/docs/articles.

Change needed: The How to Duplicate an Expense article lists the statuses where duplication is available as "Unreported, Draft, Processing, Approved, and Paid" — but does not include "Deleted." Since this PR enables duplicating (and exporting) deleted expenses, the article needs to be updated.

No other articles require changes. The Expense and Report Actions article already says duplicate is available "On non-card expenses in any state," which is broad enough. The export articles don't list status restrictions.

Draft PR created: #88411

The draft PR adds "Deleted" to the status list in the duplicate expense article. I was unable to add it to project 196 due to permissions — a maintainer will need to add it manually.

jponikarchuk · 2026-04-21T12:00:47Z

Deploy Blocker #88418 was identified to be related to this PR.

OSBotify · 2026-04-23T20:01:33Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.3.61-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Export and duplicated deleted expenses

c2559e7

jnowakow requested review from a team as code owners April 17, 2026 10:23

melvin-bot Bot assigned jnowakow Apr 17, 2026

melvin-bot Bot requested review from joekaufmanexpensify and rojiphil and removed request for a team April 17, 2026 10:23

melvin-bot Bot removed the request for review from a team April 17, 2026 10:23

chatgpt-codex-connector Bot reviewed Apr 17, 2026

View reviewed changes

Comment thread src/hooks/useSearchBulkActions.ts

move duplicate option after select all matching

9550803

Add test

c348f94

joekaufmanexpensify previously approved these changes Apr 17, 2026

View reviewed changes

Fix cspell

f3f5899

jnowakow dismissed joekaufmanexpensify’s stale review via f3f5899 April 20, 2026 08:18

chatgpt-codex-connector Bot reviewed Apr 20, 2026

View reviewed changes

rojiphil approved these changes Apr 20, 2026

View reviewed changes

melvin-bot Bot requested a review from luacmartins April 20, 2026 14:12

luacmartins approved these changes Apr 20, 2026

View reviewed changes

luacmartins merged commit 9c51880 into Expensify:main Apr 20, 2026
34 of 36 checks passed

OSBotify mentioned this pull request Apr 21, 2026

Deploy Checklist: New Expensify 2026-04-21 #88394

Closed

MelvinBot mentioned this pull request Apr 21, 2026

[NO QA] Docs updates for E/A#88192 Add Deleted status to duplicate expense docs #88411

Merged

2 tasks

jponikarchuk mentioned this pull request Apr 21, 2026

[Due for payment 2026-05-07] Expense - "You can't export an empty report." is shown when exporting deleted expense #88418

Closed

7 tasks

jponikarchuk mentioned this pull request Apr 21, 2026

[Due for payment 2026-04-30] Deleted expense can be duplicated and exported when bulk selecting it with existing expense #88088

Closed

7 tasks

rojiphil mentioned this pull request Apr 29, 2026

[Due for payment 2026-04-28] Payment issue for E/App PR#86938 #88398

Closed

		if (allSelectedAreDeleted) {
		const deletedTransactionOptions: Array<DropdownOption<SearchHeaderOptionValue>> = [

Uh oh!

Conversation

jnowakow commented Apr 17, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov Bot commented Apr 17, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jnowakow commented Apr 17, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 17, 2026

Uh oh!

luacmartins commented Apr 17, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

jnowakow commented Apr 20, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

jnowakow Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

jnowakow commented Apr 20, 2026

Uh oh!

rojiphil commented Apr 20, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

rojiphil left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Apr 20, 2026

Uh oh!

github-actions Bot commented Apr 20, 2026

Uh oh!

github-actions Bot commented Apr 20, 2026

Uh oh!

OSBotify commented Apr 21, 2026

Uh oh!

MelvinBot commented Apr 21, 2026

Uh oh!

jponikarchuk commented Apr 21, 2026

Uh oh!

OSBotify commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecov Bot commented Apr 17, 2026 •

edited by github-actions Bot

Loading