Fix Chronos timer dropdown button layout on native platforms by MelvinBot · Pull Request #87828 · Expensify/App

MelvinBot · 2026-04-14T00:01:56Z

Explanation of Change

PR #87543 replaced Button with ButtonWithDropdownMenu in ChronosTimerHeaderButton but kept passing style={styles.flex1}. In ButtonWithDropdownMenu, style applies to an inner View (the split-button wrapper), while the outer wrapper uses wrapperStyle. On native platforms, the unstyled outer View shrink-wraps its content, causing the dropdown button to render with broken layout.

This PR changes style to wrapperStyle so flex: 1 applies to the outer wrapper, matching how the original Button component handled it.

Fixed Issues

$ #87820
PROPOSAL: #87820 (comment)

AI Tests

TypeScript (npm run typecheck-tsgo): passed
Prettier: passed (file unchanged after formatting)
Full test suite (npm test -- --silent): running in CI

Human Tests

Build the app
Sign in
Go to Chronos chat
Shrink the screen to mobile size
Verify the button spans the full width of the page

Offline tests

None

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Use wrapperStyle instead of style on ButtonWithDropdownMenu so flex1 applies to the outer wrapper View rather than the inner split-button View. Co-authored-by: Tim Golen <tgolen@users.noreply.github.com>

melvin-bot · 2026-04-14T00:26:33Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2026-04-14T09:21:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

2026-04-14.11.41.01.mov

iOS: HybridApp

iOS: mWeb Safari

2026-04-14.11.41.01.mov

MacOS: Chrome / Safari

2026-04-14.11.30.07.mov

ZhenjaHorbach · 2026-04-14T09:43:50Z

LGTM!

trjExpensify

Is the button label centered here? It looks off to me:

CC: @Expensify/design

ZhenjaHorbach · 2026-04-14T10:50:15Z

Is the button label centered here? It looks off to me:
CC: @Expensify/design

I suppose it is centred without taking into account the right button 😁
But maybe yes
Considering the right button, it's a bit of an eyesore

shawnborton · 2026-04-14T12:59:42Z

Haha yeah I think it technically might be centered, as weird as it may look.

ZhenjaHorbach · 2026-04-14T13:09:30Z

Haha yeah I think it technically might be centered, as weird as it may look.

@shawnborton
So we can move on, or is it better to fix this? 😅

shawnborton · 2026-04-14T13:22:17Z

We move on!

trjExpensify · 2026-04-14T19:16:22Z

Cool, cool.. thanks for checking!

trjExpensify

👍

github-actions · 2026-04-15T03:34:19Z

🚧 @srikarparsi has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-15T03:39:18Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #87828.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-da8551b-d10f585-86d3f2457de6cd2aa154228b2875e190c01d12d2/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-da8551b-d10f585-766d70d1b27189c417c8b10f9312027b4df74edd/index.html

Web 🕸️
https://87828.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-15T03:41:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-04-16T03:59:44Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.3.60-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-16T04:00:59Z

No help site changes are needed for this PR. It's a one-line layout fix (style → wrapperStyle) on ChronosTimerHeaderButton — no user-facing features, workflows, or terminology are affected, and there are no existing help articles referencing Chronos.

OSBotify · 2026-04-21T11:13:39Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.60-22 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Fix Chronos timer dropdown button layout on native platforms

c4dc13f

Use wrapperStyle instead of style on ButtonWithDropdownMenu so flex1 applies to the outer wrapper View rather than the inner split-button View. Co-authored-by: Tim Golen <tgolen@users.noreply.github.com>

MelvinBot assigned tgolen Apr 14, 2026

MelvinBot requested a review from a team April 14, 2026 00:01

MelvinBot mentioned this pull request Apr 14, 2026

[Due for payment 2026-04-28] [$250] Android & iOS - Chronos - Start timer dropdown button is broken #87820

Closed

7 tasks

tgolen marked this pull request as ready for review April 14, 2026 00:26

tgolen requested a review from a team as a code owner April 14, 2026 00:26

melvin-bot Bot requested review from ZhenjaHorbach and removed request for a team April 14, 2026 00:26

melvin-bot Bot requested review from trjExpensify and removed request for a team April 14, 2026 00:26

ZhenjaHorbach approved these changes Apr 14, 2026

View reviewed changes

melvin-bot Bot requested a review from srikarparsi April 14, 2026 09:48

trjExpensify reviewed Apr 14, 2026

View reviewed changes

tgolen mentioned this pull request Apr 14, 2026

Add onSelected handler to Chronos timer dropdown option #87823

Merged

54 tasks

trjExpensify approved these changes Apr 14, 2026

View reviewed changes

srikarparsi approved these changes Apr 15, 2026

View reviewed changes

srikarparsi merged commit da8551b into main Apr 15, 2026
47 of 48 checks passed

srikarparsi deleted the claude-fixChronosTimerDropdownLayout branch April 15, 2026 03:33

OSBotify mentioned this pull request Apr 16, 2026

Deploy Checklist: New Expensify 2026-04-16 #88022

Closed

Uh oh!

Conversation

MelvinBot commented Apr 14, 2026 • edited by tgolen Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

AI Tests

Human Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 14, 2026

Uh oh!

ZhenjaHorbach commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Apr 14, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnborton commented Apr 14, 2026

Uh oh!

ZhenjaHorbach commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnborton commented Apr 14, 2026

Uh oh!

trjExpensify commented Apr 14, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Apr 15, 2026

Uh oh!

github-actions Bot commented Apr 15, 2026

Uh oh!

OSBotify commented Apr 15, 2026

Uh oh!

OSBotify commented Apr 16, 2026

Uh oh!

MelvinBot commented Apr 16, 2026

Uh oh!

OSBotify commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

MelvinBot commented Apr 14, 2026 •

edited by tgolen

Loading

ZhenjaHorbach commented Apr 14, 2026 •

edited

Loading

ZhenjaHorbach commented Apr 14, 2026 •

edited

Loading

ZhenjaHorbach commented Apr 14, 2026 •

edited

Loading