[Payment due @dukenv0307] Add a UI to Chronos for creating OOO events by tgolen · Pull Request #87543 · Expensify/App

tgolen · 2026-04-09T21:43:12Z

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/622509

Tests

Go to the Chronos chat
In the report header, open the dropdown button and select "Schedule OOO"
Fill out the form and test the different controls
Submit the form and verify that the proper message is sent to Chronos

Verify that no errors appear in the JS console

Offline tests

Same

QA Steps

Same

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I verified that similar component doesn't exist in the codebase
I verified that all props are defined accurately and each prop has a /** comment above it */
I verified that each file is named correctly
I verified that each component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
I verified that the only data being stored in component state is data necessary for rendering and nothing else
In component if we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
I verified that component internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
I verified that all JSX used for rendering exists in the render method
I verified that each component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-04-09T22:01:55Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`93.65% <ø> (ø)`
src/ONYXKEYS.ts	`100.00% <ø> (ø)`
src/SCREENS.ts	`100.00% <ø> (ø)`
src/components/NumberWithSymbolForm.tsx	`52.63% <100.00%> (+0.92%)`	⬆️
src/libs/ChronosUtils.ts	`98.07% <100.00%> (+0.64%)`	⬆️
src/libs/Navigation/linkingConfig/config.ts	`76.92% <ø> (ø)`
src/ROUTES.ts	`16.32% <0.00%> (+0.23%)`	⬆️
...gation/AppNavigator/ModalStackNavigators/index.tsx	`6.96% <50.00%> (+0.11%)`	⬆️
...on/AppNavigator/Navigators/RightModalNavigator.tsx	`5.15% <0.00%> (-0.17%)`	⬇️
src/types/form/ChronosScheduleOOOForm.ts	`0.00% <0.00%> (ø)`
... and 5 more
... and 214 files with indirect coverage changes

tgolen · 2026-04-09T22:04:35Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9377c6979e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-09T22:20:05Z

+        const timeValue = values[INPUT_IDS.TIME]?.trim();
+        if (timeValue && !/^(1[0-2]|0?[1-9])(:[0-5]\d)?$/.test(timeValue)) {
+            addErrorMessage(errors, INPUT_IDS.TIME, translate('chronos.invalidTimeFormat'));


Require AM/PM when time is provided

This validation allows a time value without timePeriod, and buildOOOCommand() only appends the period when it exists, so submitting 12:30 can generate ooo <date> 12:30 with no AM/PM. Since this form intentionally validates a 12-hour clock (1-12), the command is ambiguous and can schedule the wrong half-day OOO window when users forget to pick AM/PM. Please require timePeriod whenever time is filled (or provide a default) before submission.

Useful? React with 👍 / 👎.

melvin-bot · 2026-04-09T22:44:23Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tgolen · 2026-04-13T21:04:53Z

Access to Chronos is open to everyone, but there are a few features that not everyone can use. Come to think of it, OOO is one of them (because the events go on the OOO calendar). So, I'll need to mark this as internal!

AndrewGable

Thanks for adding automated tests!

OSBotify · 2026-04-13T21:18:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@dukenv0307

[Payment due @dukenv0307] Add a UI to Chronos for creating OOO events (cherry picked from commit 65098ab) (cherry-picked to staging by AndrewGable)

github-actions · 2026-04-13T21:46:53Z

🚧 @AndrewGable has triggered a test Expensify/App build. You can view the workflow run here.

AndrewGable · 2026-04-13T21:49:48Z

Internal QA passed for me on staging web 👍

github-actions · 2026-04-13T21:52:03Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #87543.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-65098ab-8a83e2d-72f4b751d4d3677a3727d64f6782c2a77cb89a02/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-65098ab-8a83e2d-ba3145293ca07feead88a577e297af213438fc22/index.html

Web 🕸️
https://87543.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-13T21:53:31Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.3.59-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-13T21:55:13Z

No help site changes are required for this PR.

Reason: Chronos is an internal Expensify employee tool (time-tracking bot). The "Schedule OOO" feature added here is accessed exclusively through the Chronos chat's header dropdown — it is not a customer-facing feature. The help site under App/docs/articles documents product features for external users, and there are no existing Chronos articles there.

The existing out-of-office help articles (Delegate-when-out-of-office.md in both new-expensify and expensify-classic) cover the Vacation Delegate feature, which is a separate, customer-facing concept unrelated to Chronos OOO scheduling.

mitarachim · 2026-04-13T22:45:15Z

Deploy Blocker #87815 was identified to be related to this PR.

lanitochka17 · 2026-04-13T22:56:12Z

Deploy Blocker ##87820 was identified to be related to this PR

OSBotify · 2026-04-16T03:30:59Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.3.59-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot · 2026-04-16T03:35:47Z

🤖 Payment issue created: #88024

OSBotify · 2026-04-16T03:57:38Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.3.60-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-16T03:59:07Z

No help site changes are required for this PR.

Reasoning:

This PR adds a "Schedule OOO" UI to the Chronos chat, which is an internal Expensify tool — not a general user-facing feature
There is no existing Chronos documentation on the help site (App/docs/articles/ has zero mentions of "Chronos")
The existing "Delegate when out of office" articles cover a different feature (approval delegation via Vacation Delegate), unrelated to Chronos OOO scheduling

AndrewGable · 2026-04-16T15:23:58Z

Internal QA passed for me on staging web 👍

OSBotify · 2026-04-21T11:11:33Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.60-22 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

tgolen added 11 commits April 9, 2026 13:09

WIP adding OOO UI

ae7b194

Make the schedule ooo option open the RHP right away

26b9105

Use datepicker

ee27165

Improve time input

e2b5297

Make plural

bcb9709

Default units to days

8bf4884

Always include % for user

c0c1e6c

Require numbers

66844bd

Fix plural units

1ce8240

Allow component to be compiled

70461a3

Move to constants

0166732

melvin-bot Bot assigned tgolen Apr 9, 2026

tgolen changed the title ~~Tgolen chronos ooo UI~~ Add a UI to Chronos for creating OOO events Apr 9, 2026

This comment has been minimized.

Sign in to view

tgolen added 2 commits April 9, 2026 15:46

Remove use memo

f6af3a7

Translations

9377c69

Add unit tests

1f510d3

chatgpt-codex-connector Bot reviewed Apr 9, 2026

View reviewed changes

Require time period when time is included

38afdac

tgolen marked this pull request as ready for review April 9, 2026 22:44

tgolen requested review from a team as code owners April 9, 2026 22:44

melvin-bot Bot requested a review from dukenv0307 April 9, 2026 22:44

melvin-bot Bot requested review from flaviadefaria and removed request for a team April 9, 2026 22:44

tgolen changed the title ~~Add a UI to Chronos for creating OOO events~~ [HOLD] Add a UI to Chronos for creating OOO events Apr 9, 2026

tgolen added the InternalQA This pull request required internal QA label Apr 13, 2026

AndrewGable approved these changes Apr 13, 2026

View reviewed changes

AndrewGable merged commit 65098ab into main Apr 13, 2026
39 checks passed

AndrewGable deleted the tgolen-chronos-oooUI branch April 13, 2026 21:08

OSBotify pushed a commit that referenced this pull request Apr 13, 2026

Merge pull request #87543 from Expensify/tgolen-chronos-oooUI

6ff97d2

[Payment due @dukenv0307] Add a UI to Chronos for creating OOO events (cherry picked from commit 65098ab) (cherry-picked to staging by AndrewGable)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Apr 13, 2026

OSBotify mentioned this pull request Apr 13, 2026

Deploy Checklist: New Expensify 2026-04-13 #87792

Closed

89 tasks

mitarachim mentioned this pull request Apr 13, 2026

[Due for payment 2026-04-28] Chronos - Start timer button from dropdown menu is not responsive #87815

Closed

7 tasks

MelvinBot mentioned this pull request Apr 13, 2026

Add onSelected handler to Chronos timer dropdown option #87823

Merged

54 tasks

lanitochka17 mentioned this pull request Apr 13, 2026

[Due for payment 2026-04-28] [$250] Android & iOS - Chronos - Start timer dropdown button is broken #87820

Closed

7 tasks

This was referenced Apr 14, 2026

Fix Chronos timer dropdown button layout on native platforms #87828

Merged

Steph's chat with Melvin #87829

Closed

OSBotify mentioned this pull request Apr 16, 2026

Deploy Checklist: New Expensify 2026-04-16 #88022

Closed

melvin-bot Bot mentioned this pull request Apr 16, 2026

[Due for payment 2026-04-23] Payment issue for E/App PR#87543 #88024

Closed

Julesssss mentioned this pull request Apr 17, 2026

Onboarding - Onboarding background is showing solid #88091

Closed

7 tasks

Uh oh!

Conversation

tgolen commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

This comment has been minimized.

codecov Bot commented Apr 9, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tgolen commented Apr 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Apr 9, 2026

Uh oh!

tgolen commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AndrewGable left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Apr 13, 2026

Uh oh!

github-actions Bot commented Apr 13, 2026

Uh oh!

AndrewGable commented Apr 13, 2026

Uh oh!

github-actions Bot commented Apr 13, 2026

Uh oh!

OSBotify commented Apr 13, 2026

Uh oh!

MelvinBot commented Apr 13, 2026

Uh oh!

mitarachim commented Apr 13, 2026

Uh oh!

lanitochka17 commented Apr 13, 2026

Uh oh!

OSBotify commented Apr 16, 2026

Uh oh!

melvin-bot Bot commented Apr 16, 2026

Uh oh!

OSBotify commented Apr 16, 2026

Uh oh!

MelvinBot commented Apr 16, 2026

Uh oh!

AndrewGable commented Apr 16, 2026

Uh oh!

OSBotify commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

tgolen commented Apr 9, 2026 •

edited

Loading

codecov Bot commented Apr 9, 2026 •

edited by github-actions Bot

Loading

tgolen commented Apr 13, 2026 •

edited

Loading