Skip to content

[No QA] Replace FullscreenLoadingIndicator with ActivityIndicator in OnyxTabNavigator#87588

Merged
Julesssss merged 2 commits into
mainfrom
claude-useActivityIndicatorInOnyxTabNavigator
Apr 13, 2026
Merged

[No QA] Replace FullscreenLoadingIndicator with ActivityIndicator in OnyxTabNavigator#87588
Julesssss merged 2 commits into
mainfrom
claude-useActivityIndicatorInOnyxTabNavigator

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Replace FullscreenLoadingIndicator with ActivityIndicator (wrapped in a styled View) in OnyxTabNavigator's lazyPlaceholder. This prevents a redundant "Go Back" button from appearing once shouldUseGoBackButton is enabled by default in FullscreenLoadingIndicator. The replacement reproduces the exact same layout and background styling (absoluteFillObject, fullScreenLoading, w100) with a centered large spinner, so the loading state is pixel-perfect identical.

Fixed Issues

$ #85381

Tests

  1. Open a page that uses OnyxTabNavigator with lazyLoadEnabled (e.g. the new chat or money request pages with tab navigation)
  2. Switch to a tab that hasn't been rendered yet
  3. Verify the loading spinner appears centered with the same background color and opacity as before
  4. Verify no "Go Back" button appears during loading
  5. Verify the tab content loads correctly after the spinner
  • Verify that no errors appear in the JS console

Offline tests

No special offline behavior — the lazy placeholder is shown while tab content renders, not during network requests.

QA Steps

  1. Navigate to a page with tab navigation (e.g. new chat page, money request page)
  2. Switch between tabs
  3. Verify loading spinner appears correctly (centered, with background) when switching to a not-yet-rendered tab
  4. Verify no "Go Back" button is shown during loading
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A — no visual change, loading spinner remains identical

Android: mWeb Chrome

N/A — no visual change, loading spinner remains identical

iOS: Native

N/A — no visual change, loading spinner remains identical

iOS: mWeb Safari

N/A — no visual change, loading spinner remains identical

MacOS: Chrome / Safari

N/A — no visual change, loading spinner remains identical

Checks run

Check Result
Prettier Pass
ESLint Pass
TypeScript (tsgo) Pass

@MelvinBot @situchan
Replace FullscreenLoadingIndicator with ActivityIndicator in OnyxTabN…
9472f39 
…avigator

The FullscreenLoadingIndicator in OnyxTabNavigator's lazyPlaceholder will
show a redundant Go Back button once shouldUseGoBackButton is enabled by
default. Replace it with an ActivityIndicator wrapped in a View that
reproduces the same layout and background styling (absoluteFillObject,
fullScreenLoading, w100) so the loading state is pixel-perfect identical
but without the Go Back button capability.

Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team April 10, 2026 10:31
@MelvinBot MelvinBot mentioned this pull request Apr 10, 2026
Closed
@MelvinBot @situchan
Fix: Replace deprecated absoluteFillObject with absoluteFill
52a1a9a 
Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
@MelvinBot

MelvinBot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor Author

Fixed the failing check: replaced deprecated StyleSheet.absoluteFillObject with StyleSheet.absoluteFill in OnyxTabNavigator.tsx:122.

@codecov

codecov Bot commented Apr 10, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/libs/Navigation/OnyxTabNavigator.tsx 84.61% <0.00%> (-1.88%) ⬇️
... and 18 files with indirect coverage changes

@situchan

situchan commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot add [No QA] prefix to the PR title as this is very hard to reproduce.

@MelvinBot

MelvinBot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor Author

PR Review

Summary: Clean, correct change. Replaces FullscreenLoadingIndicator with a plain ActivityIndicator + View wrapper in OnyxTabNavigator's lazy placeholder to avoid an unwanted "Go Back" button.

Verification:

  • The replacement reproduces the same visual layout: StyleSheet.absoluteFill + styles.fullScreenLoading (centering, background, opacity, z-index) + styles.w100 — matching the original outer View styles
  • CONST.ACTIVITY_INDICATOR_SIZE.LARGE matches the default iconSize in FullScreenLoadingIndicator
  • The inner <View style={styles.w100}> wrapper from the original is correctly omitted — it only existed to contain both the spinner and the Go Back button
  • useCallback dependency array correctly includes styles.fullScreenLoading and styles.w100
  • reasonAttributes telemetry is preserved on ActivityIndicator

One minor note: The original FullScreenLoadingIndicator calls useSkeletonSpan for performance telemetry. The replacement doesn't include this, but that's acceptable — a brief tab lazy-load placeholder doesn't need skeleton span tracking.

No issues found. The approach is sound — decoupling from FullScreenLoadingIndicator avoids inheriting its evolving behavior (like the Go Back button).

@MelvinBot MelvinBot changed the title Replace FullscreenLoadingIndicator with ActivityIndicator in OnyxTabNavigator [No QA] Replace FullscreenLoadingIndicator with ActivityIndicator in OnyxTabNavigator Apr 10, 2026
@situchan

situchan commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
ios.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mov

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Apr 10, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@situchan

situchan commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot mark as ready for review

@MelvinBot

MelvinBot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor Author

🤖 I attempted to mark this PR as ready for review, but I don't have permission to run that command in my current environment. Please mark it as ready for review manually using the GitHub UI (click "Ready for review" at the bottom of the PR) or run:

gh pr ready 87588 --repo Expensify/App

@situchan

situchan commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot mark as ready for review. I am assigned here.

@MelvinBot MelvinBot marked this pull request as ready for review April 10, 2026 22:17
@MelvinBot MelvinBot requested a review from a team as a code owner April 10, 2026 22:17
@MelvinBot

MelvinBot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Done! This PR has been marked as ready for review.

@melvin-bot

melvin-bot Bot commented Apr 10, 2026

Copy link
Copy Markdown

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed request for a team and joekaufmanexpensify April 10, 2026 22:17
@melvin-bot melvin-bot Bot requested a review from Julesssss April 10, 2026 22:18
@Julesssss Julesssss merged commit 7cfbf41 into main Apr 13, 2026
42 checks passed
@Julesssss Julesssss deleted the claude-useActivityIndicatorInOnyxTabNavigator branch April 13, 2026 20:12
@OSBotify OSBotify mentioned this pull request Apr 13, 2026
Closed
89 tasks
@OSBotify

OSBotify commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #87588.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-7cfbf41-40b89df-efebd42d561f09dee4fe665e743b277aa3cccc64/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-7cfbf41-40b89df-aa6f0f5dced658e24bc7514f10c6ec01066e4e75/index.html
Android iOS
Web 🕸️
https://87588.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify

OSBotify commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.59-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

Bundle Size Analysis (Sentry):

@MelvinBot

MelvinBot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

No help site changes required.

This PR swaps an internal loading indicator component (FullscreenLoadingIndicator → ActivityIndicator) in OnyxTabNavigator.tsx to prevent a redundant "Go Back" button. The change is purely internal with no user-facing feature, behavior, or terminology changes that would affect help site documentation.

@OSBotify

OSBotify commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.3.59-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Julesssss Julesssss Julesssss approved these changes
+1 more reviewer
@situchan situchan situchan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@situchan situchan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MelvinBot @situchan @OSBotify @Julesssss