Details
As part of the loading indicator standardization, we are preparing to enable shouldUseGoBackButton by default in FullscreenLoadingIndicator. Before that, we need to migrate components where FullscreenLoadingIndicator is used alongside visible navigation to use ActivityIndicator instead, otherwise users would see two back controls (the header back button AND the Go Back button from the loader).
OnyxTabNavigator is a navigation component that wraps React Navigation's Material Top Tab Navigator. The FullscreenLoadingIndicator is used as the lazyPlaceholder for lazy-loaded tab screens. When lazyLoadEnabled is true, switching to a tab that hasn't been rendered yet shows this placeholder while the tab content loads. During this time, the tab bar remains visible at the top, and the parent screen typically has a header with a back button. Enabling shouldUseGoBackButton would add a second back control alongside the visible tab bar and header navigation.
Solution
Replace FullscreenLoadingIndicator with ActivityIndicator in src/libs/Navigation/OnyxTabNavigator.tsx. The replacement must be an ActivityIndicator wrapped in a parent View that provides the same layout and background styling as FullscreenLoadingIndicator. The loading state must be pixel-perfect identical after the change. Same background color, same opacity, same centered large spinner in the tab content area below the tab bar.
Before making any changes, read the FullscreenLoadingIndicator component source to understand what styles it applies internally, and make sure the replacement reproduces them exactly. ActivityIndicator is a raw spinner with no layout or background styling, so it should not be used on its own as a fullscreen loading state. The codebase convention is to wrap it in a parent View that provides the layout and background styling.
Parent issue: #69850
Issue Owner
Current Issue Owner: @mallenexpensify
Details
As part of the loading indicator standardization, we are preparing to enable
shouldUseGoBackButtonby default inFullscreenLoadingIndicator. Before that, we need to migrate components whereFullscreenLoadingIndicatoris used alongside visible navigation to useActivityIndicatorinstead, otherwise users would see two back controls (the header back button AND the Go Back button from the loader).OnyxTabNavigatoris a navigation component that wraps React Navigation's Material Top Tab Navigator. TheFullscreenLoadingIndicatoris used as thelazyPlaceholderfor lazy-loaded tab screens. WhenlazyLoadEnabledis true, switching to a tab that hasn't been rendered yet shows this placeholder while the tab content loads. During this time, the tab bar remains visible at the top, and the parent screen typically has a header with a back button. EnablingshouldUseGoBackButtonwould add a second back control alongside the visible tab bar and header navigation.Solution
Replace
FullscreenLoadingIndicatorwithActivityIndicatorinsrc/libs/Navigation/OnyxTabNavigator.tsx. The replacement must be anActivityIndicatorwrapped in a parentViewthat provides the same layout and background styling asFullscreenLoadingIndicator. The loading state must be pixel-perfect identical after the change. Same background color, same opacity, same centered large spinner in the tab content area below the tab bar.Before making any changes, read the
FullscreenLoadingIndicatorcomponent source to understand what styles it applies internally, and make sure the replacement reproduces them exactly.ActivityIndicatoris a raw spinner with no layout or background styling, so it should not be used on its own as a fullscreen loading state. The codebase convention is to wrap it in a parentViewthat provides the layout and background styling.Parent issue: #69850
Issue Owner
Current Issue Owner: @mallenexpensify