Revert "Create Navigation guards with OnboardingGuard & TestDriveModalGuard"#82396
Revert "Create Navigation guards with OnboardingGuard & TestDriveModalGuard"#82396lakchote wants to merge 3 commits into
Conversation
melvin-bot
Bot
requested review from
mjasikowski and
trjExpensify
and removed request for
a team
|
@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here. |
|
Closing, culprit has been identified for the blocker #82332, see https://expensify.slack.com/archives/C01GTK53T8Q/p1770976835317929?thread_ts=1770935780.166369&cid=C01GTK53T8Q |
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 476727bd17
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| InteractionManager.runAfterInteractions(() => { | ||
| Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route); | ||
| }); |
There was a problem hiding this comment.
This branch runs specifically for private-domain users who already have accessible policies, but it now unconditionally navigates to TEST_DRIVE_MODAL_ROOT after completeOnboarding(). That bypasses the skip condition used elsewhere (onboardingPolicyID with no admins chat) and sends users who are joining an existing workspace into the test-drive modal instead of finishing onboarding in their workspace flow.
Useful? React with 👍 / 👎.
| currentOnboardingPurposeSelected, | ||
| currentOnboardingCompanySize, | ||
| onboardingInitialPath, |
There was a problem hiding this comment.
The deep-link handler now passes onboarding purpose/company size/last path into openReportFromDeepLink(), but this effect still only re-subscribes on session/concierge/intro changes. If onboarding progress changes after mount, the listener keeps stale values and startOnboardingFlow() can restart users from an outdated onboarding step when a new deep link is opened.
Useful? React with 👍 / 👎.
|
🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
lakchote
changed the title
|
Revert PR, doesn't need product review. |
2 participants
Reverts #81689