Skip to content

[CP staging] Revert "Expense-Scan and Manual Options Partially Hidden at Maximum Font Size"#78153

Merged
grgia merged 1 commit into
mainfrom
revert-76976-revert-fix/74676/text-are-partially-hidden
Dec 19, 2025
Merged

[CP staging] Revert "Expense-Scan and Manual Options Partially Hidden at Maximum Font Size"#78153
grgia merged 1 commit into
mainfrom
revert-76976-revert-fix/74676/text-are-partially-hidden

Conversation

@grgia

@grgia grgia commented Dec 19, 2025

Copy link
Copy Markdown
Contributor

Reverts #76976

Fixes #78052

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #78153.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ https://78153.pr-testing.expensify.com
The build for Desktop was skipped Web

👀 View the workflow run that generated this build 👀

@codecov

codecov Bot commented Dec 19, 2025

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...ents/HTMLEngineProvider/BaseHTMLEngineProvider.tsx 88.67% <ø> (ø)
...ReportPreview/MoneyRequestReportPreviewContent.tsx 59.93% <100.00%> (ø)
...m/TransactionPreview/TransactionPreviewContent.tsx 76.34% <100.00%> (ø)
src/styles/index.ts 46.28% <ø> (ø)
src/styles/variables.ts 100.00% <ø> (ø)
... and 7 files with indirect coverage changes

@grgia grgia marked this pull request as ready for review December 19, 2025 19:04
@grgia grgia requested review from a team as code owners December 19, 2025 19:04
@melvin-bot melvin-bot Bot requested review from inimaga and joekaufmanexpensify and removed request for a team December 19, 2025 19:04
@melvin-bot

melvin-bot Bot commented Dec 19, 2025

Copy link
Copy Markdown

@inimaga Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@grgia grgia requested review from a team and removed request for inimaga and joekaufmanexpensify December 19, 2025 19:05
@grgia grgia changed the title Revert "Expense-Scan and Manual Options Partially Hidden at Maximum Font Size" [CP staging] Revert "Expense-Scan and Manual Options Partially Hidden at Maximum Font Size" Dec 19, 2025
@melvin-bot melvin-bot Bot requested review from inimaga and removed request for a team December 19, 2025 19:05
@melvin-bot

melvin-bot Bot commented Dec 19, 2025

Copy link
Copy Markdown

@inimaga Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@dannymcclain

Copy link
Copy Markdown
Contributor

The category violation looks good in that build 👍

CleanShot 2025-12-19 at 15 44 18@2x

@grgia grgia merged commit 8875db2 into main Dec 19, 2025
34 of 37 checks passed
@grgia grgia deleted the revert-76976-revert-fix/74676/text-are-partially-hidden branch December 19, 2025 21:40
@melvin-bot melvin-bot Bot added the Emergency label Dec 19, 2025
@melvin-bot

melvin-bot Bot commented Dec 19, 2025

Copy link
Copy Markdown

@grgia looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@grgia grgia removed the Emergency label Dec 19, 2025
@grgia

grgia commented Dec 19, 2025

Copy link
Copy Markdown
Contributor Author

straight revert, no checklists

OSBotify pushed a commit that referenced this pull request Dec 19, 2025
…6/text-are-partially-hidden

[CP staging] Revert "Expense-Scan and Manual Options Partially Hidden at Maximum Font Size"

(cherry picked from commit 8875db2)

(cherry-picked to staging by AndrewGable)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Dec 19, 2025
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.2.84-8 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.84-8 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.2.85-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.85-7 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expense - Extra spacing between RBR and "Missing category"

4 participants