Add reportID and longReportID to custom columns#77799
Conversation
…e-4-reportid-longreportid
|
@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
luacmartins
left a comment
There was a problem hiding this comment.
Both of these use reportid as sorting key for Auth
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
…e-4-reportid-longreportid
…e-4-reportid-longreportid
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2025-12-16.at.22.21.08.mov |
|
@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
dismissing my own review since I pushed to the branch
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.2.82-0 🚀
|
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.2.82-0 🚀
|
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.2.82-0 🚀
|
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.2.84-0 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.84-8 🚀
|
Explanation of Change
Adds support for 'Reportid' and 'long report id' in the expense page view, via custom columns
Fixed Issues
$ #76873
Tests
The report id & long report id column should not be visible by default
Open the expense page 'Columns' RHP
Toggle report id on & long report id on
Ensure that the long report id & report id columns are visible and accurate
Navigate to reports
Open the reports page 'columns' rhp
Toggle report id on & long report id on
Ensure that the long report id & report id columns are visible and accurate
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2025-12-16.at.12.28.05.PM.mov