Skip to content

Fix italic-bold font difference#6561

Merged
Julesssss merged 1 commit into
Expensify:mainfrom
developvsn:fix-fontbolditalic-difference
Dec 2, 2021
Merged

Fix italic-bold font difference#6561
Julesssss merged 1 commit into
Expensify:mainfrom
developvsn:fix-fontbolditalic-difference

Conversation

@developvsn

Copy link
Copy Markdown
Contributor

Details

Changed fontFamily for strong and em elements.

Fixed Issues

$ #6489

Tests

  1. Open any report dialog.
  2. Write *_bold-italic_* and _*italic-bold*_.
  3. Check if there is any difference.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web

Mobile Web

mobileWeb

Desktop

desktop

iOS

ios

Android

android

@developvsn developvsn requested a review from a team as a code owner December 2, 2021 11:40
@MelvinBot MelvinBot requested review from ctkochan22 and parasharrajat and removed request for a team December 2, 2021 11:40

@Julesssss Julesssss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, reviewing this as the last PR was assigned to me then closed.

Julesssss
Julesssss previously approved these changes Dec 2, 2021

@parasharrajat parasharrajat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign the commits.... cc: @Julesssss

@Julesssss Julesssss merged commit 8b88cbc into Expensify:main Dec 2, 2021
@OSBotify

OSBotify commented Dec 2, 2021

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Dec 7, 2021

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @Julesssss in version: 1.1.17-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

OSBotify commented Dec 8, 2021

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants