Skip to content

Fix bold-italic and italic-bold font difference.#6560

Closed
developvsn wants to merge 1 commit into
Expensify:mainfrom
developvsn:fix-font-bolditalic
Closed

Fix bold-italic and italic-bold font difference.#6560
developvsn wants to merge 1 commit into
Expensify:mainfrom
developvsn:fix-font-bolditalic

Conversation

@developvsn

Copy link
Copy Markdown
Contributor

Details

Changed fontFamily for strong and em elements.

Fixed Issues

$ #6489

Tests

  1. Open any report dialog.
  2. Write *_bold-italic_* and _*italic-bold*_.
  3. Check if there is any difference.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web

Mobile Web

mobileWeb

Desktop

desktop

iOS

ios

Android

android

@developvsn developvsn requested a review from a team as a code owner December 2, 2021 09:51
@MelvinBot MelvinBot requested review from Julesssss and removed request for a team December 2, 2021 09:51

@Julesssss Julesssss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, plus Shawn agreed with the proposal here.

@Julesssss

Copy link
Copy Markdown
Contributor

@developvsn there's a conflict here.

@developvsn developvsn closed this Dec 2, 2021
@developvsn developvsn deleted the fix-font-bolditalic branch December 2, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants