Skip to content

[NO QA] Update travel docs for dynamic itinerary generation improvements#65288

Merged
twisterdotcom merged 3 commits into
mainfrom
travel-docs-dynamic-itinerary-updates
Jul 7, 2025
Merged

[NO QA] Update travel docs for dynamic itinerary generation improvements#65288
twisterdotcom merged 3 commits into
mainfrom
travel-docs-dynamic-itinerary-updates

Conversation

@twisterdotcom

@twisterdotcom twisterdotcom commented Jul 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

  • Remove references to trip expense reports being created automatically
  • Clarify that travel expenses follow workspace scheduled submit rules
  • Add context that trip itineraries remain accurate regardless of expense handling
  • Update analytics documentation to reflect trip-level data source
  • Add FAQ explaining improved expense handling
  • Enhance approval documentation with itinerary accuracy assurance

These changes support the 'Harden dynamic itinerary generation' project by updating documentation to reflect the new backend architecture where trip data is stored in rNVPs rather than being derived from expenses.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/505999
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

@twisterdotcom
Update travel docs for dynamic itinerary generation improvements
a6e7556 
- Remove references to trip expense reports being created automatically
- Clarify that travel expenses follow workspace scheduled submit rules
- Add context that trip itineraries remain accurate regardless of expense handling
- Update analytics documentation to reflect trip-level data source
- Add FAQ explaining improved expense handling
- Enhance approval documentation with itinerary accuracy assurance

These changes support the 'Harden dynamic itinerary generation' project
by updating documentation to reflect the new backend architecture where
trip data is stored in rNVPs rather than being derived from expenses.
@twisterdotcom
twisterdotcom requested a review from rlinoz July 1, 2025 23:19
@twisterdotcom twisterdotcom self-assigned this Jul 1, 2025
@twisterdotcom
twisterdotcom requested a review from a team as a code owner July 1, 2025 23:19
@melvin-bot

melvin-bot Bot commented Jul 1, 2025 •
edited by RachCHopkins
Loading

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @RachCHopkins

@melvin-bot
melvin-bot Bot requested review from Ollyws and RachCHopkins and removed request for a team July 1, 2025 23:19
@melvin-bot

melvin-bot Bot commented Jul 1, 2025

Copy link
Copy Markdown

@Ollyws @RachCHopkins One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions

github-actions Bot commented Jul 1, 2025 •
edited by OSBotify
Loading

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://24dd96d0.helpdot.pages.dev ⚡️

@RachCHopkins

RachCHopkins commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

LGTM!

@twisterdotcom
twisterdotcom merged commit 665f42d into main Jul 7, 2025
14 of 15 checks passed
@twisterdotcom
twisterdotcom deleted the travel-docs-dynamic-itinerary-updates branch July 7, 2025 22:53
@twisterdotcom twisterdotcom changed the title Update travel docs for dynamic itinerary generation improvements [NO QA] Update travel docs for dynamic itinerary generation improvements Jul 7, 2025
@github-actions github-actions Bot mentioned this pull request Jul 8, 2025
Closed
59 tasks
@github-actions

github-actions Bot commented Jul 8, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/twisterdotcom in version: 9.1.78-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@github-actions

github-actions Bot commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.78-4 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RachCHopkins RachCHopkins RachCHopkins approved these changes
@rlinoz rlinoz Awaiting requested review from rlinoz
@Ollyws Ollyws Awaiting requested review from Ollyws

Assignees

@twisterdotcom twisterdotcom

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@twisterdotcom @RachCHopkins