Skip to content

[CP Staging] Revert "Show 'Report physical card loss/damage' option for physical cards, regardless of activation status"#56152

Merged
mountiny merged 1 commit into
mainfrom
revert-55767-fix/55189
Jan 31, 2025
Merged

[CP Staging] Revert "Show 'Report physical card loss/damage' option for physical cards, regardless of activation status"#56152
mountiny merged 1 commit into
mainfrom
revert-55767-fix/55189

Conversation

@cristipaval

@cristipaval cristipaval commented Jan 31, 2025

Copy link
Copy Markdown
Contributor

Reverts #55767

Fixes:
Fixes #56148
Fixes #56150
Fixes #56155

QA steps

Retest the linked blockers - they might not even be possible as you wont be able to report fraud for those cards

@cristipaval
cristipaval requested a review from mountiny January 31, 2025 11:34
@cristipaval cristipaval self-assigned this Jan 31, 2025
@cristipaval
cristipaval requested a review from a team as a code owner January 31, 2025 11:34
@melvin-bot
melvin-bot Bot removed the request for review from a team January 31, 2025 11:34
@melvin-bot

melvin-bot Bot commented Jan 31, 2025

Copy link
Copy Markdown

@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny mountiny changed the title Revert "Show 'Report physical card loss/damage' option for physical cards, regardless of activation status" [CP Staging] Revert "Show 'Report physical card loss/damage' option for physical cards, regardless of activation status" Jan 31, 2025

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert

@mountiny
mountiny merged commit 1365991 into main Jan 31, 2025
@mountiny
mountiny deleted the revert-55767-fix/55189 branch January 31, 2025 15:42
@melvin-bot melvin-bot Bot added the Emergency label Jan 31, 2025
@melvin-bot

melvin-bot Bot commented Jan 31, 2025

Copy link
Copy Markdown

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny

Copy link
Copy Markdown
Contributor

Straight revert

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Jan 31, 2025
[CP Staging] Revert "Show 'Report physical card loss/damage' option for physical cards, regardless of activation status"

(cherry picked from commit 1365991)

(CP triggered by mountiny)
@github-actions github-actions Bot added the CP Staging marks PRs that have been CP'd to staging label Jan 31, 2025
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.93-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@izarutskaya

Copy link
Copy Markdown

@cristipaval @mountiny Issue #56150 still reproducible on Web and mWeb

1738578830502.test_1.mp4
1738359000193.56152-mWeb_2.mp4

@github-actions

github-actions Bot commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.93-3 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

4 participants