Show 'Report physical card loss/damage' option for physical cards, regardless of activation status by Shahidullah-Muffakir · Pull Request #55767 · Expensify/App

Shahidullah-Muffakir · 2025-01-26T04:37:34Z

Explanation of Change

Previously, the option Report physical card loss/damage was only shown if the card's status was "open." With this change, the option will now be displayed for any physical card that is shown, regardless of its activation status. The only time the option won't appear is if the card's state is STATE_NOT_ISSUED.

Fixed Issues

$ #55189
PROPOSAL: #55189 (comment)

Tests

Assigned a physical card with different statuses:
1. STATE_NOT_ISSUED
2. OPEN
3. NOT_ACTIVATED
4. STATE_SUSPENDED

Run this in the console(One by one for each status)

Onyx.merge('cardList', {
    '21534538': {
        accountID: 1,
        bank: 'Expensify Card',
        cardID: 21534538,
        domainName: 'expensify-policy1.exfy',
        nameValuePairs: {cardTitle: ' STATE_NOT_ISSUED', isVirutal: false, issuedBy: 18974130},
        isVirtual: false,
        lastFourPAN: '',
        state: 2,
    },
    '21534538': {
        accountID: 1,
        bank: 'Expensify Card',
        cardID: 21534538,
        domainName: 'expensify-policy1.exfy',
        nameValuePairs: {cardTitle: 'OPEN', isVirutal: false, issuedBy: 18974130},
        isVirtual: false,
        lastFourPAN: '',
        state: 3,
    },
    '21534538': {
        accountID: 1,
        bank: 'Expensify Card',
        cardID: 21534538,
        domainName: 'expensify-policy1.exfy',
        nameValuePairs: {cardTitle: '  NOT_ACTIVATED:', isVirutal: false, issuedBy: 18974130},
        isVirtual: false,
        lastFourPAN: '',
        state: 4,
    },
    '21534538': {
        accountID: 1,
        bank: 'Expensify Card',
        cardID: 21534538,
        domainName: 'expensify-policy1.exfy',
        nameValuePairs: {cardTitle: ' STATE_SUSPENDED ', isVirutal: false, issuedBy: 18974130},
        isVirtual: false,
        lastFourPAN: '',
        state: 7,
    },
});

In the Wallet page, in the Assigned Cards section, verify that the "Report physical card loss/damage" option is shown for the following statuses:
1. OPEN
2. NOT_ACTIVATED
Verify that the "Report physical card loss/damage" option is NOT shown for the STATE_NOT_ISSUED status.

Verify that no errors appear in the JS console

Offline tests

Assigned a physical card with different statuses:
1. STATE_NOT_ISSUED
2. OPEN
3. NOT_ACTIVATED
4. STATE_SUSPENDED
In the Wallet page, in the Assigned Cards section, verify that the "Report physical card loss/damage" option is shown for the following statuses:
1. OPEN
2. NOT_ACTIVATED
Verify that the "Report physical card loss/damage" option is NOT shown for the STATE_NOT_ISSUED status.

QA Steps

Join a workspace with the Expensify Card enabled
As a workspace member, get assigned a physical Expensify Card
Open the Wallet page
In the Assigned Cards section, click the newly assigned card
Verify the "Report physical card loss/damage" option is shown while the card is still in state: NOT_ACTIVATED

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

ios.20native-4.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

maco.20safari.mp4

MacOS: Desktop

desktoop.mp4

…gardless of activation status

melvin-bot · 2025-01-26T04:37:39Z

@paultsimura Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

paultsimura · 2025-01-26T15:11:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.webm

Android: mWeb Chrome

chrome.webm

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-01-26.at.16.05.13.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-01-26.at.16.05.36.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-01-26.at.15.59.35.mov

MacOS: Desktop

Screen.Recording.2025-01-26.at.16.08.12.mov

paultsimura

That is a nice, clean solution, thanks 👍
Also, good job differentiating Tests and QA Steps in this case.

Please make the QA steps more straightforward for QA flow, like this (because I doubt there is a clear way to reproduce all different card statuses during QA):

Join a workspace with the Expensify Card enabled
As a workspace member, get assigned a physical Expensify Card
Open the Wallet page
In the Assigned Cards section, click the newly assigned card
Verify the "Report physical card loss/damage" option is shown while the card is still in state: NOT_ACTIVATED

Shahidullah-Muffakir · 2025-01-26T16:01:38Z

That is a nice, clean solution, thanks 👍 Also, good job differentiating Tests and QA Steps in this case.

Please make the QA steps more straightforward for QA flow, like this (because I doubt there is a clear way to reproduce all different card statuses during QA):

Join a workspace with the Expensify Card enabled

As a workspace member, get assigned a physical Expensify Card

Open the Wallet page

In the Assigned Cards section, click the newly assigned card

Verify the "Report physical card loss/damage" option is shown while the card is still in state: NOT_ACTIVATED

Thanks! Updated the QA steps as suggested.

Shahidullah-Muffakir · 2025-01-26T16:11:41Z

@paultsimura Just to confirm the expected behaviour, with the new changes, the Report physical card loss/damage option is shown if the card state is STATE_SUSPENDED. Is it the same in OD? Is this correct?
c.c @cristipaval

paultsimura · 2025-01-26T16:25:57Z

Just to confirm the expected behaviour, with the new changes, the Report physical card loss/damage option is shown if the card state is STATE_SUSPENDED. Is it the same in OD? Is this correct?

@twisterdotcom maybe you could also help as you reported the issue.

cristipaval · 2025-01-27T11:32:25Z

I see in the OldDot front-end code that we have the following states:

Card.STATE_NOT_ISSUED
Card.STATE_OPEN
Card.STATE_NOT_ACTIVATED
Card.STATE_DEACTIVATED
Card.STATE_SUSPENDED

The user can click the Request New Card button on a physical card if that card has one of the OPEN or NOT_ACTIVATED states. And when the user clicks the button, the following modal shows:

So I would imagine that we want to show the report option in NewDot when the card is in OPEN or NOT_ACTIVATED state.

cc @twisterdotcom and maybe @joekaufmanexpensify for confirmation 🙏

twisterdotcom · 2025-01-27T12:11:34Z

I would imagine that we want to show the report option in NewDot when the card is in OPEN or NOT_ACTIVATED state.

@cristipaval that is exactly correct. I believe we only show it now for the OPEN state and we want to show it for NOT_ACTIVATED as well in newDot.

It should not show for STATE_NOT_ISSUED or STATE_SUSPENDED

paultsimura · 2025-01-27T12:13:03Z

Nice. @Shahidullah-Muffakir could you please update accordingly?

paultsimura

Removing approval for now.

Shahidullah-Muffakir · 2025-01-27T14:29:08Z

Thank you for confirming, I'll add the changes.

…state is either open or not_activated

Shahidullah-Muffakir · 2025-01-27T15:25:44Z

@paultsimura I've added the changes, thank you.

paultsimura · 2025-01-27T16:08:33Z

Adding screenshots as a confirmation.

NOT_ACTIVATED:

OPEN:

Other statuses:

paultsimura

LGTM ✔️

OSBotify · 2025-01-30T11:18:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-31T07:02:22Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.0.93-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	cancelled 🔪
🍎🔄 iOS HybridApp 🍎🔄	cancelled 🔪

twisterdotcom · 2025-01-31T10:02:26Z

Why were so many of the deploys canceled?

github-actions · 2025-02-03T23:07:32Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.93-3 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

twisterdotcom · 2025-02-03T23:19:11Z

Do we care that this failed to deploy to some platforms?

paultsimura · 2025-02-04T10:21:22Z

AFAIK, this PR was reverted: https://expensify.slack.com/archives/C01GTK53T8Q/p1738321390817309

Show 'Report Physical Card Loss/Damage' option for physical cards, re…

f84e031

…gardless of activation status

Shahidullah-Muffakir requested a review from a team as a code owner January 26, 2025 04:37

melvin-bot Bot requested review from paultsimura and removed request for a team January 26, 2025 04:37

paultsimura approved these changes Jan 26, 2025

View reviewed changes

melvin-bot Bot requested a review from cristipaval January 26, 2025 15:15

This comment was marked as duplicate.

Sign in to view

paultsimura suggested changes Jan 27, 2025

View reviewed changes

Shahidullah-Muffakir added 2 commits January 27, 2025 20:12

don't show the 'Report physical card loss/damage' for suspended card

cd55165

only show the 'Report physical card loss/damage' option if the card …

d742912

…state is either open or not_activated

paultsimura approved these changes Jan 27, 2025

View reviewed changes

cristipaval approved these changes Jan 30, 2025

View reviewed changes

cristipaval merged commit c3b2f3a into Expensify:main Jan 30, 2025

github-actions Bot mentioned this pull request Jan 31, 2025

Deploy Checklist: New Expensify 2025-01-31 #56137

Closed

42 tasks

cristipaval mentioned this pull request Jan 31, 2025

[CP Staging] Revert "Show 'Report physical card loss/damage' option for physical cards, regardless of activation status" #56152

Merged

melvin-bot Bot mentioned this pull request Feb 3, 2025

[HOLD for payment 2025-05-06] [$250] No option to report physical card damaged or stolen before it's activated #55189

Closed

8 tasks

Uh oh!

Conversation

Shahidullah-Muffakir commented Jan 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 26, 2025

Uh oh!

paultsimura commented Jan 26, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

paultsimura left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Shahidullah-Muffakir commented Jan 26, 2025

Uh oh!

Shahidullah-Muffakir commented Jan 26, 2025

Uh oh!

paultsimura commented Jan 26, 2025

Uh oh!

cristipaval commented Jan 27, 2025

Uh oh!

twisterdotcom commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paultsimura commented Jan 27, 2025

Uh oh!

This comment was marked as duplicate.

Uh oh!

paultsimura left a comment

Choose a reason for hiding this comment

Uh oh!

Shahidullah-Muffakir commented Jan 27, 2025

Uh oh!

Shahidullah-Muffakir commented Jan 27, 2025

Uh oh!

paultsimura commented Jan 27, 2025

Uh oh!

paultsimura left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jan 30, 2025

Uh oh!

github-actions Bot commented Jan 31, 2025

Uh oh!

twisterdotcom commented Jan 31, 2025

Uh oh!

github-actions Bot commented Feb 3, 2025

Uh oh!

twisterdotcom commented Feb 3, 2025

Uh oh!

paultsimura commented Feb 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Shahidullah-Muffakir commented Jan 26, 2025 •

edited

Loading

paultsimura left a comment •

edited

Loading

twisterdotcom commented Jan 27, 2025 •

edited

Loading