Add RBR to Search action button by luacmartins · Pull Request #52333 · Expensify/App

luacmartins · 2024-11-11T19:02:55Z

Explanation of Change

Shows an RBR and the review button if there's an error with the request

Fixed Issues

$ #53495

Tests

Pre-requisite: an expense that can be approved and paid

Log into the same account in two different windows/devices
Go to Search on both of them
[Device A and B] Throttle the network speed
[Device A and B] Approve/Pay the expense at the same time
[Device A or B] Verify that one device shows Paid and the other shows Review button with an RBR

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-12-03T22:02:29Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Pujan92 · 2024-12-06T12:04:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

vd.mov

MacOS: Desktop

luacmartins · 2024-12-10T19:19:29Z

@Pujan92 bump for review

Pujan92 · 2024-12-11T13:26:46Z

@luacmartins Review text doesn't persist and it instantly turns to Paid, is it fine?

Screen.Recording.2024-12-11.at.18.50.49.mov

I think device A should not go offline bcoz when we turn online it fetches the data again, instead only throttling the speed enough to Pay on both windows and it persists the Review button. If you think the same then we need to update the test step.

vd.mov

luacmartins · 2024-12-11T16:28:25Z

Ah yea, that's expected since it'll fetch the new result. I agree that your suggestion should fix it and updated the tests accordingly. I was having trouble with that in my local environment, but maybe I just wasn't fast enough even with the throttled local network

luacmartins · 2024-12-11T16:33:53Z

Resolved conflicts

Pujan92

LGTM, Thanks!

melvin-bot · 2024-12-11T16:37:11Z

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

OSBotify · 2024-12-12T14:13:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-13T16:03:00Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.0.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

vincdargento · 2024-12-13T20:33:35Z

@luacmartins This PR is failing because of issue #54128

The issue is reproducible in: Google Pixel 8, Android 14, Chrome

bug.mp4

luacmartins · 2024-12-13T22:53:38Z

Thanks! I demoted that issue and I think we're good to check it off since it's a small edge case.

github-actions · 2024-12-18T13:15:16Z

🚀 Deployed to production by https://github.com/grgia in version: 9.0.76-12 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

parasharrajat · 2025-01-15T11:13:19Z


+    // We need to check both options for a falsy value since the transaction might not have an error but the report associated with it might
+    // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
+    if (transaction?.hasError || report.hasError) {


hasError does not update with Onyx updates which caused #54161

add rbr to button

5cbf7e6

luacmartins self-assigned this Nov 11, 2024

rm import

185b8d2

rlinoz mentioned this pull request Nov 12, 2024

[HOLD for payment 2024-12-03] [Search v1.2] - Pay button can be clicked many times without error when bank account is not set up #52371

Closed

8 tasks

luacmartins mentioned this pull request Nov 12, 2024

[HOLD for payment 2024-12-03] [Search v1.2] - Unable to pay held expense in Search #52377

Closed

8 tasks

luacmartins added 3 commits November 27, 2024 12:05

resolve conflicts

d71f8fc

resolve more conflicts

61872c2

more conflicts

b4c2d8f

luacmartins changed the title ~~Add RBR to Search action button~~ [HOLD #51913] Add RBR to Search action button Nov 27, 2024

luacmartins added 2 commits December 3, 2024 13:38

resolve conflicts

7bfecbd

handle failed request

e0ca249

luacmartins changed the title ~~[HOLD #51913] Add RBR to Search action button~~ Add RBR to Search action button Dec 3, 2024

luacmartins added 2 commits December 3, 2024 14:42

reorder buttons

d03e9b1

fix eslint

dbcdd25

luacmartins marked this pull request as ready for review December 3, 2024 22:02

luacmartins requested a review from a team as a code owner December 3, 2024 22:02

melvin-bot Bot requested a review from Pujan92 December 3, 2024 22:02

melvin-bot Bot removed the request for review from a team December 3, 2024 22:02

resolve conflicts

24ddbcd

resolve conflicts

5b5c07a

Pujan92 approved these changes Dec 11, 2024

View reviewed changes

melvin-bot Bot requested a review from arosiclair December 11, 2024 16:37

arosiclair approved these changes Dec 12, 2024

View reviewed changes

arosiclair merged commit c2285e6 into main Dec 12, 2024

arosiclair deleted the cmartins-addRBR branch December 12, 2024 14:04

github-actions Bot mentioned this pull request Dec 13, 2024

Deploy Checklist: New Expensify 2024-12-13 #54111

Closed

60 tasks

vincdargento mentioned this pull request Dec 13, 2024

[HOLD App # 54161][$250] Search - Paid expense concurrently on mobile device is not shown as needed Review nor Paid #54128

Closed

8 tasks

francoisl mentioned this pull request Dec 13, 2024

[HOLD for payment 2024-12-30] Search - Individual expenses shows "Paid" instead of "View" when group expenses are paid #54131

Closed

8 tasks

melvin-bot Bot mentioned this pull request Dec 18, 2024

[HOLD for payment 2024-12-25] [Search v2.5] Add RBR and Review action to Search #53495

Closed

parasharrajat reviewed Jan 15, 2025

View reviewed changes

Uh oh!

Conversation

luacmartins commented Nov 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Dec 3, 2024

Uh oh!

Pujan92 commented Dec 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

luacmartins commented Dec 10, 2024

Uh oh!

Pujan92 commented Dec 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luacmartins commented Dec 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luacmartins commented Dec 11, 2024

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Dec 11, 2024

Uh oh!

OSBotify commented Dec 12, 2024

Uh oh!

github-actions Bot commented Dec 13, 2024

Uh oh!

vincdargento commented Dec 13, 2024

Uh oh!

luacmartins commented Dec 13, 2024

Uh oh!

github-actions Bot commented Dec 18, 2024

Uh oh!

parasharrajat Jan 15, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

luacmartins commented Nov 11, 2024 •

edited

Loading

Pujan92 commented Dec 6, 2024 •

edited

Loading

Pujan92 commented Dec 11, 2024 •

edited

Loading

luacmartins commented Dec 11, 2024 •

edited

Loading