[HOLD for payment 2025-01-15] Reports - Review button does not change to Paid label after the expense is paid

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.76-6
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+kh04120007@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Search

Action Performed:

Precondition:

• User A's network speed is set to 3G.

1. Go to staging.new.expensify.com
2. [User B] Submit an expense to User A.
3. [User A] Pay the expense.
4. [User B] Submit two expenses to User A.
5. [User A] Go to Reports > Expenses > Outstanding.
6. [User B] Delete one of the expenses.
7. [User A] Quickly pay the two expenses right after User B deletes one of them (to trigger RBR).
8. [User A] Click Review button.
9. [User A] Pay the expense from expense RHP.
10. [User A] Close the RHP.

Expected Result:

Review button should change to Paid label.

Actual Result:

Review button does not change to Paid label after the expense is paid.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6694148_1734168052403.20241214_171200.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

Production and stg with SS off has a different behavior

bandicam.2024-12-14.18-52-34-223.mp4

bandicam.2024-12-14.18-56-49-635.mp4

[trjExpensify]

Reproducible in production?: Unable to check

@IuliiaHerets why?

[trjExpensify]

Also, why did you add the web deploy blocker label to it? 🤔

[trjExpensify]

Production and stg with SS off has a different behavior

What does "SS" stand for? "Scheduled submit"? That's a workspace feature, whereas these videos look like expenses sent to an individual, so iouReports?

[izarutskaya]

Hi @trjExpensify Let me check please and come back

[trjExpensify]

Sounds good!

[izarutskaya]

SS on/off - when we enabled/disabled Use Staging Server

When we disabled Use Staging Server, review button not appear after step 7 [User A] Quickly pay the two expenses right after User B deletes one of them (to trigger RBR)

Screen.Recording.2024-12-14.at.6.45.34.PM.mov

In Prod I have different behavior , after step 7 review button also not appear, I have pay button and after click change to Paid label.

Recording.2938.mp4

Let me know if I can help something else

[trjExpensify]

SS on/off - when we enabled/disabled Use Staging Server

Okay cool, "SS" is an abbreviation used interchangeably for Scheduled Submit, SmartScan and Staging Server. Best to spell it out in bug reports for the avoidance of doubt and ease of following.

Looking at this video, it seems like you're having to split screen to force a race condition of sorts between deleting the expense (User B) and paying the IOUReport (User A). It'll be hard for a real customer to run into this.

That said, my first question is whether the "Review" button should be shown at all for IOUReports @luacmartins @JmillsExpensify? Then secondly, what do we expect? Should the payment attempt add an error to the report because it failed due to a change to the report? Basically just like an offline action, I.e

1. UserA submits two expenses to UserB
2. UserB goes offline
3. UserA deletes one of the expenses
4. UserB pays the iouReport while offline
5. UserB comes back online, the payment attempt fails because of a change to the report (an expense was deleted).
6. An RBR is added for the payer with an in-line error message on the paid action.

[luacmartins]

I agree that this is an edge case and we can demote it to NAB.

[JmillsExpensify]

Same. NAB