[Workspace feeds] Add search bar if cards assignment list has 8+ cards by VickyStash · Pull Request #51955 · Expensify/App

VickyStash · 2024-11-04T14:28:11Z

Explanation of Change

[Workspace feeds] Add search bar if cards assignment list has 8+ cards

Fixed Issues

$ #51906
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Login to the account that has workspace with the Company Cards feature enabled and a custom feed added. The feed should have 8+ cards to be assigned.
Go to the Workspace -> Company card section.
Start Card assignment flow.
Select the employee to assign a card to and press Next.
Make sure the card selection step has a search field if there are more than 8 cards available.
Try to search the card and make sure it works as expected.

Offline tests

N/A

QA Steps

Verify that no errors appear in the JS console

Same as in the Tests sections.

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android_web.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios_web.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

…t-search

melvin-bot · 2024-11-06T16:16:42Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2024-11-06T17:20:54Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-07.at.16.24.30.mov

Android: mWeb Chrome

Screen.Recording.2024-11-07.at.16.21.01.mov

iOS: Native

Screen.Recording.2024-11-07.at.16.23.27.mov

iOS: mWeb Safari

Screen.Recording.2024-11-07.at.16.21.46.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-07.at.16.18.07.mov

MacOS: Desktop

Screen.Recording.2024-11-07.at.00.05.57.mov

dukenv0307 · 2024-11-06T17:28:55Z

native devices are so lagging for now, so I can't record video on iOS

dubielzyk-expensify · 2024-11-07T01:11:27Z

Can you upload a video with showing the scrolling list? 😇

dukenv0307 · 2024-11-07T03:25:17Z

@VickyStash Can you share the video when users scroll the list? Thanks

VickyStash · 2024-11-07T08:55:13Z

@dubielzyk-expensify @dukenv0307 Here are scrolling videos

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android_web.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios_web.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

dukenv0307 · 2024-11-07T08:59:31Z

@VickyStash I think we should scroll the card list only, not all RHP. You can refer to another page like currency. wdyt?

Screen.Recording.2024-11-07.at.15.58.21.mov

VickyStash · 2024-11-07T09:02:45Z

@dukenv0307 Please, see the related discussion in the issue.
Scrolling of just the list was causing the keyboard overlapping in case of this screen.
The one you provided as a reference has less content above the list/search, which makes it okay.

dukenv0307 · 2024-11-07T09:05:30Z

@VickyStash Thanks for pointing that out

dukenv0307

LGTM

dubielzyk-expensify · 2024-11-07T23:17:11Z

The padding above the button should be the same as we do elsewhere in the app which is 0. Currently it seems different in almost all the recordings.

On other screens:

Otherwise this is looking good

VickyStash · 2024-11-08T09:52:18Z

@dubielzyk-expensify updated!

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

shawnborton · 2024-11-08T10:14:17Z

Good catch @dubielzyk-expensify! Those updated screens look better to me 👍

mountiny

Thanks for the changes and the design team for help with nailing this down

mountiny · 2024-11-08T11:56:16Z

            RESTRICT: 'corporate',
            ALLOW: 'personal',
        },
+        CARD_LIST_THRESHOLD: 8,


I think we should make a generic const for this, any list like this should turn into a searchable list if it has more than 8 elements

mountiny · 2024-11-08T11:58:17Z

-                            />
-                        </View>
-                    )}
+                <View style={[styles.flex1, (!isKeyboardShown || !!footerContent || showConfirmButton) && includeSafeAreaPaddingBottom && safeAreaPaddingBottomStyle, containerStyle]}>


@dukenv0307 @VickyStash, let's be on the lookout for any bugs related to these. Changing the base components is like pandora box

OSBotify · 2024-11-08T12:10:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-11T18:39:53Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.60-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

joekaufmanexpensify · 2024-11-11T22:47:23Z

Confirmed search field appears and is working as expected

github-actions · 2024-11-13T00:43:22Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.60-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

hungvu193 · 2025-03-04T14:36:50Z

+                        }
+                        shouldShowTextInputAfterHeader
+                        includeSafeAreaPaddingBottom={false}
+                        shouldShowListEmptyContent={false}


We should implement empty content instead of setting it to false here to make the UI consistent with other places.

More details at: #56078 (comment)

Add cards list search bar

9a98fec

VickyStash mentioned this pull request Nov 4, 2024

[HOLD for payment 2024-11-20] [Workspace feeds] Assign card list missing search bar with 8+ cards #51906

Closed

8 tasks

VickyStash added 4 commits November 5, 2024 14:44

Merge branch 'refs/heads/main' into VickyStash/feature/51906-card-lis…

5bac1ab

…t-search

Merge branch 'refs/heads/main' into VickyStash/feature/51906-card-lis…

aaabf8b

…t-search

Fix keyboard overlapping on small devices

1da4eae

Minor fix

a3e9c13

VickyStash marked this pull request as ready for review November 6, 2024 16:16

VickyStash requested a review from a team as a code owner November 6, 2024 16:16

melvin-bot Bot requested review from dukenv0307 and removed request for a team November 6, 2024 16:16

dukenv0307 reviewed Nov 6, 2024

View reviewed changes

Comment thread src/pages/workspace/companyCards/assignCard/CardSelectionStep.tsx Outdated

Rename CARD_LIST_THRESHOLD const

b46bc0c

dukenv0307 approved these changes Nov 7, 2024

View reviewed changes

melvin-bot Bot requested a review from mountiny November 7, 2024 09:26

mountiny assigned VickyStash Nov 7, 2024

Update startTransactionDate -> transactionStartDate

952c0f0

VickyStash added 2 commits November 8, 2024 09:59

Remove padding above the button

8082a9a

Remove extra padding above the button on ios

a9bdbe2

mountiny added the InternalQA This pull request required internal QA label Nov 8, 2024

mountiny approved these changes Nov 8, 2024

View reviewed changes

mountiny merged commit 81c17e8 into Expensify:main Nov 8, 2024

github-actions Bot mentioned this pull request Nov 11, 2024

[HOLD for payment 2024-11-21] Deploy Checklist: New Expensify 2024-11-11 #52320

Closed

95 tasks

hungvu193 reviewed Mar 4, 2025

View reviewed changes

Uh oh!

Conversation

VickyStash commented Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 6, 2024

Uh oh!

Uh oh!

dukenv0307 commented Nov 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 commented Nov 6, 2024

Uh oh!

dubielzyk-expensify commented Nov 7, 2024

Uh oh!

dukenv0307 commented Nov 7, 2024

Uh oh!

VickyStash commented Nov 7, 2024

Screenshots/Videos

Uh oh!

dukenv0307 commented Nov 7, 2024

Uh oh!

VickyStash commented Nov 7, 2024

Uh oh!

dukenv0307 commented Nov 7, 2024

Uh oh!

dukenv0307 left a comment

Choose a reason for hiding this comment

Uh oh!

dubielzyk-expensify commented Nov 7, 2024

Uh oh!

VickyStash commented Nov 8, 2024

Screenshots/Videos

Uh oh!

shawnborton commented Nov 8, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Nov 8, 2024

Choose a reason for hiding this comment

Uh oh!

mountiny Nov 8, 2024

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Nov 8, 2024

Uh oh!

github-actions Bot commented Nov 11, 2024

Uh oh!

joekaufmanexpensify commented Nov 11, 2024

Uh oh!

github-actions Bot commented Nov 13, 2024

Uh oh!

hungvu193 Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

VickyStash commented Nov 4, 2024 •

edited

Loading

dukenv0307 commented Nov 6, 2024 •

edited

Loading