[AWAITING CHECKLIST] [$250] Company card - Missing "No results found" message when there is no card result

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.92-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+ccardfeed@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Workspace has at least 9 unassigned company card.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Company card.
3. Click Assign card.
4. Select a user.
5. Click Next.
6. Enter anything that will not return any result.

Expected Result:

There should be "No results found" message.

Actual Result:

There is no "No results found" message when there is no card result.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021886501667180953103
• Upwork Job ID: 1886501667180953103
• Last Price Increase: 2025-02-03
• Automatic offers:
• FitseTLT | Contributor | 106005590

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

🚨 Edited by proposal-police: This proposal was edited at 2025-01-30 15:03:03 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Company card - Missing "No results found" message when there is no card result

What is the root cause of that problem?

We are passing shouldShowListEmptyContent as false here

App/src/pages/workspace/companyCards/assignCard/CardSelectionStep.tsx

Line 161 in a32c86b

shouldShowListEmptyContent={false}

What changes do you think we should make in order to solve the problem?

We should remove

App/src/pages/workspace/companyCards/assignCard/CardSelectionStep.tsx

Line 161 in a32c86b

shouldShowListEmptyContent={false}

and pass the component to show on empty case as listEmptyContent for list something like we do here for instance or here

App/src/pages/workspace/companyCards/WorkspaceCompanyCardAccountSelectCardPage.tsx

Lines 49 to 57 in a32c86b

	const listEmptyContent = useMemo(
	() => (
	<BlockingView
	icon={Illustrations.TeleScope}
	iconWidth={variables.emptyListIconWidth}
	iconHeight={variables.emptyListIconHeight}
	title={translate('workspace.moreFeatures.companyCards.noAccountsFound')}
	subtitle={currentConnectionName ? translate('workspace.moreFeatures.companyCards.noAccountsFoundDescription', {connection: currentConnectionName}) : undefined}
	containerStyle={styles.pb10}

but we will decide on exactly what to show with the design team suggestion including the right copy and design.

Alternatively, if we want a simple no result found text then we can pass a headerMessage of no results copy to the SelectionList when searchedListOptions is empty like we do here

App/src/components/Search/SearchFiltersParticipantsSelector.tsx

Lines 118 to 119 in a32c86b

	const noResultsFound = chatOptions.personalDetails.length === 0 && chatOptions.recentReports.length === 0 && !chatOptions.currentUserOption;
	const message = noResultsFound ? translate('common.noResultsFound') : undefined;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N / A

What alternative solutions did you explore? (Optional)

[melvin-bot]

@garrettmknight Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021886501667180953103

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[hungvu193]

Let's add "No results found" text when there's no result like we did in other places. @FitseTLT 's proposal is straightforward.
🎀 👀 🎀 C+ reviewed