hide hold option for invoices by codewaseem · Pull Request #49875 · Expensify/App

codewaseem · 2024-09-28T03:13:06Z

Details

I removed the hold option for invoices, as invoices cannot be on hold.

Fixed Issues

$ #47570
PROPOSAL: #47570 (comment)

Tests

Click FAB.
Select the send invoice option.
Create an invoice with some amount and send it to another user.
Right-click on the invoice preview you just created to open the floating context menu.
Make sure there is no "Hold" option shown in the list.
Open the invoice by clicking the invoice preview.
Click on the invoice header to open the invoice details side-drawer.
Make sure there is no "Hold" option shown.

That is make sure there is no hold option shown for the invoices in these two places.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Click FAB.
Select the send invoice option.
Create an invoice with some amount and send it to another user.
Right-click on the invoice preview you just created to open the floating context menu.
Make sure there is no "Hold" option shown in the list.
Open the invoice by clicking the invoice preview.
Click on the invoice header to open the invoice details side-drawer.
Make sure there is no "Hold" option shown.

That is make sure there is no hold option shown for the invoices in these two places.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

No hold option shown in these two places for invoices.

Android: mWeb Chrome

No hold option shown in these two places for invoices.

iOS: Native

No hold option shown in these two places for invoices.

iOS: mWeb Safari

No hold option shown in these two places for invoices.

MacOS: Chrome / Safari

web.webm

MacOS: Desktop

desktop.webm

melvin-bot · 2024-09-28T03:13:12Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2024-09-28T03:13:23Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

codewaseem · 2024-09-28T03:15:52Z

I have read the CLA Document and I hereby sign the CLA

codewaseem · 2024-09-28T03:17:51Z

recheck

abdulrahuman5196 · 2024-10-02T16:41:08Z

Code looks fine. let me work on platform testing

abdulrahuman5196 · 2024-10-03T16:43:05Z

@mjasikowski Could you kindly run the approval steps? To avoid any lint errors after C+ testing?

mjasikowski · 2024-10-03T17:27:15Z

@abdulrahuman5196 done

abdulrahuman5196 · 2024-10-04T14:32:01Z

@codewaseem Some of the tests are failing. Could you kindly merge with main and fix any issues if present?

codewaseem · 2024-10-05T03:56:28Z

@abdulrahuman5196 I have merged with latest main and replaced the usage withOnyx with useOnyx hook which was causing lint errors based on the updated eslint rules. Can you please recheck? Thanks.

abdulrahuman5196 · 2024-10-05T15:26:47Z

@mjasikowski We are not even updating onyx data in this PR as per the original issue. Do we still need to the onyx migration?

mjasikowski · 2024-10-07T06:06:12Z

@mjasikowski We are not even updating onyx data in this PR as per the original issue. Do we still need to the onyx migration?

@mountiny can you comment on this one?

mountiny · 2024-10-07T11:33:17Z

let's not do the migration in this PR. Can you please revert to withOnyx and let's merge this with the failing action? This is a complex component so I think we should migrate it in a specific PR where we will test the component thoroughly

codewaseem · 2024-10-07T11:43:15Z

@mountiny @mjasikowski @abdulrahuman5196
I have reverted to withOnyx HOC as before.

abdulrahuman5196 · 2024-10-10T14:40:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-10.at.8.02.27.PM.mp4

Android: mWeb Chrome

Screen.Recording.2024-10-10.at.8.05.00.PM.mp4

iOS: Native

Screen.Recording.2024-10-10.at.7.59.56.PM.mp4

iOS: mWeb Safari

Screen.Recording.2024-10-10.at.8.01.02.PM.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-10-10.at.7.56.27.PM.mp4

MacOS: Desktop

Screen.Recording.2024-10-10.at.7.58.57.PM.mp4

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @mjasikowski

🎀 👀 🎀
C+ Reviewed

abdulrahuman5196 · 2024-10-10T14:42:52Z

The checks failure are not related to this PR. We should be fine to go ahead.

mjasikowski

Looks good @codewaseem, thank you!

melvin-bot · 2024-10-11T09:30:24Z

@mjasikowski looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

mjasikowski · 2024-10-11T09:32:10Z

ESLint failures were unrelated

OSBotify · 2024-10-11T09:40:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-15T03:30:08Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.0.49-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-17T01:45:04Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.49-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

hide hold option for invoices

8b44ad0

codewaseem requested a review from a team as a code owner September 28, 2024 03:13

melvin-bot Bot requested review from abdulrahuman5196 and removed request for a team September 28, 2024 03:13

codewaseem and others added 2 commits October 5, 2024 07:20

Merge branch 'Expensify:main' into 47570-hide-hold-for-invoice

75b8f06

fix lint errors based on updated eslint rules

a6445bd

mjasikowski assigned codewaseem Oct 7, 2024

revert withOnyx changes

183b8f5

abdulrahuman5196 approved these changes Oct 10, 2024

View reviewed changes

melvin-bot Bot requested a review from mjasikowski October 10, 2024 14:42

mjasikowski approved these changes Oct 10, 2024

View reviewed changes

mjasikowski merged commit abdfb72 into Expensify:main Oct 11, 2024

melvin-bot Bot added the Emergency label Oct 11, 2024

mjasikowski removed the Emergency label Oct 11, 2024

github-actions Bot mentioned this pull request Oct 15, 2024

Deploy Checklist: New Expensify 2024-10-15 #50764

Closed

71 tasks

melvin-bot Bot mentioned this pull request Oct 17, 2024

[HOLD for payment 2024-10-24] [$250] Invoices - Hold option is present in context menu before invoice report is opened #47570

Closed

6 tasks

Uh oh!

Conversation

codewaseem commented Sep 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 28, 2024

Uh oh!

github-actions Bot commented Sep 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codewaseem commented Sep 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codewaseem commented Sep 28, 2024

Uh oh!

abdulrahuman5196 commented Oct 2, 2024

Uh oh!

abdulrahuman5196 commented Oct 3, 2024

Uh oh!

mjasikowski commented Oct 3, 2024

Uh oh!

abdulrahuman5196 commented Oct 4, 2024

Uh oh!

codewaseem commented Oct 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abdulrahuman5196 commented Oct 5, 2024

Uh oh!

mjasikowski commented Oct 7, 2024

Uh oh!

mountiny commented Oct 7, 2024

Uh oh!

codewaseem commented Oct 7, 2024

Uh oh!

abdulrahuman5196 commented Oct 10, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

Uh oh!

abdulrahuman5196 commented Oct 10, 2024

Uh oh!

mjasikowski left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Oct 11, 2024

Uh oh!

mjasikowski commented Oct 11, 2024

Uh oh!

OSBotify commented Oct 11, 2024

Uh oh!

github-actions Bot commented Oct 15, 2024

Uh oh!

github-actions Bot commented Oct 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codewaseem commented Sep 28, 2024 •

edited

Loading

github-actions Bot commented Sep 28, 2024 •

edited

Loading

codewaseem commented Sep 28, 2024 •

edited

Loading

codewaseem commented Oct 5, 2024 •

edited

Loading