[HOLD for payment 2024-10-24] [$250] Invoices - Hold option is present in context menu before invoice report is opened

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.21-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4864172
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Send invoice.
3. Enter amount, select any user and send the invoice.
4. Without clicking on the invoice preview (important), right click on the invoice preview in invoice chat.
5. Note that Hold option is present.
6. Click on the invoice preview.
7. Return to invoice chat.
8. Right click on the invoice preview.
9. Note that Hold option disappears.

Expected Result:

In Step 5, Hold option should not appear for invoice because invoices cannot be held.

Actual Result:

In Step 5, Hold option appears for invoice.
In Step 9, Hold option disappears after user opens the invoice report.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6573869_1723821203429.20240816_230930.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021839686152805650965
• Upwork Job ID: 1839686152805650965
• Last Price Increase: 2024-09-27

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #vip-bills

[IuliiaHerets]

@VictoriaExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[codewaseem]

Edited by proposal-police: This proposal was edited at 2024-09-17 16:16:35 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The hold option appears in the context menu which should not happen for invoices.

What is the root cause of that problem?

The areHoldRequirementsMet condition doesn't exclude invoice type here:

App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx

Lines 178 to 180 in 6aa873d

	const areHoldRequirementsMet = isMoneyRequestOrReport && !ReportUtils.isArchivedRoom(transactionThreadReportID ? childReport : parentReport, parentReportNameValuePairs);

What changes do you think we should make in order to solve the problem?

Making sure areHoldRequirementsMet returns false for invoice type solves this problem. Here are the changes to be made

   const isMoneyRequestOrReport = isMoneyRequestReport || isSingleTransactionView;

    const areHoldRequirementsMet =
        !isInvoiceReport && isMoneyRequestOrReport && !ReportUtils.isArchivedRoom(transactionThreadReportID ? childReport : parentReport, parentReportNameValuePairs);

Added !isInvoiceReport to areHoldRequirementsMet and removed isInvoiceReport from isMoneyRequestOrReport which is not need.

To hide the hold option from ReportDetails view, need to update the ReportUtils.canHoldUnholdReportAction function with the following

function canHoldUnholdReportAction(reportAction: OnyxInputOrEntry<ReportAction>): {canHoldRequest: boolean; canUnholdRequest: boolean} {
    if (!ReportActionsUtils.isMoneyRequestAction(reportAction)) {
        return {canHoldRequest: false, canUnholdRequest: false};
    }

    const moneyRequestReportID = ReportActionsUtils.getOriginalMessage(reportAction)?.IOUReportID ?? 0;
    const moneyRequestReport = getReportOrDraftReport(String(moneyRequestReportID));

    if (!moneyRequestReportID || !moneyRequestReport) {
        return {canHoldRequest: false, canUnholdRequest: false};
    }

    if (isInvoiceReport(moneyRequestReport)) {
        return {
            canHoldRequest: false,
            canUnholdRequest: false,
        };
    }
   ...

What alternative solutions did you explore? (Optional)

[melvin-bot]

@VictoriaExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[VictoriaExpensify]

I agree this is an issue and we should fix it!

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.