Skip to content

Revert "fix: admin can delete expenses"#49178

Merged
luacmartins merged 1 commit into
mainfrom
revert-48998-fix/46762
Sep 13, 2024
Merged

Revert "fix: admin can delete expenses"#49178
luacmartins merged 1 commit into
mainfrom
revert-48998-fix/46762

Conversation

@luacmartins

Copy link
Copy Markdown
Contributor

Reverts #48998

$ #49157

@luacmartins luacmartins self-assigned this Sep 13, 2024
@luacmartins luacmartins marked this pull request as ready for review September 13, 2024 14:14
@luacmartins luacmartins requested a review from a team as a code owner September 13, 2024 14:14
@melvin-bot melvin-bot Bot requested review from nkuoch and removed request for a team September 13, 2024 14:15
@melvin-bot

melvin-bot Bot commented Sep 13, 2024

Copy link
Copy Markdown

@nkuoch Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, straight revert

@luacmartins luacmartins merged commit 8b77673 into main Sep 13, 2024
@luacmartins luacmartins deleted the revert-48998-fix/46762 branch September 13, 2024 14:23
@melvin-bot melvin-bot Bot added the Emergency label Sep 13, 2024
@melvin-bot

melvin-bot Bot commented Sep 13, 2024

Copy link
Copy Markdown

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify pushed a commit that referenced this pull request Sep 13, 2024
Revert "fix: admin can delete expenses"

(cherry picked from commit 8b77673)

(CP triggered by luacmartins)
@github-actions github-actions Bot added the CP Staging marks PRs that have been CP'd to staging label Sep 13, 2024
@luacmartins

Copy link
Copy Markdown
Contributor Author

Straight revert, no checklist

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.0.34-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.34-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants