Expense - Error when deleting expense when Delay submissions is enabled

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.34-2
Reproducible in staging?: Y
Reproducible in production?: N/A - no delete option in Admin side
Issue was found when executing this PR: #48998
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Admin and employee are in the same workspace.
• Delay submissions is enabled in Worflows page.

1. Go to staging.new.expensify.com
2. [Employee] Submit an expense in the workspace chat, but do not click the Submit button.
3. [Admin] Go to transaction thread in the workspace chat.
4. [Admin] Click on the report header.
5. [Admin] Click Delete expense.
6. [Admin] Delete the expense.

Expected Result:

The expense should be deleted because delete option is present.
On prod, delete option is not available.

Actual Result:

The expense is not deleted and error shows up.
Also, when selecting the same expense in Search, there is no delete option from the dropdown but it is present in the transaction thread.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6601953_1726210847476.20240913_145443.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The expense is not deleted and error shows up.
Also, when selecting the same expense in Search, there is no delete option from the dropdown but it is present in the transaction thread.

What is the root cause of that problem?

The expense is not deleted and error shows up.

In

App/src/libs/ReportUtils.ts

Lines 1668 to 1683 in 00bc167

	function canAddOrDeleteTransactions(moneyRequestReport: OnyxEntry<Report>): boolean {
	if (!isMoneyRequestReport(moneyRequestReport)) {
	return false;
	}
	const policy = getPolicy(moneyRequestReport?.policyID);
	if (PolicyUtils.isInstantSubmitEnabled(policy) && PolicyUtils.isSubmitAndClose(policy) && hasOnlyNonReimbursableTransactions(moneyRequestReport?.reportID)) {
	return false;
	}
	if (isReportApproved(moneyRequestReport) || isSettled(moneyRequestReport?.reportID)) {
	return false;
	}
	return true;
	}

We see that when WS has Delayed submission, PolicyUtils.isIntantSubmitEnabled is false, the transaction is not approved or settled, so ReportUtils.canDeleteTransaction returns true, results in

App/src/pages/ReportDetailsPage.tsx

Line 202 in 00bc167

const canDeleteRequest = (isActionOwner || isPolicyAdmin) && (ReportUtils.canDeleteTransaction(moneyRequestReport) || isSelfDMTrackExpenseReport) && !isDeletedParentAction;

becomes true, the Delete Button is shown.

Also, when selecting the same expense in Search, there is no delete option from the dropdown but it is present in the transaction thread.

This is expected, as in

App/src/components/Search/SearchPageHeader.tsx

Line 228 in 00bc167

const shouldShowDeleteOption = !isOffline && selectedTransactionsKeys.every((id) => selectedTransactions[id].canDelete);

transaction doesn't have canDelete in Onyx, so shouldShowDeleteOption is false

What changes do you think we should make in order to solve the problem?

Update

App/src/libs/ReportUtils.ts

Line 1674 in 00bc167

if (PolicyUtils.isInstantSubmitEnabled(policy) && PolicyUtils.isSubmitAndClose(policy) && hasOnlyNonReimbursableTransactions(moneyRequestReport?.reportID)) {

to

if (!PolicyUtils.isInstantSubmitEnabled(policy) && PolicyUtils.isSubmitAndClose(policy) && hasOnlyNonReimbursableTransactions(moneyRequestReport?.reportID)) {

So that the Delete options is hidden when WS has delayed submission

What alternative solutions did you explore? (Optional)

[flodnv]

Hmmm, this solution implies that the owner also won't be able to delete the transaction, which I think is wrong?