Skip to content

[CP Staging]Fix: App crashes when upload PDF #37484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MonilBhavsar merged 2 commits into from
Feb 29, 2024
Merged

[CP Staging]Fix: App crashes when upload PDF #37484

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec2b94c
fix: app crash when upload pdf
tienifr Feb 29, 2024
07eb158
fix lint
tienifr Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/Attachments/AttachmentView/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,9 @@ function AttachmentView({
const encryptedSourceUrl = isAuthTokenRequired ? addEncryptedAuthTokenToURL(source) : source;

const onPDFLoadComplete = (path) => {
if (path && (transaction.transactionID || reportActionID)) {
CachedPDFPaths.add(transaction.transactionID || reportActionID, path);
const id = (transaction && transaction.transactionID) || reportActionID;
if (path && id) {
CachedPDFPaths.add(id, path);

@getusha getusha Feb 29, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tienifr just noticed this, since we should not be storing the path on web could we only add it on native?

@tienifr tienifr Feb 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CachePDFPath already has platform-dependent files (i.e. noop functions on web).

@getusha getusha Feb 29, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CachePDFPath already has platform-dependent files (i.e. noop functions on web).

Forgot about that 😆

}
if (!loadComplete) {
setLoadComplete(true);
Expand Down