[CP Staging]Fix: App crashes when upload PDF by tienifr · Pull Request #37484 · Expensify/App

tienifr · 2024-02-29T11:08:09Z

Details

This PR fixes app crashes when upload PDF due to undefined value.

Fixed Issues

$ #32232
$ #37469
PROPOSAL:

Tests

Open any chat and add PDF attachment
Verify app does not crash
Navigate to a chat with a sent PDF file before
Send an image or a video
Open sent attachment
Verify app does not crash

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Open any chat and add PDF attachment
Verify app does not crash
Navigate to a chat with a sent PDF file before
Send an image or a video
Open sent attachment
Verify app does not crash

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-29.at.18.28.14-compressed.mov

Android: mWeb Chrome

Screen.Recording.2024-02-29.at.18.24.22-compressed.mov

iOS: Native

Screen.Recording.2024-02-29.at.18.08.25-compressed.mov

iOS: mWeb Safari

Screen.Recording.2024-02-29.at.18.11.41-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-29.at.18.09.42-compressed.mov

MacOS: Desktop

Screen.Recording.2024-02-29.at.18.09.42-compressed.mov

tienifr · 2024-02-29T11:14:06Z

@getusha Please review this crash deploy blocker ASAP! Thanks!

melvin-bot · 2024-02-29T11:21:25Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

getusha · 2024-02-29T13:09:05Z

Will review it, thanks!

getusha · 2024-02-29T13:10:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-29.at.9.15.07.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-02-29.at.9.19.07.PM.mov

iOS: Native

Screen.Recording.2024-02-29.at.9.04.31.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-02-29.at.9.16.42.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-29.at.9.13.12.PM.mov

MacOS: Desktop

Screen.Recording.2024-02-29.at.9.22.51.PM.mov

getusha · 2024-02-29T17:54:05Z

-                CachedPDFPaths.add(transaction.transactionID || reportActionID, path);
+            const id = (transaction && transaction.transactionID) || reportActionID;
+            if (path && id) {
+                CachedPDFPaths.add(id, path);


@tienifr just noticed this, since we should not be storing the path on web could we only add it on native?

CachePDFPath already has platform-dependent files (i.e. noop functions on web).

CachePDFPath already has platform-dependent files (i.e. noop functions on web).

Forgot about that 😆

MonilBhavsar

Thanks!

[CP Staging]Fix: App crashes when upload PDF (cherry picked from commit e4e98a2)

OSBotify · 2024-02-29T19:06:25Z

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 1.4.45-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-02-29T23:33:26Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.45-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: app crash when upload pdf

ec2b94c

tienifr marked this pull request as ready for review February 29, 2024 11:13

tienifr requested a review from a team as a code owner February 29, 2024 11:13

fix lint

07eb158

melvin-bot Bot removed the request for review from a team February 29, 2024 11:21

melvin-bot Bot requested a review from getusha February 29, 2024 11:21

tienifr changed the title ~~Fix: App crash when upload PDF~~ Fix: App crashes when upload PDF Feb 29, 2024

MonilBhavsar changed the title ~~Fix: App crashes when upload PDF~~ [CP Staging]Fix: App crashes when upload PDF Feb 29, 2024

getusha reviewed Feb 29, 2024

View reviewed changes

getusha approved these changes Feb 29, 2024

View reviewed changes

melvin-bot Bot requested a review from MonilBhavsar February 29, 2024 18:25

MonilBhavsar approved these changes Feb 29, 2024

View reviewed changes

MonilBhavsar merged commit e4e98a2 into Expensify:main Feb 29, 2024

OSBotify pushed a commit that referenced this pull request Feb 29, 2024

Merge pull request #37484 from tienifr/fix/37469

b97f123

[CP Staging]Fix: App crashes when upload PDF (cherry picked from commit e4e98a2)

github-actions Bot mentioned this pull request Feb 29, 2024

Deploy Checklist: New Expensify 2024-02-28 #37459

Closed

91 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[CP Staging]Fix: App crashes when upload PDF#37484

[CP Staging]Fix: App crashes when upload PDF#37484
MonilBhavsar merged 2 commits into
Expensify:mainfrom
tienifr:fix/37469

tienifr commented Feb 29, 2024 •

edited

Loading

Uh oh!

tienifr commented Feb 29, 2024

Uh oh!

melvin-bot Bot commented Feb 29, 2024

Uh oh!

getusha commented Feb 29, 2024

Uh oh!

getusha commented Feb 29, 2024 •

edited

Loading

Uh oh!

getusha Feb 29, 2024

Uh oh!

tienifr Feb 29, 2024 •

edited

Loading

Uh oh!

getusha Feb 29, 2024

Uh oh!

MonilBhavsar left a comment

Uh oh!

OSBotify commented Feb 29, 2024

Uh oh!

OSBotify commented Feb 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

tienifr commented Feb 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

tienifr commented Feb 29, 2024

Uh oh!

melvin-bot Bot commented Feb 29, 2024

Uh oh!

getusha commented Feb 29, 2024

Uh oh!

getusha commented Feb 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

getusha Feb 29, 2024

Choose a reason for hiding this comment

Uh oh!

tienifr Feb 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

getusha Feb 29, 2024

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Feb 29, 2024

Uh oh!

OSBotify commented Feb 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tienifr commented Feb 29, 2024 •

edited

Loading

getusha commented Feb 29, 2024 •

edited

Loading

tienifr Feb 29, 2024 •

edited

Loading