[TS migration] Migrate 'ReportActionCompose' component to TypeScript by kubabutkiewicz · Pull Request #34646 · Expensify/App

kubabutkiewicz · 2024-01-17T14:38:03Z

Details

Fixed Issues

$ #31984

Tests

Login into app
Start a chat
Type in composer '@'
Suggestions should appear
Type some email/name
Select User
Send message
Type in composer ":"
Emoji suggestions should appear
Type ":smil:"
Emoji Suggestion should filter
Select one of the emojis

Verify that no errors appear in the JS console

Offline tests

QA Steps

Login into app
Start a chat
Type in composer '@'
Suggestions should appear
Type some email/name
Select User
Send message
Type in composer ":"
Emoji suggestions should appear
Type ":smil:"
Emoji Suggestion should filter
Select one of the emojis

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

mchrome.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

msafari.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

…s-migration/ReportActionCompose

…stions and ReportActionCompose

…, start migrating ReportTypeingIndicator

…s-migration/ReportActionCompose

kubabutkiewicz · 2024-02-27T13:23:40Z

@Ollyws no idea yet, I am looking into this

kubabutkiewicz · 2024-02-27T13:40:34Z

@Ollyws there is one additional rerender caused by usage of useIsFocused hook instead of using withNavigationFocus HOC. Are we good with that? cause I think our goal also is to get rid of as much hocs as we can

Ollyws · 2024-02-27T13:53:37Z

Sounds fine to me, but let's double check with an internal engineer.

kubabutkiewicz · 2024-02-27T13:54:50Z

@Ollyws there is one additional rerender caused by usage of useIsFocused hook instead of using withNavigationFocus HOC. Are we good with that? cause I think our goal also is to get rid of as much hocs as we can

@roryabraham @mountiny Are we good with this ?

Ollyws · 2024-02-27T13:55:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

01_Android_Native.mp4

Android: mWeb Chrome

02_Android_Chrome.mp4

iOS: Native

03_iOS_Native.mp4

iOS: mWeb Safari

04_iOS_Safari.mp4

MacOS: Chrome / Safari

05_MacOS_Chrome.mp4

MacOS: Desktop

06_MacOS_Desktop.mp4

Ollyws

Aside from the perf-tests failing as discussed in #34646 (comment), LGTM.

melvin-bot · 2024-02-27T13:57:06Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #31984 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

luacmartins

LGTM. Just a couple NAB

luacmartins · 2024-02-27T16:06:58Z

+    // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing -- Disabling this line for safeness as nullish coalescing works only if the value is undefined or null
+    const reportRecipientTimezone = participant.timezone || CONST.DEFAULT_TIME_ZONE;


NAB

Suggested change

// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing -- Disabling this line for safeness as nullish coalescing works only if the value is undefined or null

const reportRecipientTimezone = participant.timezone || CONST.DEFAULT_TIME_ZONE;

const reportRecipientTimezone = (participant.timezone ?? '') || CONST.DEFAULT_TIME_ZONE;

@luacmartins I am not sure this is needed , if participant.timezone will be undefined or '' the variable will be set to CONST.DEFAULT_TIME_ZONE so adding ?? '' seems to me redundant

yea, I agree. It was just a suggestion so we don't need to suppress the lint rule

luacmartins · 2024-02-27T16:07:29Z

+    // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing -- Disabling this line for safeness as nullish coalescing works only if the value is undefined or null
+    const reportRecipientDisplayName = participant.firstName || participant.displayName;


Suggested change

// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing -- Disabling this line for safeness as nullish coalescing works only if the value is undefined or null

const reportRecipientDisplayName = participant.firstName || participant.displayName;

const reportRecipientDisplayName = (participant.firstName ?? '') || participant.displayName;

luacmartins · 2024-02-27T16:13:16Z

@Ollyws there is one additional rerender caused by usage of useIsFocused hook instead of using withNavigationFocus HOC. Are we good with that? cause I think our goal also is to get rid of as much hocs as we can

This is not ideal, but at the same time I don't think it's a blocker. Do we know the actual time this additional re-render would add?

mountiny · 2024-02-27T20:27:58Z

I agree that its not ideal. There is more re-renders, but also the component tree gets slimmer, I guess that is the compromise. I think we do not have to block on this

luacmartins · 2024-02-27T20:34:45Z

@kubabutkiewicz we also have conflicts now

…s-migration/ReportActionCompose

kubabutkiewicz · 2024-02-28T09:52:53Z

@luacmartins its fixed

luacmartins · 2024-02-28T15:47:45Z

Gonna merge with the failing performance tests given this and this comment

melvin-bot · 2024-02-28T15:47:59Z

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

luacmartins · 2024-02-28T15:48:08Z

See comment above

OSBotify · 2024-02-28T15:53:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-29T00:06:34Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.45-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-29T23:31:02Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.45-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kubabutkiewicz added 2 commits January 17, 2024 15:37

fix: wip

fab9c8e

fix: finish working on migration

25f6646

VickyStash reviewed Jan 19, 2024

View reviewed changes

kubabutkiewicz added 22 commits January 19, 2024 10:52

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

214e563

…s-migration/ReportActionCompose

fix: resolve comments

5e2f31c

ref: move SuggestionMention, Suggestions to TS, fixes to MentionSugge…

2a0e3e2

…stions and ReportActionCompose

fix: started migrating SuggestionEmoji component

717a5e8

fix: migrate SuggestionEmoji

7c71325

fix: SuggestionEmoji and Suggestions types, migrate SendButton

be57be3

fix: migrate AttachmentPickerWithMenuItems

929a51a

fix: Migrate SilentCommentUpdater

0cc6502

fix: ComposerWithSuggestion migration

8ed208c

fix: keep working on ComposerWithSuggestions

fef68a4

fix: wip

223fdd8

fix: finished migrating ComposerWithSuggestions, removed unused files…

05bb0a5

…, start migrating ReportTypeingIndicator

fix: move ReportTypingIndicator to TS

cf84b3b

fix: migrate ParticipanLocalTime and ReportDropUI

87f22f7

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

035494a

…s-migration/ReportActionCompose

fix: typecheck

63a63ad

fix: minor fixes

1225d23

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

4c5a938

…s-migration/ReportActionCompose

fix: removed unused export

4f907d2

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

cbdfb71

…s-migration/ReportActionCompose

fix: typecheck

efa4178

fix: typecheck

99a4110

VickyStash reviewed Jan 30, 2024

View reviewed changes

VickyStash reviewed Jan 31, 2024

View reviewed changes

kubabutkiewicz added 3 commits February 2, 2024 16:28

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

090c788

…s-migration/ReportActionCompose

fix: typecheck

45c6530

fix: resolve comments

61ad476

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

238bd8d

…s-migration/ReportActionCompose

Ollyws approved these changes Feb 27, 2024

View reviewed changes

luacmartins self-requested a review February 27, 2024 15:59

luacmartins previously approved these changes Feb 27, 2024

View reviewed changes

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

6f7f2d4

…s-migration/ReportActionCompose

kubabutkiewicz dismissed luacmartins’s stale review via 6f7f2d4 February 28, 2024 09:12

kubabutkiewicz added 2 commits February 28, 2024 10:38

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

cb62bd4

…s-migration/ReportActionCompose

fix: typecheck

64368d5

luacmartins approved these changes Feb 28, 2024

View reviewed changes

luacmartins merged commit fc828da into Expensify:main Feb 28, 2024

melvin-bot Bot added the Emergency label Feb 28, 2024

luacmartins removed the Emergency label Feb 28, 2024

github-actions Bot mentioned this pull request Feb 28, 2024

Deploy Checklist: New Expensify 2024-02-28 #37459

Closed

91 tasks

TaduJR mentioned this pull request Jan 16, 2026

[$125] TalkBack: Many Pages: Cannot activate the button 'Send' cannot be activated #77460

Closed

		// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing -- Disabling this line for safeness as nullish coalescing works only if the value is undefined or null
		const reportRecipientTimezone = participant.timezone \|\| CONST.DEFAULT_TIME_ZONE;

	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing -- Disabling this line for safeness as nullish coalescing works only if the value is undefined or null
	const reportRecipientTimezone = participant.timezone \|\| CONST.DEFAULT_TIME_ZONE;
	const reportRecipientTimezone = (participant.timezone ?? '') \|\| CONST.DEFAULT_TIME_ZONE;

		// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing -- Disabling this line for safeness as nullish coalescing works only if the value is undefined or null
		const reportRecipientDisplayName = participant.firstName \|\| participant.displayName;

	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing -- Disabling this line for safeness as nullish coalescing works only if the value is undefined or null
	const reportRecipientDisplayName = participant.firstName \|\| participant.displayName;
	const reportRecipientDisplayName = (participant.firstName ?? '') \|\| participant.displayName;

Uh oh!

Conversation

kubabutkiewicz commented Jan 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kubabutkiewicz commented Feb 27, 2024

Uh oh!

kubabutkiewicz commented Feb 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ollyws commented Feb 27, 2024

Uh oh!

kubabutkiewicz commented Feb 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ollyws commented Feb 27, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

Ollyws left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Feb 27, 2024

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins Feb 27, 2024

Choose a reason for hiding this comment

Uh oh!

kubabutkiewicz Feb 28, 2024

Choose a reason for hiding this comment

Uh oh!

luacmartins Feb 28, 2024

Choose a reason for hiding this comment

Uh oh!

luacmartins Feb 27, 2024

Choose a reason for hiding this comment

Uh oh!

luacmartins commented Feb 27, 2024

Uh oh!

mountiny commented Feb 27, 2024

Uh oh!

luacmartins commented Feb 27, 2024

Uh oh!

kubabutkiewicz commented Jan 17, 2024 •

edited

Loading

kubabutkiewicz commented Feb 27, 2024 •

edited

Loading

kubabutkiewicz commented Feb 27, 2024 •

edited

Loading