-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Add updateMoneyRequestCategory command #34073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ddb7820
add new updateMoneyRequestCategory function
NikkiWines bd3759b
update category logic to use saveCategory
NikkiWines cecdfc3
const instead of let
NikkiWines 83a22dd
Merge branch 'main' of https://github.com/Expensify/App into nikki-up…
NikkiWines d2b1c59
Merge branch 'main' of https://github.com/Expensify/App into nikki-up…
NikkiWines c534060
Merge branch 'main' of https://github.com/Expensify/App into nikki-up…
NikkiWines 4611ebb
remove unused editMoneyRequest function
NikkiWines 8f55319
Merge branch 'main' of https://github.com/Expensify/App into nikki-up…
NikkiWines db1bbe7
add clarifying comment
NikkiWines ba4ce85
Merge branch 'main' of https://github.com/Expensify/App into nikki-up…
NikkiWines File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we prevent making an API call if newCategory is same as current?Oops, let's add this comment