Add updateMoneyRequestCategory command by NikkiWines · Pull Request #34073 · Expensify/App

NikkiWines · 2024-01-06T03:15:44Z

Details

Adds a new UpdateMoneyRequestCategory command in place of the broad EditMoneyRequest command for editing money request category

Fixed Issues

$ #32313
PROPOSAL: N/A

Tests

Log into an account on New Expensify that is the employee on workspace
Navigate to the Workspace chat and press + > Request Money
Add an amount and merchant and save the request
Click on the details for the request and add a category
Edit the category to be another category
Confirm in both cases that the category has updated successfully
Reload the app and confirm the category is still successfully updated.

Verify that no errors appear in the JS console

Offline tests

Log into an account on New Expensify that is the employee on workspace
Navigate to the Workspace chat and press + > Request Money
Add an amount and merchant and save the request
Click on the details for the request and add a category
Go offline
Edit the category to be another category
Confirm you see the pending category change

8. Go back online and confirm the category change is persisted.

QA Steps

Same as Tests steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-01-10.at.16.30.47.mov

MacOS: Desktop

Screen.Recording.2024-01-10.at.17.00.24.mov

…date-moneyrequest-category

melvin-bot · 2024-01-16T22:19:32Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jjcoffee · 2024-01-17T13:59:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-native-2024-01-17_15.58.47.mp4

Android: mWeb Chrome

android-chrome-2024-01-17_16.14.02.mp4

iOS: Native

ios-native-2024-01-17_15.33.23.mp4

iOS: mWeb Safari

ios-safari-2024-01-17_15.49.05.mp4

MacOS: Chrome / Safari

desktop-chrome-2024-01-17_15.18.11.mp4

MacOS: Desktop

desktop-app-2024-01-17_15.30.17.mp4

jjcoffee · 2024-01-17T14:33:00Z

@NikkiWines Looks good! Just missing native/mWeb screenshots 🙇

NikkiWines · 2024-01-18T19:47:12Z

Ah yeah, I've been having troubles with my iOS and Android emulators lately, hence the lack of videos. I'll try to get those sorted today but otherwise - since this doesn't actually impact the UI it should be consistent across all platforms - I think we can merge.

…date-moneyrequest-category

jjcoffee · 2024-01-19T08:44:21Z

@NikkiWines Ah no worries, I'll just approve then!

jjcoffee

LGTM!

melvin-bot · 2024-01-19T08:45:06Z

@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MonilBhavsar · 2024-01-22T09:20:30Z


+    const saveCategory = useCallback(
+        ({category: newCategory}) => {
+            const updatedCategory = newCategory === transactionCategory ? '' : newCategory;


~~Should we prevent making an API call if newCategory is same as current?~~
Oops, let's add this comment

// In case the same category has been selected, do reset of the category.

NikkiWines · 2024-01-22T19:19:13Z

@MonilBhavsar thanks for the review, updated!

…date-moneyrequest-category

MonilBhavsar

Thank you!

OSBotify · 2024-01-23T04:41:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-25T08:51:04Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.31-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

NikkiWines added 2 commits January 5, 2024 22:09

add new updateMoneyRequestCategory function

ddb7820

update category logic to use saveCategory

bd3759b

NikkiWines self-assigned this Jan 6, 2024

NikkiWines mentioned this pull request Jan 8, 2024

[HOLD for payment 2024-02-01] [DISTANCE] LOW: UpdateDistanceRequest 1:1:1 - UpdateMoneyRequestCategory - Split out into its own command #32313

Closed

NikkiWines added 5 commits January 10, 2024 14:39

const instead of let

cecdfc3

Merge branch 'main' of https://github.com/Expensify/App into nikki-up…

83a22dd

…date-moneyrequest-category

Merge branch 'main' of https://github.com/Expensify/App into nikki-up…

d2b1c59

…date-moneyrequest-category

Merge branch 'main' of https://github.com/Expensify/App into nikki-up…

c534060

…date-moneyrequest-category

remove unused editMoneyRequest function

4611ebb

NikkiWines changed the title ~~[HOLD] Add updateMoneyRequestCategory command~~ Add updateMoneyRequestCategory command Jan 16, 2024

NikkiWines marked this pull request as ready for review January 16, 2024 22:19

NikkiWines requested a review from a team as a code owner January 16, 2024 22:19

melvin-bot Bot requested review from jjcoffee and removed request for a team January 16, 2024 22:19

Merge branch 'main' of https://github.com/Expensify/App into nikki-up…

8f55319

…date-moneyrequest-category

jjcoffee approved these changes Jan 19, 2024

View reviewed changes

melvin-bot Bot requested a review from MonilBhavsar January 19, 2024 08:45

MonilBhavsar reviewed Jan 22, 2024

View reviewed changes

add clarifying comment

db1bbe7

Merge branch 'main' of https://github.com/Expensify/App into nikki-up…

ba4ce85

…date-moneyrequest-category

MonilBhavsar approved these changes Jan 23, 2024

View reviewed changes

MonilBhavsar merged commit 9c552ab into main Jan 23, 2024

MonilBhavsar deleted the nikki-update-moneyrequest-category branch January 23, 2024 04:35

github-actions Bot mentioned this pull request Jan 24, 2024

Deploy Checklist: New Expensify 2024-01-24 #35037

Closed

48 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add updateMoneyRequestCategory command#34073

Add updateMoneyRequestCategory command#34073
MonilBhavsar merged 10 commits into
mainfrom
nikki-update-moneyrequest-category

NikkiWines commented Jan 6, 2024 •

edited

Loading

Uh oh!

melvin-bot Bot commented Jan 16, 2024

Uh oh!

jjcoffee commented Jan 17, 2024 •

edited

Loading

Uh oh!

jjcoffee commented Jan 17, 2024

Uh oh!

NikkiWines commented Jan 18, 2024 •

edited

Loading

Uh oh!

jjcoffee commented Jan 19, 2024

Uh oh!

jjcoffee left a comment

Uh oh!

melvin-bot Bot commented Jan 19, 2024

Uh oh!

MonilBhavsar Jan 22, 2024 •

edited

Loading

Uh oh!

NikkiWines commented Jan 22, 2024

Uh oh!

MonilBhavsar left a comment

Uh oh!

OSBotify commented Jan 23, 2024

Uh oh!

OSBotify commented Jan 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

NikkiWines commented Jan 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 16, 2024

Uh oh!

jjcoffee commented Jan 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

jjcoffee commented Jan 17, 2024

Uh oh!

NikkiWines commented Jan 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jjcoffee commented Jan 19, 2024

Uh oh!

jjcoffee left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Jan 19, 2024

Uh oh!

MonilBhavsar Jan 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NikkiWines commented Jan 22, 2024

Uh oh!

MonilBhavsar left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jan 23, 2024

Uh oh!

OSBotify commented Jan 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

NikkiWines commented Jan 6, 2024 •

edited

Loading

jjcoffee commented Jan 17, 2024 •

edited

Loading

NikkiWines commented Jan 18, 2024 •

edited

Loading

MonilBhavsar Jan 22, 2024 •

edited

Loading